From: Markus Elfring <Markus.Elfring@web.de>
To: Conor Dooley <conor@kernel.org>,
Henry Bell <dmoo_dv@protonmail.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: RISC-V: add Star64 board devicetree
Date: Sat, 25 May 2024 14:41:01 +0200 [thread overview]
Message-ID: <3aeb3813-9a82-4b1f-9dd6-5baad2d45f2e@web.de> (raw)
In-Reply-To: <20240525-shirt-scratch-6708b2a4f63b@spud>
>>> Don't worry about Markus, most maintainers (myself included) ignore his
>>> comments on patches. The commit message here is fine.
>>
>> Would such a response mean also that you are occasionally ignoring requirements
>> from a referenced Linux development guideline?
>
> I do ignore it from time to time, yes. Being a stickler to the
> guidelines wastes everybody's time (just like this discussion).
> That said, the tense used in this patch is perfectly in-line with the
> guideline you reference.
Partly, yes.
> "Add Star64 board devicetree" is in the imperative
This information fits to the summary phrase.
> and the commit message body contains additional information about
> the board's configuration.
I hope that further contributors can follow the recommendation better
also for the imperative mood in changelogs.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
Regards,
Markus
prev parent reply other threads:[~2024-05-25 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 19:06 [PATCH] RISC-V: add Star64 board devicetree H Bell
2024-05-23 20:27 ` Krzysztof Kozlowski
2024-05-25 9:37 ` Markus Elfring
2024-05-25 10:12 ` Henry Bell
2024-05-25 10:19 ` Conor Dooley
2024-05-25 12:11 ` Markus Elfring
2024-05-25 12:25 ` Conor Dooley
2024-05-25 12:41 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aeb3813-9a82-4b1f-9dd6-5baad2d45f2e@web.de \
--to=markus.elfring@web.de \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmoo_dv@protonmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox