From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D98C77B73 for ; Tue, 2 May 2023 10:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233824AbjEBK5J (ORCPT ); Tue, 2 May 2023 06:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjEBK5H (ORCPT ); Tue, 2 May 2023 06:57:07 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F8C30F9 for ; Tue, 2 May 2023 03:57:05 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4efea4569f5so4249431e87.3 for ; Tue, 02 May 2023 03:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683025024; x=1685617024; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fvKKvkTKg6oLHxWWVpgf67tQd5w10evXj/uD0aHPu2E=; b=EnmSSG1gIihEHIM6w4cQaJiWNxIuqd85Q29d8kY0uFabwFf4xeii3hJTSCmt5dDBnO GwhKAU4GV8L+W8tiYrNVjA9Fz1N5DdoycTRxmu+0kIS/HlBvPflN2lTLdFgg9U5pnMTT EjVA/NyolJiO9qeuGvgXCZRgQXAttqvj0DoubyLqgDhhmqdngrDXXXXyAfCeQJm2Arcq 7j+haD0yiUudv4lFCIz9Ge8AinHucmxVbyJKT7wBCuV6wizwyxPUBMbRpCUXZIvOtEeo yfTQ5IotmLCKHC8PqLum4alHpGdXQVoVOxczUroJSQHMrMV8msoO3WSxvCW773Wcd+ud KF9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683025024; x=1685617024; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvKKvkTKg6oLHxWWVpgf67tQd5w10evXj/uD0aHPu2E=; b=GDvP/1zURP38wY1pWZEuJJajanhQlbQLqgPuo9UoyElCp6ahsMhvJVbedY+LIr2Oyx e1W9/3ZgAK1N9Jfqh/qhcqI/ouWhRJ8xDfL1nWlfjfq/oJ6Wkf6y+UOziI2/5+BF3uxI sELbJpE/taqGOkXJAGHskncUrNgoK5dVdYu+juBjt5XB+0CBclWxjM0D3/HdlCwXmCfZ nL9uVSDtCYjVxcpFW7M5NHL7ZhIRDyKtod4ysY3Z1euMFaWbcY80h06zGjuZoOqAfxnD +bljSt1YlwAjKkShbL1r2NorTF+o9SBIEo+rIu37ieKpDMJJc7Ml5mYe4jKt2Lw/NKFB Z5hw== X-Gm-Message-State: AC+VfDwXlv0ylgQvkSNO2RpouWunoj3Dottr6W3sgz5KriahbxOB9QRU pEiopNyUQxnBkjFxYUQ3ljwifg== X-Google-Smtp-Source: ACHHUZ4SRyqTO729hyK62hC9hFKRzE18fGGOcV6TcgxJ3a2XmJT7r504daG1bjU2DgKZOKUDRjIaeA== X-Received: by 2002:ac2:522e:0:b0:4f0:9126:b7e3 with SMTP id i14-20020ac2522e000000b004f09126b7e3mr1910140lfl.26.1683025024258; Tue, 02 May 2023 03:57:04 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id z6-20020ac24186000000b004edc0fc3c35sm5324459lfh.5.2023.05.02.03.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 03:57:03 -0700 (PDT) Message-ID: <3b017384-9039-b558-dc94-7fe1f419f5c3@linaro.org> Date: Tue, 2 May 2023 12:57:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 11/13] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Content-Language: en-US To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-12-bryan.odonoghue@linaro.org> From: Konrad Dybcio In-Reply-To: <20230501121111.1058190-12-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1.05.2023 14:11, Bryan O'Donoghue wrote: > Switch on TCPM for the RB5. Here we declare as a source only not a sink > since qrb5165 doesn't support powering exclusively from the type-c port. > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index b326bdeeb7742..1e0b6fd59abc9 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include "sm8250.dtsi" > #include "pm8150.dtsi" > #include "pm8150b.dtsi" > @@ -1344,3 +1345,19 @@ &pm8150b_vbus { > regulator-max-microamp = <3000000>; > status = "okay"; > }; > + > +&pm8150b_typec { > + status = "okay"; Missing newline Reviewed-by: Konrad Dybcio Konrad > + connector { > + compatible = "usb-c-connector"; > + > + power-role = "source"; > + data-role = "dual"; > + self-powered; > + > + source-pdos = + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_USB_COMM | > + PDO_FIXED_DATA_SWAP)>; > + }; > +};