* [PATCH 1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
@ 2023-03-21 19:01 ` Bhupesh Sharma
2023-03-21 19:29 ` Konrad Dybcio
2023-03-21 19:01 ` [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-21 19:01 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.sharma,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
As per documentation, Qualcomm SDM845 SoC supports BAM DMA
engine v1.7.4, so use the correct compatible strings.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0fdd59a9feed..e8e9aa4da914 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2628,7 +2628,7 @@ ufs_mem_phy_lanes: phy@1d87400 {
};
cryptobam: dma-controller@1dc4000 {
- compatible = "qcom,bam-v1.7.0";
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
reg = <0 0x01dc4000 0 0x24000>;
interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rpmhcc RPMH_CE_CLK>;
--
2.38.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
2023-03-21 19:01 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string Bhupesh Sharma
@ 2023-03-21 19:29 ` Konrad Dybcio
0 siblings, 0 replies; 14+ messages in thread
From: Konrad Dybcio @ 2023-03-21 19:29 UTC (permalink / raw)
To: Bhupesh Sharma, linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.linux,
krzysztof.kozlowski, robh+dt, vladimir.zapolskiy, rfoss
On 21.03.2023 20:01, Bhupesh Sharma wrote:
> As per documentation, Qualcomm SDM845 SoC supports BAM DMA
> engine v1.7.4, so use the correct compatible strings.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0fdd59a9feed..e8e9aa4da914 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2628,7 +2628,7 @@ ufs_mem_phy_lanes: phy@1d87400 {
> };
>
> cryptobam: dma-controller@1dc4000 {
> - compatible = "qcom,bam-v1.7.0";
> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> reg = <0 0x01dc4000 0 0x24000>;
> interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rpmhcc RPMH_CE_CLK>;
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
2023-03-21 19:01 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string Bhupesh Sharma
@ 2023-03-21 19:01 ` Bhupesh Sharma
2023-03-21 20:38 ` Stephan Gerhold
2023-03-21 19:01 ` [PATCH 3/5] arm64: dts: qcom: sm8150: " Bhupesh Sharma
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-21 19:01 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.sharma,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm6115.dtsi'.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index c56738633431..b2d2cdde41fa 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -664,6 +664,32 @@ usb_1_hsphy: phy@1613000 {
status = "disabled";
};
+ cryptobam: dma-controller@1b04000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0x0 0x01b04000 0x0 0x24000>;
+ interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ num-channels = <8>;
+ qcom,num-ees = <2>;
+ iommus = <&apps_smmu 0x84 0x11>,
+ <&apps_smmu 0x86 0x11>,
+ <&apps_smmu 0x94 0x11>,
+ <&apps_smmu 0x96 0x11>;
+ };
+
+ crypto: crypto@1b3a000 {
+ compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0x0 0x01b3a000 0x0 0x6000>;
+ dmas = <&cryptobam 6>, <&cryptobam 7>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x84 0x11>,
+ <&apps_smmu 0x86 0x11>,
+ <&apps_smmu 0x94 0x11>,
+ <&apps_smmu 0x96 0x11>;
+ };
+
qfprom@1b40000 {
compatible = "qcom,sm6115-qfprom", "qcom,qfprom";
reg = <0x0 0x01b40000 0x0 0x7000>;
--
2.38.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support
2023-03-21 19:01 ` [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
@ 2023-03-21 20:38 ` Stephan Gerhold
2023-03-22 10:41 ` Bhupesh Sharma
0 siblings, 1 reply; 14+ messages in thread
From: Stephan Gerhold @ 2023-03-21 20:38 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-arm-msm, agross, linux-kernel, devicetree, andersson,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
On Wed, Mar 22, 2023 at 12:31:15AM +0530, Bhupesh Sharma wrote:
> Add crypto engine (CE) and CE BAM related nodes and definitions to
> 'sm6115.dtsi'.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index c56738633431..b2d2cdde41fa 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -664,6 +664,32 @@ usb_1_hsphy: phy@1613000 {
> status = "disabled";
> };
>
> + cryptobam: dma-controller@1b04000 {
> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> + reg = <0x0 0x01b04000 0x0 0x24000>;
> + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + qcom,ee = <0>;
> + qcom,controlled-remotely;
> + num-channels = <8>;
> + qcom,num-ees = <2>;
> + iommus = <&apps_smmu 0x84 0x11>,
> + <&apps_smmu 0x86 0x11>,
> + <&apps_smmu 0x94 0x11>,
> + <&apps_smmu 0x96 0x11>;
> + };
> +
> + crypto: crypto@1b3a000 {
> + compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce";
> + reg = <0x0 0x01b3a000 0x0 0x6000>;
> + dmas = <&cryptobam 6>, <&cryptobam 7>;
> + dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x84 0x11>,
> + <&apps_smmu 0x86 0x11>,
> + <&apps_smmu 0x94 0x11>,
> + <&apps_smmu 0x96 0x11>;
If you apply the 0x11 mask to the stream ID then the last two items here
are identical to the first two (0x94 & ~0x11 = 0x84). Why are they
needed? They look redundant to me.
Thanks,
Stephan
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support
2023-03-21 20:38 ` Stephan Gerhold
@ 2023-03-22 10:41 ` Bhupesh Sharma
0 siblings, 0 replies; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-22 10:41 UTC (permalink / raw)
To: Stephan Gerhold
Cc: linux-arm-msm, agross, linux-kernel, devicetree, andersson,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
On Wed, 22 Mar 2023 at 02:09, Stephan Gerhold <stephan@gerhold.net> wrote:
>
> On Wed, Mar 22, 2023 at 12:31:15AM +0530, Bhupesh Sharma wrote:
> > Add crypto engine (CE) and CE BAM related nodes and definitions to
> > 'sm6115.dtsi'.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > index c56738633431..b2d2cdde41fa 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > @@ -664,6 +664,32 @@ usb_1_hsphy: phy@1613000 {
> > status = "disabled";
> > };
> >
> > + cryptobam: dma-controller@1b04000 {
> > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> > + reg = <0x0 0x01b04000 0x0 0x24000>;
> > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> > + #dma-cells = <1>;
> > + qcom,ee = <0>;
> > + qcom,controlled-remotely;
> > + num-channels = <8>;
> > + qcom,num-ees = <2>;
> > + iommus = <&apps_smmu 0x84 0x11>,
> > + <&apps_smmu 0x86 0x11>,
> > + <&apps_smmu 0x94 0x11>,
> > + <&apps_smmu 0x96 0x11>;
> > + };
> > +
> > + crypto: crypto@1b3a000 {
> > + compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce";
> > + reg = <0x0 0x01b3a000 0x0 0x6000>;
> > + dmas = <&cryptobam 6>, <&cryptobam 7>;
> > + dma-names = "rx", "tx";
> > + iommus = <&apps_smmu 0x84 0x11>,
> > + <&apps_smmu 0x86 0x11>,
> > + <&apps_smmu 0x94 0x11>,
> > + <&apps_smmu 0x96 0x11>;
>
> If you apply the 0x11 mask to the stream ID then the last two items here
> are identical to the first two (0x94 & ~0x11 = 0x84). Why are they
> needed? They look redundant to me.
Thanks, I will check them out and fix them in v2.
Regards.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/5] arm64: dts: qcom: sm8150: Add Crypto Engine support
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
2023-03-21 19:01 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string Bhupesh Sharma
2023-03-21 19:01 ` [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
@ 2023-03-21 19:01 ` Bhupesh Sharma
2023-03-21 19:01 ` [PATCH 4/5] arm64: dts: qcom: sm8250: " Bhupesh Sharma
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-21 19:01 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.sharma,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm8150.dtsi'.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 662098e85b97..6fb3596d3c01 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -2082,6 +2082,32 @@ ufs_mem_phy_lanes: phy@1d87400 {
};
};
+ cryptobam: dma-controller@1dc4000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0 0x01dc4000 0 0x24000>;
+ interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ iommus = <&apps_smmu 0x504 0x0011>,
+ <&apps_smmu 0x506 0x0011>,
+ <&apps_smmu 0x514 0x0011>,
+ <&apps_smmu 0x516 0x0011>;
+ };
+
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,sm8150-qce", "qcom,qce";
+ reg = <0 0x01dfa000 0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x504 0x0011>,
+ <&apps_smmu 0x506 0x0011>,
+ <&apps_smmu 0x514 0x0011>,
+ <&apps_smmu 0x516 0x0011>;
+ interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+ interconnect-names = "memory";
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0x0 0x01f40000 0x0 0x20000>;
--
2.38.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/5] arm64: dts: qcom: sm8250: Add Crypto Engine support
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
` (2 preceding siblings ...)
2023-03-21 19:01 ` [PATCH 3/5] arm64: dts: qcom: sm8150: " Bhupesh Sharma
@ 2023-03-21 19:01 ` Bhupesh Sharma
2023-03-21 19:01 ` [PATCH 5/5] arm64: dts: qcom: sm8350: " Bhupesh Sharma
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-21 19:01 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.sharma,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm8250.dtsi'.
Co-developed-by and Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 7ccec48255f0..009e992d2d6e 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2223,6 +2223,32 @@ ufs_mem_phy_lanes: phy@1d87400 {
};
};
+ cryptobam: dma-controller@1dc4000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0 0x01dc4000 0 0x24000>;
+ interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ iommus = <&apps_smmu 0x584 0x0011>,
+ <&apps_smmu 0x586 0x0011>,
+ <&apps_smmu 0x594 0x0011>,
+ <&apps_smmu 0x596 0x0011>;
+ };
+
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,sm8250-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0 0x01dfa000 0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x584 0x0011>,
+ <&apps_smmu 0x586 0x0011>,
+ <&apps_smmu 0x594 0x0011>,
+ <&apps_smmu 0x596 0x0011>;
+ interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+ interconnect-names = "memory";
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0x0 0x01f40000 0x0 0x40000>;
--
2.38.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 5/5] arm64: dts: qcom: sm8350: Add Crypto Engine support
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
` (3 preceding siblings ...)
2023-03-21 19:01 ` [PATCH 4/5] arm64: dts: qcom: sm8250: " Bhupesh Sharma
@ 2023-03-21 19:01 ` Bhupesh Sharma
2023-03-21 19:27 ` [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Konrad Dybcio
2023-03-22 14:45 ` (subset) " Bjorn Andersson
6 siblings, 0 replies; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-21 19:01 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.sharma,
bhupesh.linux, krzysztof.kozlowski, robh+dt, konrad.dybcio,
vladimir.zapolskiy, rfoss
Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm8350.dtsi'.
Co-developed-by and Signed-off-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index b2f1ea4b671e..d017a0a11fcb 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1730,6 +1730,32 @@ ufs_mem_phy_lanes: phy@1d87400 {
};
};
+ cryptobam: dma-controller@1dc4000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0 0x01dc4000 0 0x24000>;
+ interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ iommus = <&apps_smmu 0x584 0x0011>,
+ <&apps_smmu 0x586 0x0011>,
+ <&apps_smmu 0x594 0x0011>,
+ <&apps_smmu 0x596 0x0011>;
+ };
+
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,sm8350-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0 0x01dfa000 0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x584 0x0011>,
+ <&apps_smmu 0x586 0x0011>,
+ <&apps_smmu 0x594 0x0011>,
+ <&apps_smmu 0x596 0x0011>;
+ interconnects = <&aggre2_noc MASTER_CRYPTO &mc_virt SLAVE_EBI1>;
+ interconnect-names = "memory";
+ };
+
ipa: ipa@1e40000 {
compatible = "qcom,sm8350-ipa";
--
2.38.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
` (4 preceding siblings ...)
2023-03-21 19:01 ` [PATCH 5/5] arm64: dts: qcom: sm8350: " Bhupesh Sharma
@ 2023-03-21 19:27 ` Konrad Dybcio
2023-03-22 8:33 ` Bhupesh Sharma
2023-03-22 14:45 ` (subset) " Bjorn Andersson
6 siblings, 1 reply; 14+ messages in thread
From: Konrad Dybcio @ 2023-03-21 19:27 UTC (permalink / raw)
To: Bhupesh Sharma, linux-arm-msm
Cc: agross, linux-kernel, devicetree, andersson, bhupesh.linux,
krzysztof.kozlowski, robh+dt, vladimir.zapolskiy, rfoss
On 21.03.2023 20:01, Bhupesh Sharma wrote:
> This patchset enables Crypto Engine support for Qualcomm SoCs like
> SM6115, SM8150, SM8250 and SM8350.
>
> While at it, also fix the compatible string for BAM DMA engine
> used in sdm845.dtsi
>
> Note that:
> - SM8250 crypto engine patch utilizes the work already done by myself and
> Vladimir.
> - SM8350 crypto engine patch utilizes the work already done by Robert.
>
> This patchset depends on the dt-bindings patch which added support for
> SM6115 and QCS2290 SoCs:
> https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/
You could have included that one here for easier tracking!
Konrad
>
> Also this patchset is rebased on linux-next/master.
>
> Bhupesh Sharma (5):
> arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
> arm64: dts: qcom: sm6115: Add Crypto Engine support
> arm64: dts: qcom: sm8150: Add Crypto Engine support
> arm64: dts: qcom: sm8250: Add Crypto Engine support
> arm64: dts: qcom: sm8350: Add Crypto Engine support
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 26 ++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 26 ++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 26 ++++++++++++++++++++++++++
> 5 files changed, 105 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs
2023-03-21 19:27 ` [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Konrad Dybcio
@ 2023-03-22 8:33 ` Bhupesh Sharma
2023-03-22 8:34 ` Konrad Dybcio
2023-03-22 8:35 ` Krzysztof Kozlowski
0 siblings, 2 replies; 14+ messages in thread
From: Bhupesh Sharma @ 2023-03-22 8:33 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, agross, linux-kernel, devicetree, andersson,
bhupesh.linux, krzysztof.kozlowski, robh+dt, vladimir.zapolskiy,
rfoss
On Wed, 22 Mar 2023 at 00:57, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 21.03.2023 20:01, Bhupesh Sharma wrote:
> > This patchset enables Crypto Engine support for Qualcomm SoCs like
> > SM6115, SM8150, SM8250 and SM8350.
> >
> > While at it, also fix the compatible string for BAM DMA engine
> > used in sdm845.dtsi
> >
> > Note that:
> > - SM8250 crypto engine patch utilizes the work already done by myself and
> > Vladimir.
> > - SM8350 crypto engine patch utilizes the work already done by Robert.
> >
> > This patchset depends on the dt-bindings patch which added support for
> > SM6115 and QCS2290 SoCs:
> > https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/
> You could have included that one here for easier tracking!
Err.. the dt-binding maintainers have been asking to split the
dt-binding patches from
the dts ones in the past. So, let's stick to that for now :)
Thanks.
> > Also this patchset is rebased on linux-next/master.
> >
> > Bhupesh Sharma (5):
> > arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
> > arm64: dts: qcom: sm6115: Add Crypto Engine support
> > arm64: dts: qcom: sm8150: Add Crypto Engine support
> > arm64: dts: qcom: sm8250: Add Crypto Engine support
> > arm64: dts: qcom: sm8350: Add Crypto Engine support
> >
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
> > arch/arm64/boot/dts/qcom/sm8150.dtsi | 26 ++++++++++++++++++++++++++
> > arch/arm64/boot/dts/qcom/sm8250.dtsi | 26 ++++++++++++++++++++++++++
> > arch/arm64/boot/dts/qcom/sm8350.dtsi | 26 ++++++++++++++++++++++++++
> > 5 files changed, 105 insertions(+), 1 deletion(-)
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs
2023-03-22 8:33 ` Bhupesh Sharma
@ 2023-03-22 8:34 ` Konrad Dybcio
2023-03-22 8:35 ` Krzysztof Kozlowski
1 sibling, 0 replies; 14+ messages in thread
From: Konrad Dybcio @ 2023-03-22 8:34 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-arm-msm, agross, linux-kernel, devicetree, andersson,
bhupesh.linux, krzysztof.kozlowski, robh+dt, vladimir.zapolskiy,
rfoss
On 22.03.2023 09:33, Bhupesh Sharma wrote:
> On Wed, 22 Mar 2023 at 00:57, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 21.03.2023 20:01, Bhupesh Sharma wrote:
>>> This patchset enables Crypto Engine support for Qualcomm SoCs like
>>> SM6115, SM8150, SM8250 and SM8350.
>>>
>>> While at it, also fix the compatible string for BAM DMA engine
>>> used in sdm845.dtsi
>>>
>>> Note that:
>>> - SM8250 crypto engine patch utilizes the work already done by myself and
>>> Vladimir.
>>> - SM8350 crypto engine patch utilizes the work already done by Robert.
>>>
>>> This patchset depends on the dt-bindings patch which added support for
>>> SM6115 and QCS2290 SoCs:
>>> https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/
>> You could have included that one here for easier tracking!
>
> Err.. the dt-binding maintainers have been asking to split the
> dt-binding patches from
> the dts ones in the past.
Quite the opposite!
So, let's stick to that for now :)
Konrad
>
> Thanks.
>
>>> Also this patchset is rebased on linux-next/master.
>>>
>>> Bhupesh Sharma (5):
>>> arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
>>> arm64: dts: qcom: sm6115: Add Crypto Engine support
>>> arm64: dts: qcom: sm8150: Add Crypto Engine support
>>> arm64: dts: qcom: sm8250: Add Crypto Engine support
>>> arm64: dts: qcom: sm8350: Add Crypto Engine support
>>>
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
>>> arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++
>>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 26 ++++++++++++++++++++++++++
>>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 26 ++++++++++++++++++++++++++
>>> arch/arm64/boot/dts/qcom/sm8350.dtsi | 26 ++++++++++++++++++++++++++
>>> 5 files changed, 105 insertions(+), 1 deletion(-)
>>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs
2023-03-22 8:33 ` Bhupesh Sharma
2023-03-22 8:34 ` Konrad Dybcio
@ 2023-03-22 8:35 ` Krzysztof Kozlowski
1 sibling, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-22 8:35 UTC (permalink / raw)
To: Bhupesh Sharma, Konrad Dybcio
Cc: linux-arm-msm, agross, linux-kernel, devicetree, andersson,
bhupesh.linux, robh+dt, vladimir.zapolskiy, rfoss
On 22/03/2023 09:33, Bhupesh Sharma wrote:
> On Wed, 22 Mar 2023 at 00:57, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 21.03.2023 20:01, Bhupesh Sharma wrote:
>>> This patchset enables Crypto Engine support for Qualcomm SoCs like
>>> SM6115, SM8150, SM8250 and SM8350.
>>>
>>> While at it, also fix the compatible string for BAM DMA engine
>>> used in sdm845.dtsi
>>>
>>> Note that:
>>> - SM8250 crypto engine patch utilizes the work already done by myself and
>>> Vladimir.
>>> - SM8350 crypto engine patch utilizes the work already done by Robert.
>>>
>>> This patchset depends on the dt-bindings patch which added support for
>>> SM6115 and QCS2290 SoCs:
>>> https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/
>> You could have included that one here for easier tracking!
>
> Err.. the dt-binding maintainers have been asking to split the
> dt-binding patches from
> the dts ones in the past. So, let's stick to that for now :)
For submissions? No, we did not.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: (subset) [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs
2023-03-21 19:01 [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
` (5 preceding siblings ...)
2023-03-21 19:27 ` [PATCH 0/5] arm64: dts: qcom: Enable Crypto Engine for a few Qualcomm SoCs Konrad Dybcio
@ 2023-03-22 14:45 ` Bjorn Andersson
6 siblings, 0 replies; 14+ messages in thread
From: Bjorn Andersson @ 2023-03-22 14:45 UTC (permalink / raw)
To: linux-arm-msm, Bhupesh Sharma
Cc: vladimir.zapolskiy, konrad.dybcio, agross, rfoss, bhupesh.linux,
devicetree, linux-kernel, robh+dt, krzysztof.kozlowski
On Wed, 22 Mar 2023 00:31:13 +0530, Bhupesh Sharma wrote:
> This patchset enables Crypto Engine support for Qualcomm SoCs like
> SM6115, SM8150, SM8250 and SM8350.
>
> While at it, also fix the compatible string for BAM DMA engine
> used in sdm845.dtsi
>
> Note that:
> - SM8250 crypto engine patch utilizes the work already done by myself and
> Vladimir.
> - SM8350 crypto engine patch utilizes the work already done by Robert.
>
> [...]
Applied, thanks!
[1/5] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string
commit: b767d1b40cbca49452d712ca0f4f053dacfc5c45
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread