Re: [PATCH v2 1/2] dt: bindings: net: add bindings to add WoW support for WCN6750

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 29/08/2022 15:43, Manikanta Pubbisetty wrote:
> Add required bindings to support WoW (Wake on Wireless) for
> WCN6750 which is based on ath11k driver.
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>

Use scripts/get_maintainers.pl to CC all maintainers and relevant
mailing lists.

> ---
>  .../bindings/net/wireless/qcom,ath11k.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a677b056f112..307a5b9d1588 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -66,6 +66,14 @@ properties:
>      required:
>        - iommus
>  
> +  qcom,smem-states:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: State bits used in WCN6750 to signal the firmware
> +                 to exit from WoW.

You need to describe the item (s).

> +
> +  qcom,smem-state-names:
> +    description: The names of the state bits used for SMP2P output

You need to describe the item (s).

> +
>  required:
>    - compatible
>    - reg
> @@ -410,6 +418,13 @@ examples:
>          };
>      };
>  
> +    smp2p-wpss {
> +        wlan_smp2p_out: wlan_smp2p_out {

No underscores in node names. This example is incomplete and I am not
sure what is the benefit of adding provider example to the consumer
binding... Just skip it.

Best regards,
Best regards,
Krzysztof