From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 375502DC777; Tue, 14 Oct 2025 08:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760429851; cv=none; b=kLcUDh8kHIHYdnO0fdsjC834LQvVq/eqcVgN5PkkTeoBWZofzVkMMeNcfjRSZnHgV3Mhi6CQkb7bjgcJJXUTMxLnHBgUaGnPHrqOqlCUU+oBpvFkQ11Qcjzpve7IsxZJ5BdX7Vz5V2n5Hj3Xbve2c+H9UzIxlykB2pCdJM5yIfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760429851; c=relaxed/simple; bh=kYSJbdpApVHKl5lbFF9uXk0Y7li8c3YVSGSITvk5GXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RpLSP79byih8ZgHw6qIWMt7yEhUYfpEsKuBSbYeHRToJ041cD2UlmyTBmQukg/kHUar2DeVM6u0g+bi4okAVfyLrfJSGJh5vmCrR0Z4ZYwvLqIa5injZ+RD7tpMibkmAS5BYDLEF0MlpUjKoYmnFyviApUqnkgYxb9s8X9IM344= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dLdJKlx9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dLdJKlx9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A69E9C4CEE7; Tue, 14 Oct 2025 08:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760429850; bh=kYSJbdpApVHKl5lbFF9uXk0Y7li8c3YVSGSITvk5GXY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dLdJKlx9o8qtsGAryUv1KGIfVMFdFAhIQYXCsrspMHLJXaSaboZ11+8WqCXIIfuPx vktvrGaZ+Yjzk+2EnGJ0ZvuQQBLHvdoUG6TpuGKey5oi66QXP1zZSL+MChtiyhwSY9 qERtw/7ysvmvvpG7vQAyA7BptHGRj8zGnEPGAMHO9qHQOcfC2TWSoaZC3DXNhnUJrQ GIxCGQTriOq0wDmS8RbaXlrE7vHPap9octFA/xD6di4BJwqZm2T1TsBecDETZQSoOc c2KKWAZF48YSwFyvRtxekN1wOWDX8VeKDo03LToaKGiSqmgiFvUqScMgHDt4kvNfnu RR2p8E4FEZkTw== Message-ID: <3b220b8b-06b4-4738-8818-6fb4b85e89a8@kernel.org> Date: Tue, 14 Oct 2025 10:17:25 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] regulator: max77675: Add MAX77675 regulator driver To: Joan-Na-adi , Liam Girdwood Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Joan Na References: <20251014053142.15835-1-joan.na@analog.com> <20251014053142.15835-3-joan.na@analog.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251014053142.15835-3-joan.na@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/10/2025 07:31, Joan-Na-adi wrote: > From: Joan Na > > This patch adds support for the Maxim Integrated MAX77675 PMIC regulator. Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94 ... > + config.dev = &client->dev; > + config.regmap = maxreg->regmap; > + config.driver_data = maxreg; > + > + regulators_np = of_get_child_by_name(client->dev.of_node, "regulators"); Where do you drop this reference? > + if (!regulators_np) { > + dev_err(maxreg->dev, "No 'regulators' subnode found in DT\n"); > + return -EINVAL; > + } > + > + for (i = 0; i < MAX77675_ID_NUM_MAX; i++) { > + const struct regulator_desc *desc = &max77675_regulators[i]; > + struct regulator_dev *rdev; > + struct device_node *child_np; > + > + child_np = of_get_child_by_name(regulators_np, desc->name); > + if (!child_np) { > + dev_warn(maxreg->dev, "No DT node for regulator %s\n", desc->name); > + continue; > + } > + > + config.of_node = child_np; > + > + rdev = devm_regulator_register(&client->dev, desc, &config); Can't you drop child_np reference here? > + if (IS_ERR(rdev)) { > + ret = PTR_ERR(rdev); > + dev_err(maxreg->dev, > + "Failed to register regulator %d (%s): %d\n", > + i, desc->name, ret); > + of_node_put(child_np); > + return ret; return dev_err_probe > + } > + of_node_put(child_np); > + } > + > + i2c_set_clientdata(client, maxreg); > + > + return 0; > +} > + > +static void max77675_regulator_remove(struct i2c_client *client) > +{ > + /* Nothing to clean up currently */ So drop it, do not add dead code. > +} > + > +static const struct i2c_device_id max77675_i2c_id[] = { > + { "max77675", 0 }, > + { } Best regards, Krzysztof