* [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
2025-12-03 14:48 [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Krishna Kurapati
@ 2025-12-03 14:48 ` Krishna Kurapati
2025-12-03 15:07 ` Krzysztof Kozlowski
2025-12-03 14:48 ` [PATCH 2/2] arm64: dts: qcom: sm8650: " Krishna Kurapati
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Krishna Kurapati @ 2025-12-03 14:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Neil Armstrong
Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati
With W=1, the following error comes up:
Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
This is because the child node being removed during flattening and moving
to latest bindings.
Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 2ca9e50ef599..e3f93f4f412d 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -4133,8 +4133,6 @@ usb_dp_qmpphy_dp_in: endpoint {
usb_1: usb@a600000 {
compatible = "qcom,sm8550-dwc3", "qcom,snps-dwc3";
reg = <0x0 0x0a600000 0x0 0xfc100>;
- #address-cells = <1>;
- #size-cells = <0>;
clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
<&gcc GCC_USB30_PRIM_MASTER_CLK>,
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
2025-12-03 14:48 ` [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node Krishna Kurapati
@ 2025-12-03 15:07 ` Krzysztof Kozlowski
2025-12-08 8:26 ` Neil Armstrong
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-03 15:07 UTC (permalink / raw)
To: Krishna Kurapati, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Neil Armstrong
Cc: linux-arm-msm, devicetree, linux-kernel
On 03/12/2025 15:48, Krishna Kurapati wrote:
> With W=1, the following error comes up:
>
> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> This is because the child node being removed during flattening and moving
> to latest bindings.
>
> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
I don't fully understand that original commit - it explicitly changed
address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
kind of intentional. Anyway, these should not be needed, so:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
2025-12-03 15:07 ` Krzysztof Kozlowski
@ 2025-12-08 8:26 ` Neil Armstrong
0 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2025-12-08 8:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krishna Kurapati, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On 12/3/25 16:07, Krzysztof Kozlowski wrote:
> On 03/12/2025 15:48, Krishna Kurapati wrote:
>> With W=1, the following error comes up:
>>
>> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>>
>> This is because the child node being removed during flattening and moving
>> to latest bindings.
>>
>> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
>
>
> I don't fully understand that original commit - it explicitly changed
> address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
> kind of intentional. Anyway, these should not be needed, so:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
They were kept to allow adding usb submodes representing usb devices,
as the bindings allows. It's not _needed_ until we add some subnodes.
Neil
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
2025-12-03 14:48 [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Krishna Kurapati
2025-12-03 14:48 ` [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node Krishna Kurapati
@ 2025-12-03 14:48 ` Krishna Kurapati
2025-12-03 15:07 ` Krzysztof Kozlowski
2025-12-06 4:01 ` [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Dmitry Baryshkov
2025-12-06 4:06 ` Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Krishna Kurapati @ 2025-12-03 14:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Neil Armstrong
Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati
With W=1, the following error comes up:
Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
This is because the child node being removed during flattening and moving
to latest bindings.
Fixes: 77e1f16b9302 ("arm64: dts: qcom: sm8650: Flatten the USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 07ae74851621..f8e1950a74ac 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -5150,9 +5150,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
dma-coherent;
- #address-cells = <1>;
- #size-cells = <0>;
-
status = "disabled";
ports {
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
2025-12-03 14:48 ` [PATCH 2/2] arm64: dts: qcom: sm8650: " Krishna Kurapati
@ 2025-12-03 15:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-03 15:07 UTC (permalink / raw)
To: Krishna Kurapati, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Neil Armstrong
Cc: linux-arm-msm, devicetree, linux-kernel
On 03/12/2025 15:48, Krishna Kurapati wrote:
> With W=1, the following error comes up:
>
> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> This is because the child node being removed during flattening and moving
> to latest bindings.
>
> Fixes: 77e1f16b9302 ("arm64: dts: qcom: sm8650: Flatten the USB nodes")
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] Fix compile warnings for SM8550 and SM8650
2025-12-03 14:48 [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Krishna Kurapati
2025-12-03 14:48 ` [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node Krishna Kurapati
2025-12-03 14:48 ` [PATCH 2/2] arm64: dts: qcom: sm8650: " Krishna Kurapati
@ 2025-12-06 4:01 ` Dmitry Baryshkov
2025-12-06 4:06 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2025-12-06 4:01 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Neil Armstrong, linux-arm-msm, devicetree,
linux-kernel
On Wed, Dec 03, 2025 at 08:18:54PM +0530, Krishna Kurapati wrote:
> arch/arm64/boot/dts/qcom/sm8550.dtsi:4133.22-4223.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> arch/arm64/boot/dts/qcom/sm8650.dtsi:5086.22-5177.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> Fix them up accordingly.
>
> This series has only been compile tested.
>
> Krishna Kurapati (2):
> arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
> arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] Fix compile warnings for SM8550 and SM8650
2025-12-03 14:48 [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Krishna Kurapati
` (2 preceding siblings ...)
2025-12-06 4:01 ` [PATCH 0/2] Fix compile warnings for SM8550 and SM8650 Dmitry Baryshkov
@ 2025-12-06 4:06 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2025-12-06 4:06 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
Neil Armstrong, Krishna Kurapati
Cc: linux-arm-msm, devicetree, linux-kernel
On Wed, 03 Dec 2025 20:18:54 +0530, Krishna Kurapati wrote:
> arch/arm64/boot/dts/qcom/sm8550.dtsi:4133.22-4223.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> arch/arm64/boot/dts/qcom/sm8650.dtsi:5086.22-5177.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> Fix them up accordingly.
>
> This series has only been compile tested.
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
commit: 2d0165726d20395cb700546b1528df3fa614e5a3
[2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
commit: 825db404fbed0580deb19f587d69b9f75980055a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread