Re: [PATCH] iio: light: ltrf216a: Drop undocumented ltr,ltrf216a compatible string

["Shreeya Patel" <shreeya.patel@collabora.com>]

On Friday, July 05, 2024 15:20 IST, Marek Vasut <marex@denx.de> wrote:

> The "ltr,ltrf216a" compatible string is not documented in DT binding
> document, remove it.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Shreeya Patel <shreeya.patel@collabora.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-iio@vger.kernel.org
> ---
>  drivers/iio/light/ltrf216a.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
> index 68dc48420a886..78fc910fcb18c 100644
> --- a/drivers/iio/light/ltrf216a.c
> +++ b/drivers/iio/light/ltrf216a.c
> @@ -528,7 +528,6 @@ MODULE_DEVICE_TABLE(i2c, ltrf216a_id);
>  
>  static const struct of_device_id ltrf216a_of_match[] = {
>  	{ .compatible = "liteon,ltrf216a" },
> -	{ .compatible = "ltr,ltrf216a" },
>  	{}

This compatible string with a different vendor prefix was added for a specific reason.
Please see the commit message of the following patch :-
https://lore.kernel.org/all/20220511094024.175994-2-shreeya.patel@collabora.com/

We were very well aware that not documenting this was going to generate a warning so
we tried to fix that with a deprecated tag but it was NAKd by Rob. What we understood
from his last message was that it wasn't necessary to fix the DT warning.

Thanks,
Shreeya Patel

>  };
>  MODULE_DEVICE_TABLE(of, ltrf216a_of_match);
> -- 
> 2.43.0
>