From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kapatrala Syed <akapatra@quicinc.com>,
Hariram Purushothaman <hariramp@quicinc.com>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Hariram Purushothaman <quic_hariramp@quicinc.com>,
Trishansh Bhardwaj <quic_tbhardwa@quicinc.com>
Subject: Re: [PATCH 3/6] arm64: dts: qcom: sc7280: Add IMX577 camera sensor
Date: Mon, 1 Jul 2024 10:59:29 +0200 [thread overview]
Message-ID: <3b2d67d1-e27b-49f9-9332-19e44e5f111a@kernel.org> (raw)
In-Reply-To: <20240629-camss_first_post_linux_next-v1-3-bc798edabc3a@quicinc.com>
On 28/06/2024 20:32, Vikram Sharma wrote:
> Add support for IMX577 camera sensor for SC7280 SoC.
>
> Signed-off-by: Hariram Purushothaman <quic_hariramp@quicinc.com>
> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 9ac251fec262..1c99ee09a11a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -5167,6 +5167,39 @@ cci3_sleep: cci3-sleep-state {
> bias-pull-down;
> };
>
> + cam2_default: cam2-default {
There are tools. Use them, instead of us. Read you internal guideline -
it asks you to do that.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-01 8:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 18:32 [PATCH 0/6] media: qcom: camss: Add sc7280 support Vikram Sharma
2024-06-28 18:32 ` [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding Vikram Sharma
2024-06-29 10:57 ` Bryan O'Donoghue
2024-07-01 8:58 ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 2/6] arm64: dts: qcom: sc7280: Add support for camss Vikram Sharma
2024-06-29 11:53 ` Bryan O'Donoghue
2024-06-28 18:32 ` [PATCH 3/6] arm64: dts: qcom: sc7280: Add IMX577 camera sensor Vikram Sharma
2024-06-29 11:07 ` Bryan O'Donoghue
2024-06-29 13:10 ` Konrad Dybcio
2024-07-01 8:59 ` Krzysztof Kozlowski [this message]
2024-07-01 18:38 ` Dmitry Baryshkov
2024-06-28 18:32 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable " Vikram Sharma
2024-06-29 11:22 ` Bryan O'Donoghue
2024-07-01 9:00 ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 5/6] i2c: Enable IMX577 camera sensor for qcm6490 Vikram Sharma
2024-06-29 8:22 ` Luca Weiss
2024-07-01 9:01 ` Krzysztof Kozlowski
2024-07-01 9:01 ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 6/6] media: qcom: camss: support for camss driver for sc7280 Vikram Sharma
2024-06-29 11:45 ` Bryan O'Donoghue
2024-07-01 19:22 ` Marion & Christophe JAILLET
2024-07-04 15:01 ` [PATCH 0/6] media: qcom: camss: Add sc7280 support Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b2d67d1-e27b-49f9-9332-19e44e5f111a@kernel.org \
--to=krzk@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=quic_hariramp@quicinc.com \
--cc=quic_tbhardwa@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).