From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234C0C38147 for ; Wed, 18 Jan 2023 13:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjARNyI (ORCPT ); Wed, 18 Jan 2023 08:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbjARNxb (ORCPT ); Wed, 18 Jan 2023 08:53:31 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15BFD792AF for ; Wed, 18 Jan 2023 05:24:22 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id m21so49574174edc.3 for ; Wed, 18 Jan 2023 05:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FgU9OV81VKNoacRkVG36DRzxhv8CRha3b241eiVTJOU=; b=y943B9lru//EWuO6UMJJ3vYBFc9kuFRe8EjbWug/kitczTxrPpjydtYgnSU571IYWv +10nJmvwC2S1qdxe0a7VIXrt7bzL9NvjoXV3JZYw+VkaPwnRR1TUxM3E6e+NsfiW1b7H aSPjBKope0li8mNKoIOPXNqgXp1EkC6e6zkTjFI8vGKtu3kjWGTgXPlmjIoeGg+w9kOj /rpQ6HH9TgFbHoKWCZn7HixvsioMN/DPvLsVrdK7Em/ga84IAYxB0pY2SovhaM0RId41 w7ZXC1UNMetFeJ8uLvCAahBmOMWXZGN0r5d1Gq0wo466bNPl+MfUBjrXacklZzeRvb5i PMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FgU9OV81VKNoacRkVG36DRzxhv8CRha3b241eiVTJOU=; b=IocDza4FVyuW5cirAVvE+oZYLuQ+sejwNgFAWVNuKwyOqhs9+6lbpbrNhn/y56KZM+ u7g/4vQd94P7e7tpB/AaxhVEH7afKGhTwCX39zp9c78CIIgrUrhmuyICV47bMnqsHlXQ e70SLxiw2Pv/4lLdUwjG4xB2MBAhrsm8aIhxC+chlytEFQ1Cf98bGKTE5hOe78lMzZz4 V0AWTraS4GM2UIs9kffA9judle0Pt8/CxI9A2qyfVYVABjoQCROP0dhc9ZnrEHznPfyi iuIVeVVlzFNaJDE+E5j+AXtEwEdagr2S/JLSQwdoX2UA68od0XR8nSdimoiQa2TEZ4/s SFtA== X-Gm-Message-State: AFqh2krp5g4hydAIouVcn7JJRf2n2TuwpKm0FU8nRJJIVhkOqiZVTMId lyulmmSCOsbuN9+9FxIOY7KTjRvuQ3pZU+5q X-Google-Smtp-Source: AMrXdXsp1+bb0awcdMhn3BnuUs3hIK4/cegYEOwsfNWiIBA5PynRHZ2PN+kb9S7rYz2DsxQSTLEm2g== X-Received: by 2002:aa7:c1ce:0:b0:49e:89e:3b36 with SMTP id d14-20020aa7c1ce000000b0049e089e3b36mr7350531edp.30.1674048261163; Wed, 18 Jan 2023 05:24:21 -0800 (PST) Received: from [192.168.1.101] (abxh252.neoplus.adsl.tpnet.pl. [83.9.1.252]) by smtp.gmail.com with ESMTPSA id q24-20020a056402249800b0046ac460da13sm14286777eda.53.2023.01.18.05.24.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 05:24:20 -0800 (PST) Message-ID: <3b3709ce-c1ea-155f-f175-c07a3765836d@linaro.org> Date: Wed, 18 Jan 2023 14:24:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] arm64: dts: qcom: sc8280xp: Define CMA region for CRD and X13s Content-Language: en-US To: Bjorn Andersson , Andy Gross , Bjorn Andersson Cc: Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Manivannan Sadhasivam References: <20230117184630.2775905-1-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230117184630.2775905-1-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17.01.2023 19:46, Bjorn Andersson wrote: > While booting the CRD, a series of CMA allocation errors can be seen in > the kernel log: > > cma: cma_alloc: reserved: alloc failed, req-size: 128 pages, ret: -12 > > Growing the CMA region and querying /proc/meminfo indicates that a newly > booted system (currently) uses 64MB CMA. > > Define a memory region sufficiently large for the current use cases, to > avoid forcing users to add this themselves, through command line > parameters etc. > > While fixing the CRD define the same region for the X13s. > > Tested-by: Andrew Halaney # sc8280xp-lenovo-thinkpad-x13s > Reviewed-by: Manivannan Sadhasivam > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > - Updated commit message > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 9 +++++++++ > .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 9 +++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index 4e92dc28e2ce..6f686377dc3e 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -128,6 +128,15 @@ vreg_wwan: regulator-wwan { > > regulator-boot-on; > }; > + > + reserved-memory { > + linux,cma { > + compatible = "shared-dma-pool"; > + size = <0x0 0x8000000>; > + reusable; > + linux,cma-default; > + }; > + }; > }; > > &apps_rsc { > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 55ecbee19a58..8d485e0000cf 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -153,6 +153,15 @@ vreg_wwan: regulator-wwan { > regulator-boot-on; > }; > > + reserved-memory { > + linux,cma { > + compatible = "shared-dma-pool"; > + size = <0x0 0x8000000>; > + reusable; > + linux,cma-default; > + }; > + }; > + > thermal-zones { > skin-temp-thermal { > polling-delay-passive = <250>;