From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Rau <David.Rau.opensource@dm.renesas.com>, broonie@kernel.org
Cc: support.opensource@diasemi.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection
Date: Fri, 12 May 2023 18:18:23 +0200 [thread overview]
Message-ID: <3b382277-e992-39a0-a4ba-c3fd88bfc41e@linaro.org> (raw)
In-Reply-To: <20230512081030.5138-1-David.Rau.opensource@dm.renesas.com>
On 12/05/2023 10:10, David Rau wrote:
> DA7219 can support 2 kinds of insertion detection polarity
> - Default polarity (Low)
> - Inverted polarity (High)
>
> This patch adds support for selecting insertion detection
> polarity to the DT binding.
>
> Signed-off-by: David Rau <David.Rau.opensource@dm.renesas.com>
> ---
> .../devicetree/bindings/sound/da7219.txt | 3 ++
Bindings are always separate patches.
Consider also converting them to DT schema first.
> include/sound/da7219-aad.h | 6 ++++
> sound/soc/codecs/da7219-aad.c | 34 +++++++++++++++++++
> 3 files changed, 43 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/da7219.txt b/Documentation/devicetree/bindings/sound/da7219.txt
> index add1caf26ac2..357d1f61de1d 100644
> --- a/Documentation/devicetree/bindings/sound/da7219.txt
> +++ b/Documentation/devicetree/bindings/sound/da7219.txt
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-12 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 8:10 [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection David Rau
2023-05-12 16:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b382277-e992-39a0-a4ba-c3fd88bfc41e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=David.Rau.opensource@dm.renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).