From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB24C77B7C for ; Fri, 12 May 2023 16:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231449AbjELQSh (ORCPT ); Fri, 12 May 2023 12:18:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjELQSf (ORCPT ); Fri, 12 May 2023 12:18:35 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A41B255AC for ; Fri, 12 May 2023 09:18:27 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-96598a7c5e0so1638181666b.3 for ; Fri, 12 May 2023 09:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683908306; x=1686500306; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qrz9w0tFb2bEDTavGbd5fDgs1thiabqypf9MHkMZM7E=; b=az2gzunWnoFGTedzrfM2TIbgTMGezLZi0Pxftg0z4G7WBcjClypX1MFYbz8i8Ffkpy rIPd+p9IvKeMHmW8j0rdOgWCBsgeKRSnUSDfyt1Vi+6WnmNExmMvNKsjWXnRovJQXfKW 448lS9q5BRTaRG5axAPCUHKPpTDMtBNaadOB56e9URD71wbzPywTpB6wAAkG89cJmDrs BGIDgPXrsRgwWJ5tFqT1Ijehw1cql0A+ytkZnF6yCl/IyGvkD3S5HckHcMHX66OWzRz3 zXAksm8dqrKTDHLbPan7w3A5gRaD13FQcWspRlIoW4Nysu8LdJMknrr3IeNo+/koT/M1 jpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683908306; x=1686500306; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrz9w0tFb2bEDTavGbd5fDgs1thiabqypf9MHkMZM7E=; b=Jf149WQxCPbi9HmQq38MbZ0HQw8uKOpe1KVVfUwg+AhqqxDGOM3+aNQgZtt7YvRVy8 skFJaJuHvkBJHokdrobQyxaX8b8WzCWWBM4mElMYK1dxC1Vv8j6e02JnHMuhW40Mp2gH JHYnvBbYASantSde2WWhvw5qBTTDgyUvXWFf8xGtAXPY7ymNWpKi9OEjqsnLTzo8MYBM zvBUaiiKuQtAHBcze3SOsRpxzVISTIcdNrE5vpOcENVzS2kqYty05RVLRbfR0Amb+VLc MFicH7hR5s/A5imkWus77ctGx2g9ftPShMMpGVed15hfw4tvM2oZEuIvBImFsCHE5Mdn /t1A== X-Gm-Message-State: AC+VfDwLegJ8eL4M9vo9JBO6zQvWw/nNNLutK3uavTuR378YrZHH9Tuy NUkuwU4tB58jooe/0EWg0Ugvtg== X-Google-Smtp-Source: ACHHUZ503Yw3/dALYytrKZ2MlhWOUd6bkVlyqT/PlDFv2HMBJY003CZ/7QJHED8qAmAK9YRj0Ft2Mw== X-Received: by 2002:a17:907:6e12:b0:96a:78ee:7e27 with SMTP id sd18-20020a1709076e1200b0096a78ee7e27mr5822051ejc.59.1683908306071; Fri, 12 May 2023 09:18:26 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7ede:fc7b:2328:3883? ([2a02:810d:15c0:828:7ede:fc7b:2328:3883]) by smtp.gmail.com with ESMTPSA id ci18-20020a170907267200b00959c6cb82basm5544589ejc.105.2023.05.12.09.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 09:18:24 -0700 (PDT) Message-ID: <3b382277-e992-39a0-a4ba-c3fd88bfc41e@linaro.org> Date: Fri, 12 May 2023 18:18:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection Content-Language: en-US To: David Rau , broonie@kernel.org Cc: support.opensource@diasemi.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20230512081030.5138-1-David.Rau.opensource@dm.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20230512081030.5138-1-David.Rau.opensource@dm.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2023 10:10, David Rau wrote: > DA7219 can support 2 kinds of insertion detection polarity > - Default polarity (Low) > - Inverted polarity (High) > > This patch adds support for selecting insertion detection > polarity to the DT binding. > > Signed-off-by: David Rau > --- > .../devicetree/bindings/sound/da7219.txt | 3 ++ Bindings are always separate patches. Consider also converting them to DT schema first. > include/sound/da7219-aad.h | 6 ++++ > sound/soc/codecs/da7219-aad.c | 34 +++++++++++++++++++ > 3 files changed, 43 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/da7219.txt b/Documentation/devicetree/bindings/sound/da7219.txt > index add1caf26ac2..357d1f61de1d 100644 > --- a/Documentation/devicetree/bindings/sound/da7219.txt > +++ b/Documentation/devicetree/bindings/sound/da7219.txt Best regards, Krzysztof