From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60399C77B6C for ; Mon, 3 Apr 2023 16:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbjDCQS0 (ORCPT ); Mon, 3 Apr 2023 12:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232654AbjDCQSY (ORCPT ); Mon, 3 Apr 2023 12:18:24 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55CF310E4 for ; Mon, 3 Apr 2023 09:18:20 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id h11so31819459lfu.8 for ; Mon, 03 Apr 2023 09:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680538698; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+mXE+LsKS7w58ofo+TThv1QNk3ptIYcwRlDn4y/JXOw=; b=Ab2s2zc6kt+PUJGEdq78Ow/02BEc/9oD9n2Xl7cIqVo7a1xrDEwrCt67kiZYk97GsC F+/Y0juFg0xv0FMkANyGrYwv5v/UuA49IyqNwWAgn2LvqtNpRst1REMOmNsw7l0V9e2n pGSTiC+7OMRkRksOL4vyuNQHFc4BgTPGFfJKm9AsPtao/aoUhIb4/0Wo21o47wvI+Npt QySnsfTAsMd0X0Mx86OZfuccSzsDvg0/6Jnb5QDXzc3Bp0G7DAJUUQ8Sy4l2aZ6hGG8I sfeCzoa+rl8VkSrdRVRSidBvKKBnGfchDe5DK3hmgOsuORkD52v+pJvT7tIcSfltzrnn pzKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680538698; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+mXE+LsKS7w58ofo+TThv1QNk3ptIYcwRlDn4y/JXOw=; b=gcBZVWn7rOFI0ksCel+OL4hsD5zuvKxnx9wwP+0D0KCgjD5almMKAve+vN2jEcKYOb UMElSgxsFRLTc6T07lNVX0mbjurT9u7w+239qiJWFpFfUeL+6bgIEZPM/FF3jo2RSaZN BKthmHytnkWkKWqERqV/f5aD5s68HYwDTElHd8Tfjo8wN4Em4nF93WM+4m68l3tECSYn Wm24zSej+VuInnRckHBAd90GWbeJ31d30HXcGya8bNvsB/m736+Fk840DVebVPDlAKX4 SqVb3KPrgWBWCcfVRmkhG7Anm3+lpSDi8R8mwdzdQGatAUpsvwRQRT87gcMf9mp44hde dKWg== X-Gm-Message-State: AAQBX9eXDq9E5CFTODjM6DbO9KLkRYFVIS1Kneei2P5bbcxX5weHSrez mwFHntg/gah8rCtyqO0jOonDjQ== X-Google-Smtp-Source: AKy350bvNo7tfrCyjtYJUYqPuZYVN4n4KKpm6N6lDY1dyQfZedAAVlr9435poDXIfEBaCxiLIx6OhA== X-Received: by 2002:a05:6512:951:b0:4e9:609f:256d with SMTP id u17-20020a056512095100b004e9609f256dmr9317327lft.13.1680538698581; Mon, 03 Apr 2023 09:18:18 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id u23-20020ac24c37000000b004d291dcee7fsm1842094lfq.55.2023.04.03.09.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 09:18:18 -0700 (PDT) Message-ID: <3b41077b-3482-db89-de31-c41cf6429216@linaro.org> Date: Mon, 3 Apr 2023 19:18:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode Content-Language: en-GB From: Dmitry Baryshkov To: Vinod Polimera Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, quic_bjorande@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com References: <1680271114-1534-1-git-send-email-quic_vpolimer@quicinc.com> <1680271114-1534-2-git-send-email-quic_vpolimer@quicinc.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2023 17:45, Dmitry Baryshkov wrote: > On Fri, 31 Mar 2023 at 16:59, Vinod Polimera wrote: >> >> While in virtual terminal mode with PSR enabled, there will be >> no atomic commits triggered without dirty_fb being set. This >> will create a notion of no screen update. Allow atomic commit >> when dirty_fb ioctl is issued, so that it can trigger a PSR exit >> and shows update on the screen. > > Will this impact non-VT workloads? If I remember correctly, we added > dirty_fb handling to prevent the framework from limiting the page > flips to vblank events (in DSI video mode). Actually, this is kind of stupid. If we care about the workload of this pipe, then it is being updated, which means it is not in SR mode, self_refresh_active = false. Reviewed-by: Dmitry Baryshkov > >> >> Reported-by: Bjorn Andersson >> Link: https://lore.kernel.org/all/20230326162723.3lo6pnsfdwzsvbhj@ripper/ >> Signed-off-by: Vinod Polimera >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c >> index ab636da..96f645e 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c >> @@ -1158,6 +1158,9 @@ static bool dpu_crtc_needs_dirtyfb(struct drm_crtc_state *cstate) >> struct drm_crtc *crtc = cstate->crtc; >> struct drm_encoder *encoder; >> >> + if (cstate->self_refresh_active) >> + return true; >> + >> drm_for_each_encoder_mask (encoder, crtc->dev, cstate->encoder_mask) { >> if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) { >> return true; >> -- >> 2.7.4 >> > > -- With best wishes Dmitry