From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerry.Ray@microchip.com, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next][PATCH v4] dt-bindings: dsa: Add lan9303 yaml
Date: Tue, 18 Oct 2022 18:34:34 -0400 [thread overview]
Message-ID: <3b446b01-cf9c-a185-bbad-a77b7d73c5d2@linaro.org> (raw)
In-Reply-To: <MWHPR11MB1693223A91222AEAAA3FC69FEF299@MWHPR11MB1693.namprd11.prod.outlook.com>
On 17/10/2022 14:33, Jerry.Ray@microchip.com wrote:
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + reset-gpios:
>>> + description: Optional reset line
>>> + maxItems: 1
>>> +
>>> + reset-duration:
>>> + description: Reset duration in milliseconds
>>> + default: 200
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>
> I am documenting "what is" rather than what I think it should be. I
> would prefer there be a "-ms" suffix on the name, but that was not
> what was in the pre-existing code.
>
> I added the "default: 200" line and can add a "maxItems: 1", but begin
> getting errors when I attempt to further define this field as a
> uint32 type or anything like that.
There are no errors after adding proper type. However I cannot help you
for some unspecified code with unspecified warnings.
>
> And no, I'm not getting any warnings or errors from the dt_bindings_check.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-18 22:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 16:46 [net-next][PATCH v4] dt-bindings: dsa: Add lan9303 yaml Jerry Ray
2022-10-03 17:48 ` Krzysztof Kozlowski
2022-10-05 7:54 ` Krzysztof Kozlowski
2022-10-17 18:33 ` Jerry.Ray
2022-10-18 22:34 ` Krzysztof Kozlowski [this message]
2022-10-04 15:52 ` kernel test robot
2022-10-08 22:56 ` Vladimir Oltean
2022-10-09 15:20 ` Krzysztof Kozlowski
2022-10-09 22:22 ` Vladimir Oltean
2022-10-10 10:23 ` Krzysztof Kozlowski
2022-10-10 10:29 ` Vladimir Oltean
2022-10-17 18:51 ` Jerry.Ray
2022-10-17 19:13 ` Vladimir Oltean
2022-10-17 19:19 ` Jakub Kicinski
2022-10-17 20:00 ` Jerry.Ray
2022-10-17 21:02 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b446b01-cf9c-a185-bbad-a77b7d73c5d2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jerry.Ray@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).