From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs
Date: Mon, 11 Dec 2023 17:01:58 +0100 [thread overview]
Message-ID: <3b4d8d01-8082-41fb-91f3-5ae5c3ca5bfe@linaro.org> (raw)
In-Reply-To: <6576fe0b.050a0220.e99f3.b2b5@mx.google.com>
On 11/12/2023 13:18, Christian Marangi wrote:
>>> + QCA808X PHYs can have up to 3 LEDs attached.
>>> + All 3 LEDs are disabled by default.
>>> + 2 LEDs have dedicated pins with the 3rd LED having the
>>> + double function of Interrupt LEDs/GPIO or additional LED.
>>> +
>>> + By default this special PIN is set to LED function.
>>> +
>>> +allOf:
>>> + - $ref: ethernet-phy.yaml#
>>> +
>>> +select:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - ethernet-phy-id004d.d101
>>
>> I have impression that this is continuation of some other patchset...
>> Anyway, id004d.d101 is specific to QCA808x?
>>
>
> I used enum assuming eventually more qca808x PHY will come... Yes that
> ID is specific and it's the id of QCA8081. Better to use const?
No, it is fine. I just wanted to be sure that this will not be matched
by other bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-11 16:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 1:48 [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Christian Marangi
2023-12-09 1:48 ` [net-next PATCH 2/2] net: phy: at803x: add LED support for qca808x Christian Marangi
2023-12-09 12:38 ` kernel test robot
2023-12-09 12:44 ` Christian Marangi
2023-12-11 15:50 ` Andrew Lunn
2023-12-09 18:24 ` kernel test robot
2023-12-11 10:19 ` [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Krzysztof Kozlowski
2023-12-11 12:18 ` Christian Marangi
2023-12-11 16:01 ` Krzysztof Kozlowski [this message]
2023-12-11 15:44 ` Andrew Lunn
2023-12-11 15:48 ` Christian Marangi
2023-12-11 15:54 ` Andrew Lunn
2023-12-11 17:19 ` Christian Marangi
2023-12-11 17:49 ` Andrew Lunn
2023-12-11 17:57 ` Christian Marangi
2023-12-11 15:49 ` Christian Marangi
2023-12-11 15:51 ` Andrew Lunn
2023-12-11 15:57 ` Christian Marangi
2023-12-13 18:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b4d8d01-8082-41fb-91f3-5ae5c3ca5bfe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).