Re: [PATCH v2 2/3] iio: adc: mt6397-auxadc: add mt6397 PMIC AUXADC driver

[Ryan Brue <ryanbrue.dev@gmail.com>]

On 9/17/26 9:27 PM, sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Does this mix scope-based guard() for locking with goto-based error handling
> in mt6397_auxadc_read_channel()?
>
> While this might not cause a direct functional bug in this exact instance
> since the lock is held across the entire function scope and released
> correctly, it explicitly violates the kernel cleanup subsystem rules in
> include/linux/cleanup.h.
>
> The cleanup guidelines mandate that goto and cleanup helpers should never be
> mixed in the same function to avoid introducing an anti-pattern that creates
> confusing ownership semantics.
>
> [ ... ]
>
Whoops, yeah, I introduced that while fixing the teardown when the setup 
fails part-way. I can fix it in a v3. Depending on the timing of Luca's 
patches, I will probably have to do a v3 anyways. I'll wait for more 
human reviews before spinning up a v3 though. Don't want to spam the 
mailing list :)

Best regards,
Ryan