From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73A0C7EE23 for ; Tue, 30 May 2023 02:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbjE3Ch6 (ORCPT ); Mon, 29 May 2023 22:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbjE3Ch4 (ORCPT ); Mon, 29 May 2023 22:37:56 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AB6FC7; Mon, 29 May 2023 19:37:54 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 8D13724E282; Tue, 30 May 2023 10:37:52 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 30 May 2023 10:37:52 +0800 Received: from [192.168.125.107] (113.72.147.198) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 30 May 2023 10:37:51 +0800 Message-ID: <3b4eff36-28db-5880-3094-efa491a69dc7@starfivetech.com> Date: Tue, 30 May 2023 10:37:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Content-Language: en-US To: Conor Dooley CC: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Jack Zhu , , , , References: <20230529121503.3544-1-changhuang.liang@starfivetech.com> <20230529121503.3544-2-changhuang.liang@starfivetech.com> <20230529-envy-itinerary-e4007cb0da9a@wendy> From: Changhuang Liang In-Reply-To: <20230529-envy-itinerary-e4007cb0da9a@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.198] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/29 22:05, Conor Dooley wrote: > Hey Changhuang, > > Couple of minor bits from me here, you don't need to fix them unless > the binding has to change for other reasons. > Thanks for your comments. [...] >> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive SoC MIPI D-PHY Rx Controller > > nit: either s/SoC/JH7110/ or s/SoC//. > Changed to "StarFive JH7110 SoC MIPI D-PHY Rx Controller"? >> + >> +maintainers: >> + - Jack Zhu >> + - Changhuang Liang >> + >> +description: >> + The StarFive SoC uses the MIPI CSI D-PHY based on M31 IP to transfer >> + CSI camera data. > > nit: "Starfive SoCs contain a MIPI CSI D-PHY based on an M31 IP, used to > transfer CSI camera data." > Will fixed this. >> +properties: >> + compatible: >> + const: starfive,jh7110-dphy-rx [...] >> + resets: >> + items: >> + - description: DPHY_HW reset >> + - description: DPHY_B09_ALWAYS_ON reset > > I'd prefer not to have what looks like copy-paste from a datasheet > and instead a description of what they do. > > Otherwise, this looks grand to me, but I don't understand the hardware > so there is no point in me leaving an R-b on this. > Hopefully Krzysztof can take a look at it in the coming days. > I will wait for Krzysztof's comments.