From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: neil.armstrong@linaro.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
Johan Hovold <johan+linaro@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 6/9] arm64: dts: qcom: sc7280: switch USB+DP QMP PHY to new style of bindings
Date: Mon, 27 Mar 2023 13:19:16 +0300 [thread overview]
Message-ID: <3b5e627d-2ea4-aa66-c0d6-58bf0413b47f@linaro.org> (raw)
In-Reply-To: <be4af5a9-6c82-138d-28dc-73b485fa1a00@linaro.org>
On 27/03/2023 11:12, Neil Armstrong wrote:
> On 26/03/2023 01:57, Dmitry Baryshkov wrote:
>> Change the USB QMP PHY to use newer style of QMP PHY bindings (single
>> resource region, no per-PHY subnodes).
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 57 +++++++++-------------------
>> 1 file changed, 18 insertions(+), 39 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 5e6f9f441f1a..887c490bdd14 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -18,6 +18,7 @@
>> #include <dt-bindings/interconnect/qcom,sc7280.h>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/mailbox/qcom-ipcc.h>
>> +#include <dt-bindings/phy/phy-qcom-qmp.h>
>> #include <dt-bindings/power/qcom-rpmpd.h>
>> #include <dt-bindings/reset/qcom,sdm845-aoss.h>
>> #include <dt-bindings/reset/qcom,sdm845-pdc.h>
>> @@ -3327,49 +3328,26 @@ usb_2_hsphy: phy@88e4000 {
>> resets = <&gcc GCC_QUSB2PHY_SEC_BCR>;
>> };
>> - usb_1_qmpphy: phy-wrapper@88e9000 {
>> - compatible = "qcom,sc7280-qmp-usb3-dp-phy",
>> - "qcom,sm8250-qmp-usb3-dp-phy";
>> - reg = <0 0x088e9000 0 0x200>,
>> - <0 0x088e8000 0 0x40>,
>> - <0 0x088ea000 0 0x200>;
>> + usb_1_qmpphy: phy@88e8000 {
>> + compatible = "qcom,sc7280-qmp-usb3-dp-phy";
>> + reg = <0 0x088e8000 0 0x3000>;
>> status = "disabled";
>> - #address-cells = <2>;
>> - #size-cells = <2>;
>> - ranges;
>> clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
>> <&rpmhcc RPMH_CXO_CLK>,
>> - <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>;
>> - clock-names = "aux", "ref_clk_src", "com_aux";
>> + <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>,
>> + <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
>> + clock-names = "aux",
>> + "ref",
>> + "com_aux",
>> + "usb3_pipe";
>> resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
>> <&gcc GCC_USB3_PHY_PRIM_BCR>;
>> reset-names = "phy", "common";
>> - usb_1_ssphy: usb3-phy@88e9200 {
>> - reg = <0 0x088e9200 0 0x200>,
>> - <0 0x088e9400 0 0x200>,
>> - <0 0x088e9c00 0 0x400>,
>> - <0 0x088e9600 0 0x200>,
>> - <0 0x088e9800 0 0x200>,
>> - <0 0x088e9a00 0 0x100>;
>> - #clock-cells = <0>;
>> - #phy-cells = <0>;
>> - clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
>> - clock-names = "pipe0";
>> - clock-output-names = "usb3_phy_pipe_clk_src";
>> - };
>> -
>> - dp_phy: dp-phy@88ea200 {
>> - reg = <0 0x088ea200 0 0x200>,
>> - <0 0x088ea400 0 0x200>,
>> - <0 0x088eaa00 0 0x200>,
>> - <0 0x088ea600 0 0x200>,
>> - <0 0x088ea800 0 0x200>;
>> - #phy-cells = <0>;
>> - #clock-cells = <1>;
>> - };
>> + #clock-cells = <1>;
>> + #phy-cells = <1>;
>> };
>> usb_2: usb@8cf8800 {
>> @@ -3694,7 +3672,7 @@ usb_1_dwc3: usb@a600000 {
>> iommus = <&apps_smmu 0xe0 0x0>;
>> snps,dis_u2_susphy_quirk;
>> snps,dis_enblslpm_quirk;
>> - phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
>> + phys = <&usb_1_hsphy>, <&usb_1_qmpphy
>> QMP_USB43DP_USB3_PHY>;
>> phy-names = "usb2-phy", "usb3-phy";
>> maximum-speed = "super-speed";
>> };
>> @@ -3799,8 +3777,8 @@ dispcc: clock-controller@af00000 {
>> <&gcc GCC_DISP_GPLL0_CLK_SRC>,
>> <&mdss_dsi_phy 0>,
>> <&mdss_dsi_phy 1>,
>> - <&dp_phy 0>,
>> - <&dp_phy 1>,
>> + <&usb_1_qmpphy QMP_USB43DP_DP_LINK_CLK>,
>> + <&usb_1_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>,
>> <&mdss_edp_phy 0>,
>> <&mdss_edp_phy 1>;
>
> The gcc usb3_phy_wrapper_gcc_usb30_pipe_clk entry is missing, it was
> already missing with legacy bindings.
Point noted, it should probably go into a separate change.
>
> Neil
>
>> clock-names = "bi_tcxo",
>> @@ -4138,8 +4116,9 @@ mdss_dp: displayport-controller@ae90000 {
>> "stream_pixel";
>> assigned-clocks = <&dispcc
>> DISP_CC_MDSS_DP_LINK_CLK_SRC>,
>> <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
>> - assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
>> - phys = <&dp_phy>;
>> + assigned-clock-parents = <&usb_1_qmpphy
>> QMP_USB43DP_DP_LINK_CLK>,
>> + <&usb_1_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>;
>> + phys = <&usb_1_qmpphy QMP_USB43DP_DP_PHY>;
>> phy-names = "dp";
>> operating-points-v2 = <&dp_opp_table>;
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-03-27 10:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 0:57 [PATCH v2 0/9] phy: qcom-qmp-combo: convert to newer style of bindings Dmitry Baryshkov
2023-03-26 0:57 ` [PATCH v2 1/9] dt-bindings: phy: migrate combo QMP PHY bindings to qcom,sc8280xp-qmp-usb43dp-phy.yaml Dmitry Baryshkov
2023-03-28 7:02 ` Krzysztof Kozlowski
2023-03-28 10:41 ` Dmitry Baryshkov
2023-03-28 10:45 ` Krzysztof Kozlowski
2023-03-26 0:57 ` [PATCH v2 2/9] phy: qcom-qmp-combo: simplify clock handling Dmitry Baryshkov
2023-03-26 0:57 ` [PATCH v2 3/9] phy: qcom-qmp-combo: populate offsets for all combo PHYs Dmitry Baryshkov
2023-03-27 8:06 ` Neil Armstrong
2023-03-26 0:57 ` [PATCH v2 4/9] phy: qcom-qmp-combo: add qcom,sc7280-qmp-usb3-dp-phy compat entry Dmitry Baryshkov
2023-03-27 8:07 ` Neil Armstrong
2023-03-26 0:57 ` [PATCH v2 5/9] arm64: dts: qcom: sc7180: switch USB+DP QMP PHY to new style of bindings Dmitry Baryshkov
2023-03-27 8:09 ` Neil Armstrong
2023-03-26 0:57 ` [PATCH v2 6/9] arm64: dts: qcom: sc7280: " Dmitry Baryshkov
2023-03-27 8:12 ` Neil Armstrong
2023-03-27 10:19 ` Dmitry Baryshkov [this message]
2023-03-26 0:57 ` [PATCH v2 7/9] arm64: dts: qcom: sdm845: " Dmitry Baryshkov
2023-03-27 8:13 ` Neil Armstrong
2023-03-26 0:57 ` [PATCH v2 8/9] arm64: dts: qcom: sm8150: " Dmitry Baryshkov
2023-03-27 8:14 ` Neil Armstrong
2023-03-26 0:57 ` [PATCH v2 9/9] arm64: dts: qcom: sm8250: " Dmitry Baryshkov
2023-03-27 8:14 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b5e627d-2ea4-aa66-c0d6-58bf0413b47f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).