From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F648C433EF for ; Fri, 22 Jul 2022 18:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235478AbiGVSY2 (ORCPT ); Fri, 22 Jul 2022 14:24:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236033AbiGVSY1 (ORCPT ); Fri, 22 Jul 2022 14:24:27 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 210119B1A3 for ; Fri, 22 Jul 2022 11:24:26 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id y11so8884403lfs.6 for ; Fri, 22 Jul 2022 11:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=y4PUfnBxYpq9HSb+fauW+K364XPSFPA2RCgwysiSwtk=; b=POp8xz8gqsVDeOEnSV/znwpLLT/7mt1y58ijKtYQv6llFmQcKLiM0tfuj9mzKssBKm 2Lv5tr+E76TkfjZA+va5wO6hvWlCrFMa30uPQt1voOY7asDLbyv6q7M4Py75une3UypE 93MAw89KTptjHuWOD5VJr69Wt3YGrVuAbLbHftnh0K0wJ5Jjx/FQBpB4VrhE8i0eQwQa wE5p2vXX/NXWoCwXcLIu8/sDZqRRXXHk0SASmNsfQaXGBTopm5pMbzv9Ku9GU3ruKoW2 EdeqWolvfW/bZQptiziFbwaTAWDV8J3JF+pxi2BkQ3ryfjE29/CyCaNR8Ut7D7HfMzHn XmaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y4PUfnBxYpq9HSb+fauW+K364XPSFPA2RCgwysiSwtk=; b=3gk60357B9kJvbZAFvBtUENli13aYLwsrM3RmQ2hdEEIPjHsoh4ZDdWJbhxKGbk96D 9KukpW0HZAEwVq8JTB5ASOUUkoWd6Tvq7lBGFGF/lMBrFx6TyWoC6zhlGjvMvXYbFKWv zehOrIzNMu5sPlk+caNzL4WA4noobQmIKMzkMyHguGd/CrMeR34OJ9Fn5eEiTLGqb39w IpgOW3stjOXNeln54CUjCG/a+h+pMzjPXh9o/Jx9L+fbCjRF52BWHgs5aDLI/h2lB8zl Ou95jiPyiiUYhrWV0PyBhbo8XSUGahUNkaP3ELKBg2CfM5rTiWG/rTt5Jq669NgTBct3 AEAg== X-Gm-Message-State: AJIora9HYnUzHAKVrd+9xBpdt9uQHdN7WgOISnCwWTQAic58iXqGmUEZ 05w7y84cpSqWTYOi2Zq5FQ/UiQ== X-Google-Smtp-Source: AGRyM1us6rSOUrvpiq6AQc8XjSdjL0FZeX63+7AyN+7xrpuEnWAHs+uGC22kUuETgJIr17SRL6nggw== X-Received: by 2002:a05:6512:1683:b0:47f:78ca:8ac5 with SMTP id bu3-20020a056512168300b0047f78ca8ac5mr452500lfb.663.1658514264494; Fri, 22 Jul 2022 11:24:24 -0700 (PDT) Received: from [192.168.10.173] (93.81-167-86.customer.lyse.net. [81.167.86.93]) by smtp.gmail.com with ESMTPSA id 8-20020ac25f08000000b0048a6bb9418esm1172037lfq.295.2022.07.22.11.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 11:24:23 -0700 (PDT) Message-ID: <3b60aa59-c40e-11d0-c6d5-dc1b022ec349@linaro.org> Date: Fri, 22 Jul 2022 20:24:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description Content-Language: en-US To: William Zhang , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20220721000658.29537-1-william.zhang@broadcom.com> <883c2ad4c36220b488519a8902ad72bc@milecki.pl> <193845cb-6149-1ae6-5eb6-6b01ffcf763b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/07/2022 02:07, William Zhang wrote: > > > On 07/21/2022 12:01 AM, Krzysztof Kozlowski wrote: >> On 21/07/2022 08:51, Rafał Miłecki wrote: >>> On 2022-07-21 08:44, Krzysztof Kozlowski wrote: >>>> On 21/07/2022 02:06, William Zhang wrote: >>>>> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add >>>>> generic 4908 board entry. >>>> >>>> This does not explain at all why you are doing it. Improve your commit >>>> messages. >>> >>> To clarify it from my side (and maybe help a bit): >>> >>> 1. As I understand it BCMBCA is a one big family of SoCs. >>> 2. BCM4908 is a subset of that family (a subfamily?) designed for a >>> specific group of devices. >>> >>> If that's correct I think William it's what you should describe in your >>> commit message. That would make binding more accurate and should be a >>> good argument for your change (I believe). >> >> That's better argument. But what's the benefit of adding generic >> compatible? Devices cannot bind to it (it is too generic). Does it >> describe the device anyhow? Imagine someone adding compatible >> "brcm,all-soc-of-broadcom" - does it make any sense? >> > In case you were also referring the generic 4908 board compatible string > brcm,bcm94908, this is for a bare bone 4908 board dts that only enables No, we refer to the contents of the patch, so bcmbca compatible. I did not see you introducing here bcm4908 compatible. > ARM cpu subsystem, memory and uart. It can be used on all 4908 based > Broadcom reference boards and customer board. It is especially useful > for initial board bring up and one can load this generic board and start > work and debug from the console. Also would be helpful to do a quick > verification of new kernel version when there is cpu subsystem related > change. > > I guess my mindset already assume people are now familiar with this > model of bcmbca binding addition for a new SoC since we introduced the > bcmbca arch with first soc 47622 and 10+ other socs late. But sure I > agree and I will update the commit message with more details in addition > to what the cover letter says. Best regards, Krzysztof