From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B1FC77B73 for ; Wed, 19 Apr 2023 18:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233487AbjDSSLK (ORCPT ); Wed, 19 Apr 2023 14:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbjDSSLJ (ORCPT ); Wed, 19 Apr 2023 14:11:09 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E225FEC for ; Wed, 19 Apr 2023 11:11:05 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5058181d58dso190622a12.1 for ; Wed, 19 Apr 2023 11:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681927864; x=1684519864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2j1Pkr50g1mSceZHX8SMamWZIYT0Wo0+87cbSXw7e3o=; b=m+cMiZEoVpqxyT/om0k6XXK3bOf3Pnff/VflBJct4TbCkartXBbel29eKfpE9IWZvi S4ZUKSV6EXpHQ8zuORLbeV/u+ni6sq9BlxReFP0ECkw/+0dq7VRxqb3rIB1j5B0/oT25 HObV51x2RuIfHa0WVmal7WRUebQo4Kp9KIDgtprIK/DwbA+Nz5es2pWXc5ulhoQbOrYX IHRxkGCj8TlYwdDI44bh8wW7iHPl6mHkK8LvOCKPqHKvVWzpjUD0b+WsjUzilILMFH42 9UVXyk8Sn04HGtwNOPR0vij04blgLVO4iVo5jbP8BRClZ/LI99gJA/czjWEHSdLvt7DM xY/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681927864; x=1684519864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2j1Pkr50g1mSceZHX8SMamWZIYT0Wo0+87cbSXw7e3o=; b=fyAW2N+ckJE1uv29DEJ1ED1fWccSCL/WfwpkeQZ+MbfpB4HwM+aogEUNeIusygarjD /Hj0gLOCEvSblKwiICHFM+nEu+SxlAPLbE8TyP7mBnPYDz26RzwkwnFT82cXbR3tb4tj PI8TBJ8RbmM1Xb4eb3UwMwDxSSydlYWeNpcrIUuN0A9p01BdYl6fynSAUrbcJnMALIg0 Glv1/hVHukMXcDeR624Evk+vDdtLRB9010Alq8nzlLkjLXTDNzcBsNFeuY/QIKHBhlz0 bfWIoZt3pZHKVPp23f3BWY6zKaHYYjh92/r76Z5+Q0+lwTyB6PUYOrF6IrzC5kWgHtO2 mIVA== X-Gm-Message-State: AAQBX9cD5ZdIfrsfSkSG9gvqt1Qb/Y6I4lXDQCkobYiPIKg1OT5fpqCA 71HkH28ptIOvkHRMf8oVGYX/3g== X-Google-Smtp-Source: AKy350a8Vdr07kQJG1rigtqy3d4/Y6OrVskqooISmVBchT4XXGJtlyrkQQiZkJt8od8HpD6LxrUw3w== X-Received: by 2002:aa7:d6c2:0:b0:505:47a:7ae8 with SMTP id x2-20020aa7d6c2000000b00505047a7ae8mr6638521edr.4.1681927864360; Wed, 19 Apr 2023 11:11:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:b7d8:d88b:1fac:c802? ([2a02:810d:15c0:828:b7d8:d88b:1fac:c802]) by smtp.gmail.com with ESMTPSA id bo25-20020a0564020b3900b005067d129267sm7397824edb.39.2023.04.19.11.11.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 11:11:03 -0700 (PDT) Message-ID: <3b7394e1-1be7-ec38-61bd-708a624070ac@linaro.org> Date: Wed, 19 Apr 2023 20:11:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/4] dt-bindings: clock: Add GCC bindings support for SDX75 Content-Language: en-US To: Taniya Das , Stephen Boyd , Rob Herring , Bjorn Andersson , Andy Gross , Krzysztof Kozlowski , Richard Cochran , Michael Turquette Cc: quic_skakitap@quicinc.com, Imran Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohiagar@quicinc.com, netdev@vger.kernel.org References: <20230419133013.2563-1-quic_tdas@quicinc.com> <20230419133013.2563-3-quic_tdas@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230419133013.2563-3-quic_tdas@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2023 15:30, Taniya Das wrote: > From: Imran Shaik > Thank you for your patch. There is something to discuss/improve. > Add support for GCC bindings and update documentation for > clock rpmh driver for SDX75. Subject: drop second/last, redundant "bindings support for". The "dt-bindings" prefix is already stating that these are bindings. But missing vendor name (Qualcomm). Both in subject and commit msg. > > Signed-off-by: Imran Shaik > Signed-off-by: Taniya Das > --- > .../bindings/clock/qcom,gcc-sdx75.yaml | 69 +++++++ > .../bindings/clock/qcom,rpmhcc.yaml | 1 + > include/dt-bindings/clock/qcom,gcc-sdx75.h | 193 ++++++++++++++++++ > 3 files changed, 263 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx75.yaml > create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx75.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdx75.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdx75.yaml > new file mode 100644 > index 000000000000..6489d857d5c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdx75.yaml All new devices come as SoC-IP, so qcom,sdx75-gcc > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdx75.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller on SDX75 > + > +maintainers: > + - Imran Shaik > + - Taniya Das > + > +description: | > + Qualcomm global clock control module provides the clocks, resets and power > + domains on SDX75 > + > + See also:: include/dt-bindings/clock/qcom,gcc-sdx75.h Also hee > + > +properties: > + compatible: > + const: qcom,gcc-sdx75 Also here > + > + clocks: > + items: > + - description: Board XO source > + - description: PCIE20 phy aux clock source > + - description: PCIE_1 Pipe clock source > + - description: PCIE_2 Pipe clock source > + - description: PCIE Pipe clock source > + - description: Sleep clock source > + - description: USB3 phy wrapper pipe clock source > + > + clock-names: > + items: > + - const: bi_tcxo > + - const: pcie20_phy_aux_clk > + - const: pcie_1_pipe_clk > + - const: pcie_2_pipe_clk > + - const: pcie_pipe_clk > + - const: sleep_clk > + - const: usb3_phy_wrapper_gcc_usb30_pipe_clk Drop clock names entirely. > + > +required: > + - compatible > + - clocks > + - clock-names > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + clock-controller@80000 { > + compatible = "qcom,gcc-sdx75"; > + reg = <0x80000 0x1f7400>; > + clocks = <&rpmhcc RPMH_CXO_CLK>, <&pcie20_phy_aux_clk>, <&pcie_1_pipe_clk>, > + <&pcie_2_pipe_clk>, <&pcie_pipe_clk>, <&sleep_clk>, > + <&usb3_phy_wrapper_gcc_usb30_pipe_clk>; > + clock-names = "bi_tcxo", "pcie20_phy_aux_clk", "pcie_1_pipe_clk", > + "pcie_2_pipe_clk", "pcie_pipe_clk", "sleep_clk", > + "usb3_phy_wrapper_gcc_usb30_pipe_clk"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > +... > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml > index d5a250b7c2af..267cf8c26823 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml > @@ -27,6 +27,7 @@ properties: > - qcom,sdm845-rpmh-clk > - qcom,sdx55-rpmh-clk > - qcom,sdx65-rpmh-clk > + - qcom,sdx75-rpmh-clk Separate patch. > - qcom,sm6350-rpmh-clk > - qcom,sm8150-rpmh-clk > - qcom,sm8250-rpmh-clk > diff --git a/include/dt-bindings/clock/qcom,gcc-sdx75.h b/include/dt-bindings/clock/qcom,gcc-sdx75.h > new file mode 100644 > index 000000000000..a470e8c4fd41 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,gcc-sdx75.h qcom,sdx75-gcc > @@ -0,0 +1,193 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2022-2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_CLK_QCOM_GCC_SDX75_H > +#define _DT_BINDINGS_CLK_QCOM_GCC_SDX75_H > + > +/* GCC clocks */ Best regards, Krzysztof