From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
agross@kernel.org, bjorn.andersson@linaro.org,
konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, gurus@codeaurora.org,
aghayal@codeaurora.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2 RESEND] extcon: qcom-spmi: Switch to platform_get_irq_byname_optional
Date: Wed, 28 Sep 2022 11:59:48 +0100 [thread overview]
Message-ID: <3b76d507-d35e-e72b-d576-2c14e0718aa3@linaro.org> (raw)
In-Reply-To: <20220928085313.6fscjxuxto4kdz6s@SoMainline.org>
On 28/09/2022 09:54, Marijn Suijten wrote:
> On 2022-09-26 12:31:43, Bryan O'Donoghue wrote:
>> Valid configurations for the extcon interrupt declarations are
>>
>> - usb_id
>> - usb_vbus
>> - (usb_id | usb_vbus)
>>
>> In the case of a standalone usb_id or usb_vbus failure to find one of the
>> interrupts shouldn't generate a warning message. A warning is already in
>> place if both IRQs are missing.
>>
>> Switch to using platform_get_irq_byname_optional() in order to facilitate
>> this behaviour.
>>
>> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> Feel free to carry my review from [1] even after addressing the
> commit-message nit - thanks for doing so by the way!
>
> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
>
> [1]: https://lore.kernel.org/linux-arm-msm/20220704214444.p5oqik2cqo6h7723@SoMainline.org/
>
> - Marijn
Cool, thanks.
next prev parent reply other threads:[~2022-09-28 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 11:31 [PATCH v4 0/2 RESEND] Fix pm8941-misc extcon interrupt dependency assumptions Bryan O'Donoghue
2022-09-26 11:31 ` [PATCH v4 1/2 RESEND] dt-bindings: pm8941-misc: Fix usb_id and usb_vbus definitions Bryan O'Donoghue
2022-09-26 11:31 ` [PATCH v4 2/2 RESEND] extcon: qcom-spmi: Switch to platform_get_irq_byname_optional Bryan O'Donoghue
2022-09-28 8:54 ` Marijn Suijten
2022-09-28 10:59 ` Bryan O'Donoghue [this message]
2022-09-28 8:45 ` [PATCH v4 0/2 RESEND] Fix pm8941-misc extcon interrupt dependency assumptions Marijn Suijten
2022-11-22 20:15 ` Luca Weiss
2022-11-24 0:38 ` Bryan O'Donoghue
-- strict thread matches above, loose matches on Subject: below --
2022-12-28 13:30 Bryan O'Donoghue
2022-12-28 13:30 ` [PATCH v4 2/2 RESEND] extcon: qcom-spmi: Switch to platform_get_irq_byname_optional Bryan O'Donoghue
2022-12-28 22:54 ` Marijn Suijten
2023-01-10 13:27 ` Chanwoo Choi
2022-09-08 11:25 [PATCH v4 0/2 RESEND] Fix pm8941-misc extcon interrupt dependency assumptions Bryan O'Donoghue
2022-09-08 11:25 ` [PATCH v4 2/2 RESEND] extcon: qcom-spmi: Switch to platform_get_irq_byname_optional Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b76d507-d35e-e72b-d576-2c14e0718aa3@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).