devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Chanho Park <chanho61.park@samsung.com>,
	Sam Protsenko <semen.protsenko@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sylwester Nawrocki <snawrocki@kernel.org>, stable@vger.kernel.org
Subject: Re: [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2
Date: Fri, 31 Dec 2021 13:02:37 +0100	[thread overview]
Message-ID: <3b7e0827-bda5-91c5-24a5-77c67e2273ab@canonical.com> (raw)
In-Reply-To: <20211230195325.328220-2-krzysztof.kozlowski@canonical.com>

On 30/12/2021 20:53, Krzysztof Kozlowski wrote:
> Each pin configuration in pin controller should be a node with
> "samsung,pins" and other similar properties.  However the macro PIN()
> (used for initial/sleep states) defines entire node, so PCIe WLAN pin
> configuration node was ignored.
> 
> Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 

This patch is not correct, because the driver/bindings allow and work
with such DTS. Please ignore.


Best regards,
Krzysztof

  reply	other threads:[~2021-12-31 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211230195340eucas1p1ebbcf10a6b4fb15fca9b7757af5e1702@eucas1p1.samsung.com>
2021-12-30 19:53 ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Krzysztof Kozlowski
2021-12-30 19:53   ` [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Krzysztof Kozlowski
2021-12-31 12:02     ` Krzysztof Kozlowski [this message]
2021-12-30 19:53   ` [RFT][PATCH 3/3] arm64: dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850 Krzysztof Kozlowski
2022-01-03 21:09     ` Sam Protsenko
2022-01-07  7:47       ` Krzysztof Kozlowski
2022-02-12 16:31     ` (subset) " Krzysztof Kozlowski
2022-01-06 18:13   ` [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Alim Akhtar
2022-01-10 22:20   ` Marek Szyprowski
2022-01-23 17:10   ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7e0827-bda5-91c5-24a5-77c67e2273ab@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=semen.protsenko@linaro.org \
    --cc=snawrocki@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).