devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	<matthias.bgg@gmail.com>
Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<sam.shih@mediatek.com>, <hanks.chen@mediatek.com>,
	<weiyi.lu@mediatek.com>, <zhiyong.tao@mediatek.com>,
	<andrew-sh.cheng@mediatek.com>, <viresh.kumar@linaro.org>,
	<fparent@baylibre.com>, <mars.cheng@mediatek.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
Date: Fri, 14 Oct 2022 10:43:55 +0800	[thread overview]
Message-ID: <3b7fc7414f282ca044c24dae280f9bc9533a5b7b.camel@mediatek.com> (raw)
In-Reply-To: <20221013152212.416661-7-angelogioacchino.delregno@collabora.com>

On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
> Update the names to regulator-usb-p{0-3}-vbus to fix
> unit_address_vs_reg
> warnings for those.
> 
> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 638908773706..d31a194124c9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>  		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>  	};
>  
> -	usb_p0_vbus: regulator@2 {
> +	usb_p0_vbus: regulator-usb-p0-vbus {
Can we modify dt-binding of fixed regulator instead of changing the
node name,
since all nodes using fixed regulator may need be changed.

>  		compatible = "regulator-fixed";
>  		regulator-name = "p0_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 {
>  		enable-active-high;
>  	};
>  
> -	usb_p1_vbus: regulator@3 {
> +	usb_p1_vbus: regulator-usb-p1-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p1_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 {
>  		enable-active-high;
>  	};
>  
> -	usb_p2_vbus: regulator@4 {
> +	usb_p2_vbus: regulator-usb-p2-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p2_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 {
>  		enable-active-high;
>  	};
>  
> -	usb_p3_vbus: regulator@5 {
> +	usb_p3_vbus: regulator-usb-p3-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p3_vbus";
>  		regulator-min-microvolt = <5000000>;


  reply	other threads:[~2022-10-14  2:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 1/8] arm64: dts: mt7896a: Fix unit_address_vs_reg warning for oscillator AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 2/8] arm64: dts: mt6779: Fix devicetree build warnings AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 3/8] arm64: dts: mt2712e: Fix unit_address_vs_reg warning for oscillators AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 4/8] arm64: dts: mt2712e: Fix unit address for pinctrl node AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 5/8] arm64: dts: mt2712-evb: Fix vproc fixed regulators unit names AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus " AngeloGioacchino Del Regno
2022-10-14  2:43   ` Chunfeng Yun [this message]
2022-10-14  7:35     ` AngeloGioacchino Del Regno
2022-10-21  6:25       ` Chunfeng Yun
2022-10-21  8:13         ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 7/8] arm64: dts: mediatek: pumpkin-common: Fix devicetree warnings AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 8/8] arm64: dts: mediatek: mt6797: Fix 26M oscillator unit name AngeloGioacchino Del Regno
2022-11-21 12:03 ` [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7fc7414f282ca044c24dae280f9bc9533a5b7b.camel@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=andrew-sh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fparent@baylibre.com \
    --cc=hanks.chen@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mars.cheng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sam.shih@mediatek.com \
    --cc=viresh.kumar@linaro.org \
    --cc=weiyi.lu@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).