From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, quic_pkumpatl@quicinc.com,
kernel@oss.qualcomm.com
Subject: Re: [PATCH v2 2/2] ASoC: codecs: wsa883x: Handle shared reset GPIO for WSA883x speakers
Date: Tue, 22 Jul 2025 14:38:07 +0200 [thread overview]
Message-ID: <3ba94864-769c-4a73-8e70-a3904280317f@kernel.org> (raw)
In-Reply-To: <8d488066-6f29-4ef8-8f09-26328b5213f1@oss.qualcomm.com>
On 22/07/2025 13:11, Mohammad Rafi Shaik wrote:
Again, trim the output from irrelevant parts.
> [ 10.928781][ T90] Call trace:
> [ 10.932024][ T90] _regulator_put+0x50/0x60 (P)
> [ 10.936877][ T90] regulator_put+0x30/0x48
> [ 10.941276][ T90] devm_regulator_release+0x14/0x20
> [ 10.946486][ T90] release_nodes+0x60/0xfc
> [ 10.950886][ T90] devres_release_all+0x90/0xe0
> [ 10.955737][ T90] device_unbind_cleanup+0x18/0x60
> [ 10.960846][ T90] really_probe+0x210/0x2c0
> [ 10.965341][ T90] __driver_probe_device+0x78/0x120
Although wsa probe function is not here, but this feels like it deferred
or exited with failure and some cleanups were incomplete. Current code
looks correct, so I suspect that whatever you did there introduced the
errors. So bug in your code is the answer that you converted it to devm
interface. That conversion should be rather separate patch.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-22 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 10:46 [PATCH v2 0/2] Handle shared reset GPIO for WSA883x speakers Mohammad Rafi Shaik
2025-07-18 10:46 ` [PATCH v2 1/2] ASoC: dt-bindings: qcom,wsa8830: Add reset-gpios for shared line Mohammad Rafi Shaik
2025-07-21 8:19 ` Krzysztof Kozlowski
2025-07-18 10:46 ` [PATCH v2 2/2] ASoC: codecs: wsa883x: Handle shared reset GPIO for WSA883x speakers Mohammad Rafi Shaik
2025-07-21 8:23 ` Krzysztof Kozlowski
2025-07-22 10:56 ` Mohammad Rafi Shaik
2025-07-22 11:06 ` Krzysztof Kozlowski
2025-07-22 11:11 ` Mohammad Rafi Shaik
2025-07-22 12:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba94864-769c-4a73-8e70-a3904280317f@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).