public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Alim Akhtar" <alim.akhtar@samsung.com>,
	"Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Juan Yescas" <jyescas@google.com>,
	"Will McVicker" <willmcvicker@google.com>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: (subset) [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101
Date: Mon, 30 Mar 2026 12:17:03 +0200	[thread overview]
Message-ID: <3bb6b71e-947b-4248-95ba-79852f743c1d@kernel.org> (raw)
In-Reply-To: <CAPDyKFrK3NLwaii-9FEmyaTzUAuVkMkLL3rWBQwQvT-M+PzEHA@mail.gmail.com>

On 30/03/2026 12:13, Ulf Hansson wrote:
> On Mon, 30 Mar 2026 at 11:54, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 23/03/2026 12:13, Ulf Hansson wrote:
>>> Hi Krzysztof,
>>>
>>> On Sat, 21 Mar 2026 at 14:18, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>>
>>>> On Wed, 18 Mar 2026 15:27:45 +0000, André Draszik wrote:
>>>>> This series adds support for the power domains on Google GS101.
>>>>>
>>>>> There are a few differences compared to SoCs already supported by this
>>>>> driver:
>>>>> * register access does not work via plain ioremap() / readl() /
>>>>>   writel().
>>>>>   Instead, the regmap created by the PMU driver must be used (which
>>>>>   uses Arm SMCC calls under the hood).
>>>>> * DTZPC: a call needs to be made before and after power domain off/on,
>>>>>   to inform the EL3 firmware of the request.
>>>>> * power domains can and are fed by a regulator rail and therefore
>>>>>   regulator control needed be implemented.
>>>>>
>>>>> [...]
>>>>
>>>> Applied, thanks!
>>>>
>>>> [01/10] dt-bindings: soc: google: add google,gs101-dtzpc
>>>>         https://git.kernel.org/krzk/linux/c/10084aeadadfab72648f6ed1cc78f7cd87b861ba
>>>> [03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding
>>>>         https://git.kernel.org/krzk/linux/c/3ec3c42b426fe5e2b48ff19c551dec50bc78788c
>>>> [04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
>>>>         https://git.kernel.org/krzk/linux/c/c8229a5160eea145b796f54317d6e659cec9b080
>>>>
>>>> Best regards,
>>>
>>> Usually I pick up the power-domain related changes for the DT bindings
>>> and host them via an immutable branch called "dt". If needed, SOC
>>> maintainers can pull it to apply/test the corresponding DTS changes.
>>>
>>> That said, I am open to whatever you think is best here. Perhaps it's
>>> easier if you can drop the DT patches and provide your acks instead or
>>> if you can share them via an immutable branch for me to pull?
>>
>>
>> I did not pick up any pmdomain binding patches. I picked up only soc and
>> according to cover letter there are no dependencies between anything here.
> 
> As I understand it, they are all related and some even depend on each

I raised exactly that questions but no answers.

> other. I think keeping all four DT patches together makes sense.

Why? What is the dependency?

> 
> Although, as I said, if you think it's best to funnel them through
> your tree, please do and then share them via an immutable branch, so I
> can apply the pmdomain driver changes.

soc must go via my tree, but there is no reason to take the pmdomain
binding patch. So I did not take.

But anyway, I just noticed that I dropped everything: this introduces
new warnings which were nowhere addressed or explained. So regardless
how this should go, please do not apply anything - it's broken and
author is silent.


Best regards,
Krzysztof

  reply	other threads:[~2026-03-30 10:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 15:27 [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-03-18 15:27 ` [PATCH v8 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-03-18 15:27 ` [PATCH v8 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-03-21 13:16   ` Krzysztof Kozlowski
2026-03-30 10:52     ` André Draszik
2026-03-30 10:55       ` Krzysztof Kozlowski
2026-03-30 10:59         ` André Draszik
2026-03-30 11:03           ` Krzysztof Kozlowski
2026-03-18 15:27 ` [PATCH v8 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-03-18 15:27 ` [PATCH v8 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-03-21 19:14   ` Krzysztof Kozlowski
2026-03-30 12:00     ` André Draszik
2026-03-30 12:10       ` Krzysztof Kozlowski
2026-03-22 23:08   ` Rob Herring (Arm)
2026-03-18 15:27 ` [PATCH v8 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-03-19 10:13   ` Ulf Hansson
2026-03-19 10:29     ` Marek Szyprowski
2026-03-19 11:58       ` André Draszik
2026-03-19 15:57         ` Marek Szyprowski
2026-03-19 16:42           ` Ulf Hansson
2026-03-21 13:16   ` Krzysztof Kozlowski
2026-03-30 10:53     ` André Draszik
2026-03-18 15:27 ` [PATCH v8 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-03-18 15:27 ` [PATCH v8 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-03-21 13:16   ` Krzysztof Kozlowski
2026-03-30 10:55     ` André Draszik
2026-03-18 15:27 ` [PATCH v8 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-03-18 15:27 ` [PATCH v8 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-03-18 15:27 ` [PATCH v8 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-03-21 13:17 ` (subset) [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 Krzysztof Kozlowski
2026-03-23 11:13   ` Ulf Hansson
2026-03-30  9:54     ` Krzysztof Kozlowski
2026-03-30 10:13       ` Ulf Hansson
2026-03-30 10:17         ` Krzysztof Kozlowski [this message]
2026-03-30 11:12           ` Ulf Hansson
2026-03-30 11:24             ` Krzysztof Kozlowski
2026-03-30 13:30               ` Ulf Hansson
2026-03-30 13:38                 ` Krzysztof Kozlowski
2026-03-31  9:01                   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bb6b71e-947b-4248-95ba-79852f743c1d@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jyescas@google.com \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox