* [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node
2023-03-22 17:15 [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Jianhua Lu
@ 2023-03-22 17:15 ` Jianhua Lu
2023-03-22 18:16 ` Konrad Dybcio
2023-03-22 17:15 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add Xiaomi Mi Pad 5 Pro BOE variant Jianhua Lu
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Jianhua Lu @ 2023-03-22 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Jianhua Lu
xiaomi-elish uses dual dsi mode panel and dsi phy type is cphy.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
Changes in v2:
- Include missing <dt-bindings/phy/phy.h> for phy-type property.
.../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 73 +++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
index a43d4b73ffca..4ff8454d4abe 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
@@ -5,6 +5,7 @@
#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/phy/phy.h>
#include "sm8250.dtsi"
#include "pm8150.dtsi"
#include "pm8150b.dtsi"
@@ -469,6 +470,74 @@ &cdsp {
status = "okay";
};
+&dsi0 {
+ vdda-supply = <&vreg_l9a_1p2>;
+ qcom,dual-dsi-mode;
+ qcom,master-dsi;
+ qcom,sync-dual-dsi;
+ status = "okay";
+
+ display_panel: panel@0 {
+ reg = <0>;
+ vddio-supply = <&vreg_l14a_1p88>;
+ reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
+ backlight = <&backlight>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ panel_in_0: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+
+ port@1{
+ reg = <1>;
+ panel_in_1: endpoint {
+ remote-endpoint = <&dsi1_out>;
+ };
+ };
+
+ };
+ };
+};
+
+&dsi0_out {
+ data-lanes = <0 1 2>;
+ remote-endpoint = <&panel_in_0>;
+};
+
+&dsi0_phy {
+ vdds-supply = <&vreg_l5a_0p88>;
+ phy-type = <PHY_TYPE_CPHY>;
+ status = "okay";
+};
+
+&dsi1 {
+ vdda-supply = <&vreg_l9a_1p2>;
+ qcom,dual-dsi-mode;
+ qcom,sync-dual-dsi;
+ /* DSI1 is slave, so use DSI0 clocks */
+ assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
+ status = "okay";
+};
+
+&dsi1_out {
+ data-lanes = <0 1 2>;
+ remote-endpoint = <&panel_in_1>;
+};
+
+&dsi1_phy {
+ vdds-supply = <&vreg_l5a_0p88>;
+ phy-type = <PHY_TYPE_CPHY>;
+ status = "okay";
+};
+
&gmu {
status = "okay";
};
@@ -533,6 +602,10 @@ fuel-gauge@55 {
};
};
+&mdss {
+ status = "okay";
+};
+
&pcie0 {
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node
2023-03-22 17:15 ` [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node Jianhua Lu
@ 2023-03-22 18:16 ` Konrad Dybcio
2023-03-23 0:22 ` Jianhua Lu
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-03-22 18:16 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 22.03.2023 18:15, Jianhua Lu wrote:
> xiaomi-elish uses dual dsi mode panel and dsi phy type is cphy.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> Changes in v2:
> - Include missing <dt-bindings/phy/phy.h> for phy-type property.
>
> .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index a43d4b73ffca..4ff8454d4abe 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/arm/qcom,ids.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/phy/phy.h>
'p' < 'r'
> #include "sm8250.dtsi"
> #include "pm8150.dtsi"
> #include "pm8150b.dtsi"
> @@ -469,6 +470,74 @@ &cdsp {
> status = "okay";
> };
>
> +&dsi0 {
> + vdda-supply = <&vreg_l9a_1p2>;
> + qcom,dual-dsi-mode;
> + qcom,master-dsi;
Keep the master property after qcom,sync-dual-dsi so that we
get a nice reverse-Christmas-tree.
> + qcom,sync-dual-dsi;
> + status = "okay";
> +
> + display_panel: panel@0 {
> + reg = <0>;
> + vddio-supply = <&vreg_l14a_1p88>;
> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> + backlight = <&backlight>;
> +
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
Please add newlines before subnodes.
Konrad
> + panel_in_0: endpoint {
> + remote-endpoint = <&dsi0_out>;
> + };
> + };
> +
> + port@1{
> + reg = <1>;
> + panel_in_1: endpoint {
> + remote-endpoint = <&dsi1_out>;
> + };
> + };
> +
> + };
> + };
> +};
> +
> +&dsi0_out {
> + data-lanes = <0 1 2>;
> + remote-endpoint = <&panel_in_0>;
> +};
> +
> +&dsi0_phy {
> + vdds-supply = <&vreg_l5a_0p88>;
> + phy-type = <PHY_TYPE_CPHY>;
> + status = "okay";
> +};
> +
> +&dsi1 {
> + vdda-supply = <&vreg_l9a_1p2>;
> + qcom,dual-dsi-mode;
> + qcom,sync-dual-dsi;
> + /* DSI1 is slave, so use DSI0 clocks */
> + assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
> + status = "okay";
> +};
> +
> +&dsi1_out {
> + data-lanes = <0 1 2>;
> + remote-endpoint = <&panel_in_1>;
> +};
> +
> +&dsi1_phy {
> + vdds-supply = <&vreg_l5a_0p88>;
> + phy-type = <PHY_TYPE_CPHY>;
> + status = "okay";
> +};
> +
> &gmu {
> status = "okay";
> };
> @@ -533,6 +602,10 @@ fuel-gauge@55 {
> };
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> &pcie0 {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node
2023-03-22 18:16 ` Konrad Dybcio
@ 2023-03-23 0:22 ` Jianhua Lu
0 siblings, 0 replies; 10+ messages in thread
From: Jianhua Lu @ 2023-03-23 0:22 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On Wed, Mar 22, 2023 at 07:16:40PM +0100, Konrad Dybcio wrote:
>
>
> On 22.03.2023 18:15, Jianhua Lu wrote:
> > xiaomi-elish uses dual dsi mode panel and dsi phy type is cphy.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > Changes in v2:
> > - Include missing <dt-bindings/phy/phy.h> for phy-type property.
> >
> > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 73 +++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > index a43d4b73ffca..4ff8454d4abe 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > @@ -5,6 +5,7 @@
> >
> > #include <dt-bindings/arm/qcom,ids.h>
> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > +#include <dt-bindings/phy/phy.h>
> 'p' < 'r'
Acked
>
>
> > #include "sm8250.dtsi"
> > #include "pm8150.dtsi"
> > #include "pm8150b.dtsi"
> > @@ -469,6 +470,74 @@ &cdsp {
> > status = "okay";
> > };
> >
> > +&dsi0 {
> > + vdda-supply = <&vreg_l9a_1p2>;
> > + qcom,dual-dsi-mode;
> > + qcom,master-dsi;
> Keep the master property after qcom,sync-dual-dsi so that we
> get a nice reverse-Christmas-tree.
Acked
>
> > + qcom,sync-dual-dsi;
> > + status = "okay";
> > +
> > + display_panel: panel@0 {
> > + reg = <0>;
> > + vddio-supply = <&vreg_l14a_1p88>;
> > + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> > + backlight = <&backlight>;
> > +
> > + status = "disabled";
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> Please add newlines before subnodes.
Acked
>
> Konrad
> > + panel_in_0: endpoint {
> > + remote-endpoint = <&dsi0_out>;
> > + };
> > + };
> > +
> > + port@1{
> > + reg = <1>;
> > + panel_in_1: endpoint {
> > + remote-endpoint = <&dsi1_out>;
> > + };
> > + };
> > +
> > + };
> > + };
> > +};
> > +
> > +&dsi0_out {
> > + data-lanes = <0 1 2>;
> > + remote-endpoint = <&panel_in_0>;
> > +};
> > +
> > +&dsi0_phy {
> > + vdds-supply = <&vreg_l5a_0p88>;
> > + phy-type = <PHY_TYPE_CPHY>;
> > + status = "okay";
> > +};
> > +
> > +&dsi1 {
> > + vdda-supply = <&vreg_l9a_1p2>;
> > + qcom,dual-dsi-mode;
> > + qcom,sync-dual-dsi;
> > + /* DSI1 is slave, so use DSI0 clocks */
> > + assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
> > + status = "okay";
> > +};
> > +
> > +&dsi1_out {
> > + data-lanes = <0 1 2>;
> > + remote-endpoint = <&panel_in_1>;
> > +};
> > +
> > +&dsi1_phy {
> > + vdds-supply = <&vreg_l5a_0p88>;
> > + phy-type = <PHY_TYPE_CPHY>;
> > + status = "okay";
> > +};
> > +
> > &gmu {
> > status = "okay";
> > };
> > @@ -533,6 +602,10 @@ fuel-gauge@55 {
> > };
> > };
> >
> > +&mdss {
> > + status = "okay";
> > +};
> > +
> > &pcie0 {
> > status = "okay";
> > };
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add Xiaomi Mi Pad 5 Pro BOE variant
2023-03-22 17:15 [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Jianhua Lu
2023-03-22 17:15 ` [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node Jianhua Lu
@ 2023-03-22 17:15 ` Jianhua Lu
2023-03-22 18:17 ` Konrad Dybcio
2023-03-22 17:15 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant Jianhua Lu
2023-03-22 18:08 ` [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Krzysztof Kozlowski
3 siblings, 1 reply; 10+ messages in thread
From: Jianhua Lu @ 2023-03-22 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Jianhua Lu
Add support for the Xiaomi Mi Pad 5 Pro BOE variant. The BOE variant
uses BOE Technology panel.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
Changes in v2:
- Get rid of sm8250-xiaomi-elish.dtb
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sm8250-xiaomi-elish-boe.dts | 18 ++++++++++++++++++
2 files changed, 19 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 8d2b3c57a4a8..808f46947661 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
new file mode 100644
index 000000000000..8b2ae39950ff
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023 Jianhua Lu <lujianhua000@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "sm8250-xiaomi-elish-common.dtsi"
+
+/ {
+ model = "Xiaomi Mi Pad 5 Pro (BOE)";
+ compatible = "xiaomi,elish", "qcom,sm8250";
+};
+
+&display_panel {
+ compatible = "xiaomi,elish-boe-nt36523";
+ status = "okay";
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 3/4] arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add Xiaomi Mi Pad 5 Pro BOE variant
2023-03-22 17:15 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add Xiaomi Mi Pad 5 Pro BOE variant Jianhua Lu
@ 2023-03-22 18:17 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2023-03-22 18:17 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 22.03.2023 18:15, Jianhua Lu wrote:
> Add support for the Xiaomi Mi Pad 5 Pro BOE variant. The BOE variant
> uses BOE Technology panel.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
Squash with [1/4]
Konrad
> Changes in v2:
> - Get rid of sm8250-xiaomi-elish.dtb
>
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm8250-xiaomi-elish-boe.dts | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 8d2b3c57a4a8..808f46947661 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
> new file mode 100644
> index 000000000000..8b2ae39950ff
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023 Jianhua Lu <lujianhua000@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sm8250-xiaomi-elish-common.dtsi"
> +
> +/ {
> + model = "Xiaomi Mi Pad 5 Pro (BOE)";
> + compatible = "xiaomi,elish", "qcom,sm8250";
> +};
> +
> +&display_panel {
> + compatible = "xiaomi,elish-boe-nt36523";
> + status = "okay";
> +};
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant
2023-03-22 17:15 [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Jianhua Lu
2023-03-22 17:15 ` [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node Jianhua Lu
2023-03-22 17:15 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add Xiaomi Mi Pad 5 Pro BOE variant Jianhua Lu
@ 2023-03-22 17:15 ` Jianhua Lu
2023-03-22 18:17 ` Konrad Dybcio
2023-03-22 18:08 ` [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Krzysztof Kozlowski
3 siblings, 1 reply; 10+ messages in thread
From: Jianhua Lu @ 2023-03-22 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Jianhua Lu
Add support for the Xiaomi Mi Pad 5 Pro CSOT variant. The CSOT variant
uses China Star Optoelectronics Technology (CSOT) panel.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
No changes in v2
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sm8250-xiaomi-elish-csot.dts | 18 ++++++++++++++++++
2 files changed, 19 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 808f46947661..b755b198cfb7 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -184,6 +184,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-csot.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
new file mode 100644
index 000000000000..a4d5341495cf
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023 Jianhua Lu <lujianhua000@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "sm8250-xiaomi-elish-common.dtsi"
+
+/ {
+ model = "Xiaomi Mi Pad 5 Pro (CSOT)";
+ compatible = "xiaomi,elish", "qcom,sm8250";
+};
+
+&display_panel {
+ compatible = "xiaomi,elish-csot-nt36523";
+ status = "okay";
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant
2023-03-22 17:15 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant Jianhua Lu
@ 2023-03-22 18:17 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2023-03-22 18:17 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 22.03.2023 18:15, Jianhua Lu wrote:
> Add support for the Xiaomi Mi Pad 5 Pro CSOT variant. The CSOT variant
> uses China Star Optoelectronics Technology (CSOT) panel.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> No changes in v2
>
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm8250-xiaomi-elish-csot.dts | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 808f46947661..b755b198cfb7 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -184,6 +184,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-csot.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
> new file mode 100644
> index 000000000000..a4d5341495cf
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023 Jianhua Lu <lujianhua000@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sm8250-xiaomi-elish-common.dtsi"
> +
> +/ {
> + model = "Xiaomi Mi Pad 5 Pro (CSOT)";
> + compatible = "xiaomi,elish", "qcom,sm8250";
> +};
> +
> +&display_panel {
> + compatible = "xiaomi,elish-csot-nt36523";
> + status = "okay";
> +};
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi
2023-03-22 17:15 [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Jianhua Lu
` (2 preceding siblings ...)
2023-03-22 17:15 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant Jianhua Lu
@ 2023-03-22 18:08 ` Krzysztof Kozlowski
2023-03-23 0:21 ` Jianhua Lu
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-22 18:08 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 22/03/2023 18:15, Jianhua Lu wrote:
> There are two panel variants of xiaomi-elish, BOE and CSOT panels.
> In order to support both panels, so move elish dts to common dtsi.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> Changes in v2:
> - Remove sm8250-xiaomi-elish.dtb to avoid build failure.
>
> arch/arm64/boot/dts/qcom/Makefile | 1 -
> ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ----
> 2 files changed, 5 deletions(-)
> rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 1a29403400b7..8d2b3c57a4a8 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb
This builds, but it is a loss of functionality. Instead the board should
be renamed here to one of your final namings, e.g. boe.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi
2023-03-22 18:08 ` [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi Krzysztof Kozlowski
@ 2023-03-23 0:21 ` Jianhua Lu
0 siblings, 0 replies; 10+ messages in thread
From: Jianhua Lu @ 2023-03-23 0:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On Wed, Mar 22, 2023 at 07:08:52PM +0100, Krzysztof Kozlowski wrote:
> On 22/03/2023 18:15, Jianhua Lu wrote:
> > There are two panel variants of xiaomi-elish, BOE and CSOT panels.
> > In order to support both panels, so move elish dts to common dtsi.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > Changes in v2:
> > - Remove sm8250-xiaomi-elish.dtb to avoid build failure.
> >
> > arch/arm64/boot/dts/qcom/Makefile | 1 -
> > ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ----
> > 2 files changed, 5 deletions(-)
> > rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 1a29403400b7..8d2b3c57a4a8 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb
> > -dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb
>
> This builds, but it is a loss of functionality. Instead the board should
> be renamed here to one of your final namings, e.g. boe.
Acked
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 10+ messages in thread