From: neil.armstrong@linaro.org
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jbrunet@baylibre.com, jirislaby@kernel.org, khilman@baylibre.com,
martin.blumenstingl@googlemail.com
Cc: kelvin.zhang@amlogic.com, xianwei.zhao@amlogic.com,
kernel@sberdevices.ru, rockosov@gmail.com,
linux-amlogic@lists.infradead.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/7] tty: serial: meson: use dev_err_probe
Date: Thu, 6 Jul 2023 08:59:07 +0200 [thread overview]
Message-ID: <3beac94b-1a82-df36-1390-8321aa1a8e57@linaro.org> (raw)
In-Reply-To: <20230705181833.16137-2-ddrokosov@sberdevices.ru>
On 05/07/2023 20:18, Dmitry Rokosov wrote:
> Use dev_err_probe() helper for error checking and standard logging.
> It makes the driver's probe() function a little bit shorter.
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
> drivers/tty/serial/meson_uart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 2501db5a7aaf..bca54f3d92a1 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -726,8 +726,8 @@ static int meson_uart_probe(struct platform_device *pdev)
> of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
>
> if (meson_ports[pdev->id]) {
> - dev_err(&pdev->dev, "port %d already allocated\n", pdev->id);
> - return -EBUSY;
> + return dev_err_probe(&pdev->dev, -EBUSY,
> + "port %d already allocated\n", pdev->id);
> }
>
> port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), GFP_KERNEL);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-07-06 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 18:18 [PATCH v2 0/7] tty: serial: meson: support ttyS devname Dmitry Rokosov
2023-07-05 18:18 ` [PATCH v2 1/7] tty: serial: meson: use dev_err_probe Dmitry Rokosov
2023-07-06 6:59 ` neil.armstrong [this message]
2023-07-05 18:18 ` [PATCH v2 2/7] tty: serial: meson: redesign the module to platform_driver Dmitry Rokosov
2023-07-06 6:59 ` neil.armstrong
2023-07-05 18:18 ` [PATCH v2 3/7] tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs Dmitry Rokosov
2023-07-06 7:08 ` neil.armstrong
2023-07-05 18:18 ` [PATCH v2 4/7] tty: serial: meson: introduce separate uart_data for S4 SoC family Dmitry Rokosov
2023-07-06 7:09 ` neil.armstrong
2023-07-05 18:18 ` [PATCH v2 5/7] tty: serial: meson: add independent uart_data for A1 " Dmitry Rokosov
2023-07-06 7:09 ` neil.armstrong
2023-07-05 18:18 ` [PATCH v2 6/7] dt-bindings: serial: amlogic,meson-uart: support Amlogic A1 Dmitry Rokosov
2023-07-05 21:10 ` Conor Dooley
2023-07-06 17:57 ` Rob Herring
2023-07-05 18:18 ` [PATCH v2 7/7] arm64: dts: meson: a1: change uart compatible string Dmitry Rokosov
2023-07-06 7:10 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3beac94b-1a82-df36-1390-8321aa1a8e57@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=kelvin.zhang@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).