From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marius.Cristea@microchip.com, jic23@kernel.org, lars@metafoo.de,
robh+dt@kernel.org
Cc: conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC
Date: Wed, 19 Jul 2023 19:20:03 +0200 [thread overview]
Message-ID: <3bff674f-791b-74bd-da1c-13b6596ea276@linaro.org> (raw)
In-Reply-To: <3d5cc96388f27b1f03f5a1d3bee7113686548e43.camel@microchip.com>
On 19/07/2023 17:40, Marius.Cristea@microchip.com wrote:
> Hi Krzysztof,
>
>>> +
>>> +patternProperties:
>>> + "^channel@([0-9]|([1-7][0-9]))$":
>>> + $ref: adc.yaml
>>> + type: object
>>
>> Missing unevaluatedProperties: false.
>>
>> Open other bindings and look how it is done there.
>>
>>> + description: Represents the external channels which are
>>> connected to the ADC.
>>> +
>>> + properties:
>>> + reg:
>>> + description: The channel number in single-ended and
>>> differential mode.
>>> + minimum: 0
>>> + maximum: 79
>>> +
>>> + diff-channels: true
>>
>> Why? Drop, unless you want to say there all other ADC properties are
>> invalid for this type of device (device, not driver!).
>>
>>> +
>>> + required:
>>> + - reg
>>
>>
>
> All other ADC properties are valid.
So drop what I questioned.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-19 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 15:00 [PATCH v2 0/2] Adding support for Microchip MCP3564 ADC family marius.cristea
2023-07-14 15:00 ` [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC marius.cristea
2023-07-15 10:28 ` Conor Dooley
2023-07-16 15:19 ` Jonathan Cameron
2023-07-18 9:24 ` Marius.Cristea
2023-07-20 18:38 ` Jonathan Cameron
2023-07-17 6:25 ` Krzysztof Kozlowski
2023-07-19 15:40 ` Marius.Cristea
2023-07-19 17:20 ` Krzysztof Kozlowski [this message]
2023-07-14 15:00 ` [PATCH v2 2/2] iio: adc: adding support for " marius.cristea
2023-07-16 15:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bff674f-791b-74bd-da1c-13b6596ea276@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Marius.Cristea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).