From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022FBC001B0 for ; Wed, 19 Jul 2023 17:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjGSRUJ (ORCPT ); Wed, 19 Jul 2023 13:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbjGSRUI (ORCPT ); Wed, 19 Jul 2023 13:20:08 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 927D6189 for ; Wed, 19 Jul 2023 10:20:07 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fbdfda88f4so65784055e9.1 for ; Wed, 19 Jul 2023 10:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689787206; x=1692379206; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tryqWINbuaEc88iTrVyHMsqPdFzMjV4Usg4i5lKUzxg=; b=BFhym1rSHwx5Or+Pii0FqmZpyk6fWpZjZKuo/9KNL6cngJ1bY3HlQ6rlV5EcJyFRLw 31K4RtM628f51v3S8c5Qi0K+lV2LP3yEBUDlYdKQn5eZ1TR5bO0zO4gWNUqeMYgLprrV vsj44XHkZLFHVH7Lhy1WesZcIkZQIaceksaTSd13I8/6O1HJMGeEhvgpy6H/EzHjdzoZ j8BPZjt1gCWP0rBB0a5szfWaRB71TzqswPLfbYyCb/6N/CQ6Cu6X5jO8liFDTkAIa4Ja ywl1hQ9WidgV5njtS2Ml2ZnGxg8JPyfLbqHf+t+NNiz6J5eWzBNa4yr/dQEH8Ul2zmMk xSOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689787206; x=1692379206; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tryqWINbuaEc88iTrVyHMsqPdFzMjV4Usg4i5lKUzxg=; b=VAmRxRFHsbhiTYFSMlMrwWEzshlIqMmnZcUP+0YUvI+nR1inoDM8H/1IopT8OxiY0l wogbVlTmsyp0LyFsmTHjvneiGx1DoY5LIOuNngQfSwZbQRWhV7ej0DUMXyk6OI3OUBFZ gSHstyEiT4l4qTTPMNk3w23ti9mtU7nvZiEfXoakYZ/1/HLOpd4OWsQQiCcH3YXF1RBM LCpEYDpfPYjT6sYYvxskLlgb695yPoAstS4h1VnMo/PNBt2VtL5GsSfpm8M6WXGBC+Dy NqmrCFJyplvDZ4Xzstn/Fra7ocMQDLheRCUjs0heDuchDXT7TOWcQhD4wgkuh8/cdW7E jwJQ== X-Gm-Message-State: ABy/qLaIyOGu22KWtxe5a/1auK0TyKEDCrBqDlxqhJ3naLbA5NFc7JRt 0F4KzJ9t9X2G29gp5CpTJ0KKpw== X-Google-Smtp-Source: APBJJlERLjXGvjJSJjU1AMkKL+pqkSk/vqOk8N4LMFX++aVs21FOCvyEtjc8FdvLbnLuf1/njZiDZw== X-Received: by 2002:a05:600c:2113:b0:3fb:ba04:6d5d with SMTP id u19-20020a05600c211300b003fbba046d5dmr49523wml.12.1689787206013; Wed, 19 Jul 2023 10:20:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c204300b003fc3b03e41esm2485270wmg.1.2023.07.19.10.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 10:20:05 -0700 (PDT) Message-ID: <3bff674f-791b-74bd-da1c-13b6596ea276@linaro.org> Date: Wed, 19 Jul 2023 19:20:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC Content-Language: en-US To: Marius.Cristea@microchip.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org Cc: conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230714150051.637952-1-marius.cristea@microchip.com> <20230714150051.637952-2-marius.cristea@microchip.com> <3d5cc96388f27b1f03f5a1d3bee7113686548e43.camel@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <3d5cc96388f27b1f03f5a1d3bee7113686548e43.camel@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/07/2023 17:40, Marius.Cristea@microchip.com wrote: > Hi Krzysztof, > >>> + >>> +patternProperties: >>> +  "^channel@([0-9]|([1-7][0-9]))$": >>> +    $ref: adc.yaml >>> +    type: object >> >> Missing unevaluatedProperties: false. >> >> Open other bindings and look how it is done there. >> >>> +    description: Represents the external channels which are >>> connected to the ADC. >>> + >>> +    properties: >>> +      reg: >>> +        description: The channel number in single-ended and >>> differential mode. >>> +        minimum: 0 >>> +        maximum: 79 >>> + >>> +      diff-channels: true >> >> Why? Drop, unless you want to say there all other ADC properties are >> invalid for this type of device (device, not driver!). >> >>> + >>> +    required: >>> +      - reg >> >> > > All other ADC properties are valid. So drop what I questioned. Best regards, Krzysztof