From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-remoteproc@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Support i.MX8MN/P MMIO
Date: Mon, 10 Jul 2023 23:54:19 +0200 [thread overview]
Message-ID: <3c01e341-01fb-ee7e-a295-db2fbbd1835c@denx.de> (raw)
In-Reply-To: <20230710150942.GA1979021-robh@kernel.org>
On 7/10/23 17:09, Rob Herring wrote:
> On Mon, Jul 10, 2023 at 11:10:48AM +0200, Marek Vasut wrote:
>> On 7/10/23 10:13, Krzysztof Kozlowski wrote:
>>> On 08/07/2023 01:26, Marek Vasut wrote:
>>>> The MX8M CM7 boot via SMC call is problematic, since not all versions
>>>> of ATF support this interface. Document MMIO support used to boot the
>>>> CM7 on MX8MN/MP instead and discern MMIO interface using DT compatible
>>>> string. Document GPR register syscon phandle which is required by the
>>>> MMIO interface too.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> ---
>>>> Note that the MMIO being discerned using compatible string is similar
>>>> approach to "st,stm32mp1-rcc" vs "st,stm32mp1-rcc-secure".
>>>> ---
>>>
>>> Same hardware should not have two compatibles, depending on the bus it is.
>>
>> Yes, I know, but for whatever reason the ST does, so I picked the same
>> approach here. What else would you suggest, boolean properly like Peng wrote
>> ?
>>
>> The compatible is also easier to handle on driver level, at least in Linux,
>> see 2/2 .
>
> IIRC, in the ST case, the programming model presented to the OS is
> different, so different compatibles. Seems like this case is similar.
>
> However, can't you try and SMC call and if it fails, use MMIO?
They already do that to determine the CM4 CPU state, and if the SMC
errors out, then they indicate the CPU is detached. So no, not to my
knowledge, which indeed would be my preferred solution though.
next prev parent reply other threads:[~2023-07-10 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 23:26 [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Support i.MX8MN/P MMIO Marek Vasut
2023-07-07 23:26 ` [PATCH 2/2] remoteproc: imx_rproc: Switch iMX8MN/MP from SMCCC to MMIO Marek Vasut
2023-07-17 17:10 ` Mathieu Poirier
2023-07-20 12:41 ` Marek Vasut
2023-07-10 1:20 ` [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Support i.MX8MN/P MMIO Peng Fan
2023-07-10 8:13 ` Krzysztof Kozlowski
2023-07-10 9:10 ` Marek Vasut
2023-07-10 15:09 ` Rob Herring
2023-07-10 21:54 ` Marek Vasut [this message]
2023-07-10 15:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c01e341-01fb-ee7e-a295-db2fbbd1835c@denx.de \
--to=marex@denx.de \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).