From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: convert everest,es7241.txt to dt-schema
Date: Wed, 12 Jun 2024 08:49:01 +0200 [thread overview]
Message-ID: <3c02302b-84e8-4064-b3cf-d8f28c7ff9ac@kernel.org> (raw)
In-Reply-To: <20240611-topic-amlogic-upstream-bindings-convert-everest-v1-1-a7f9b4c9005c@linaro.org>
On 11/06/2024 11:19, Neil Armstrong wrote:
> +required:
> + - compatible
> + - VDDP-supply
> + - VDDA-supply
> + - VDDD-supply
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
If there is going to be new version:
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + codec-0 {
codec {
> + compatible = "everest,es7241";
> + #sound-dai-cells = <0>;
> + reset-gpios = <&gpio1 15 0>;
and use define for the GPIO flag (need also to include header).
No need to resend just for this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-12 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 9:19 [PATCH 0/2] ASoC: dt-bindings: convert everest,es7134.txt & everest,es7241.txt to dt-schema Neil Armstrong
2024-06-11 9:19 ` [PATCH 1/2] ASoC: dt-bindings: convert " Neil Armstrong
2024-06-12 6:49 ` Krzysztof Kozlowski [this message]
2024-06-11 9:19 ` [PATCH 2/2] ASoC: dt-bindings: convert everest,es7134.txt " Neil Armstrong
2024-06-12 6:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c02302b-84e8-4064-b3cf-d8f28c7ff9ac@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).