From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71BBF382F15; Mon, 6 Jul 2026 15:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783352014; cv=none; b=V9k56BbInpSI8lYGXXhidf72zo50rPuBP9tUBKdZLpyI+U2hKMIp/46dCXtUKtU5VGSHgl0CGp1LoA7rD0lOZ9qm9alEJy8cNAAYsDCCzZWZoT8FmI+/TpgRXOZKNFqssABOEqUW8fZKF0fTXZhWODppJ1+7r1GGPMwxM6xe8Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783352014; c=relaxed/simple; bh=79XR6LLkQOvDhG3XaOf38KRyBvo2ze8KBBsxlXH2wlo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EBaEkksJtVRdRJo20FRTVPFooU5Di+IwawzAjREb18hj8p1c5wpcicceucJDnNiL/o0239gIjMioYqRU/xAiEoOslZPvAd5BeDtOviK7Xwb7EoN76qmNFkrQLc98hRMEgu1WA68FLLnPkwdR7b7cTRYNh/uAme2Vc4NVmjJywWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cm4NDubI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cm4NDubI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD6781F00A3D; Mon, 6 Jul 2026 15:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783352013; bh=VVuPxC7uyEneDyvS5EHRQOIkZVo/98jg4y9T2Of8IzY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=cm4NDubIGi5lMMrbvsX4BNGUAYpbItTFifgO48joYFY6TNVylUUKMkaNcgqZ3cGxm Kev2jo/w+2tZXKgvRrazEZ3XovZwMK8GPwz7mrvJgYSwzR6RHx9eyCvjYG3arwz+6l mpHer9Jjx9/jmxvc59dxA30NNq/Z8USK9cY0teR5DT2hgn/0G2ji8B1V1zWycQ5mb3 j9jbEGqb4HE/C/WQ4keHNe2tI6tbuzr9239PWsA2S2Y1w4AAUztWFzzMz1/kZYDqmO tL2LLT8WVFLI5Eas4owSwrA126AJK9txv9K8OLv0g+X7BZLjMqF/eAaIbLPqJZ/hdi fjnruC4DUCtQw== Message-ID: <3c035b12-46df-48e6-b7e0-7634da57a18b@kernel.org> Date: Mon, 6 Jul 2026 17:33:24 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel To: Dmitry Baryshkov Cc: Arpit Saini , Nabige Aala , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260706-shikra-dt-changes-v2-0-56fcd1659ea4@oss.qualcomm.com> <20260706-shikra-dt-changes-v2-2-56fcd1659ea4@oss.qualcomm.com> <7815e3ac-30c7-4564-9a7a-6a1ecb9278c8@kernel.org> <52b7ee6e-bd99-4555-8a49-6cdde1331714@oss.qualcomm.com> <23580f8f-ba25-4dd7-a2d3-f2df9bc7303d@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/07/2026 15:48, Dmitry Baryshkov wrote: > On Mon, Jul 06, 2026 at 11:19:59AM +0200, Krzysztof Kozlowski wrote: >> On 06/07/2026 10:52, Arpit Saini wrote: >>> Hi Krzyszto, >>> >>> On 7/6/2026 12:03 PM, Krzysztof Kozlowski wrote: >>>> On 06/07/2026 08:04, Nabige Aala wrote: >>>>> + lcd_bias: regulator-lcd-bias { >>>>> + compatible = "regulator-fixed"; >>>>> + regulator-name = "lcd_bias"; >>>>> + vin-supply = <&vph_pwr>; >>>>> + gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>; >>>>> + enable-active-high; >>>>> + pinctrl-0 = <&lcd_bias_en>; >>>>> + pinctrl-names = "default"; >>>>> + }; >>>>> + >>>>> + vph_pwr: vph-pwr-regulator { >>>> Why so inconsistent names? >>>> >>>> Anyway, drop the node, not used and not controllable. >>> >>> As per the schematics of LCD display Bias driver , vph_pwr is used as >>> vin for that. >>> >>> So I created vph_pwr , if you want , I can drop that in next patchset. >> >> But vph_pwr gets its own supply from main power, which gets from socket, >> which gets from building wiring, which gets from a power plant... Drop >> the node, as I said, it is redundant in DTS. > > Just for my understanding. Is it fine if it gets used as an input to > PMICs? Yes, if it is used to any device as supply, then it is fine. Best regards, Krzysztof