From: Krzysztof Kozlowski <krzk@kernel.org>
To: Siratul Islam <email@sirat.me>,
andy@kernel.org, geert@linux-m68k.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637
Date: Tue, 13 Jan 2026 17:24:45 +0100 [thread overview]
Message-ID: <3c25d80a-460d-481d-82ae-7d8046750a22@kernel.org> (raw)
In-Reply-To: <20260113040242.19156-3-email@sirat.me>
On 13/01/2026 05:02, Siratul Islam wrote:
> +title: TM1637 7-segment LED display controller
> +
> +maintainers:
> + - Siratul Islam <email@sirat.me>
> +
> +description:
> + The TM1637 is a 7-segment LED display controller with a two-wire serial
> + interface. It can drive up to 4 digits and includes brightness control.
> +
> +properties:
> + compatible:
> + const: titanmec,tm1637
> +
> + clk-gpios:
> + maxItems: 1
> + description: GPIO for clock line
> +
> + dio-gpios:
> + maxItems: 1
> + description: GPIO for data input/output line
So you are bitbanging in the kernel? This looks too tightly coupled to
the implementation. If this is some sort of standard interface, I would
expect following standard bus-child relationship, like i2c, spi, serial
or even 1-wire.
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-13 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 4:02 [PATCH 0/4] auxdisplay: Add support for TM1637 7-segment display driver Siratul Islam
2026-01-13 4:02 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add titanmec Siratul Islam
2026-01-13 16:22 ` Krzysztof Kozlowski
2026-01-13 4:02 ` [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637 Siratul Islam
2026-01-13 16:24 ` Krzysztof Kozlowski [this message]
2026-01-13 4:02 ` [PATCH 3/4] auxdisplay: tm1637: Add driver for TM1637 Siratul Islam
2026-01-13 7:52 ` Andy Shevchenko
2026-01-13 9:42 ` Sirat
2026-01-13 9:47 ` Andy Shevchenko
2026-01-13 14:57 ` kernel test robot
2026-01-13 4:02 ` [PATCH 4/4] MAINTAINERS: Add entry " Siratul Islam
2026-01-13 6:54 ` [PATCH 0/4] auxdisplay: Add support for TM1637 7-segment display driver Andy Shevchenko
2026-01-13 6:56 ` Andy Shevchenko
[not found] ` <CANn+LWLECPY-F_fsDg1VxbjJdN-pLnkRpQn4OEFSa6yiARoU9A@mail.gmail.com>
2026-01-13 9:41 ` Andy Shevchenko
2026-01-13 9:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c25d80a-460d-481d-82ae-7d8046750a22@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=email@sirat.me \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox