From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E571465BE for ; Sat, 7 Dec 2024 12:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733574293; cv=none; b=gRZ0Pr3/o20qqy2mFgyqGnWMPyaRVMP+4zyBbuIBTzXetJzaLtYGDBnoD38tr+RcdyFfG6aQe0WhaWjEItW8YJoSNUpImsQ1ebTmnmGRG70ISPaxd65aHo+dthN2iLz9BwzuntjCe1d7V+T2j+wgTC2Kq2VkEUeuLlD9HZaQIVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733574293; c=relaxed/simple; bh=Imkwjvr8OjZv9fFVDAgn9vb0dZxjoY+OVBVdlvMWILM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YAKfNPrRQpMy9i78BMvuoYxHoP3yiSaqpgS9obFkzh5YI5wDRqW/FA1TEN4qoB3/nUNHtADZ8O+nqsMnzgLshl7uhDm44H0mbG/Z+fVZ39Mz/sQeGWdseWGR2oHeNadjfMXYM5Lk8VW+AB6onor4fmta9IGYzCLWDWh68OvBXVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nJZBlDqZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nJZBlDqZ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B74lmvd002426 for ; Sat, 7 Dec 2024 12:24:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pQ1BefPPZjsefk+Q7pM32V79KkOTPD7KhjkHUZEtT/k=; b=nJZBlDqZ+b9Yua5E mXTXJlvIv05Mqj5rN1UIOjD4GjbItQeFae8dq6PhSauWIDEcP3Axb7wFROEpYbNG x6wylpHx9NzKmL2DhQIXod/nA3HJ/D9sS1ZDNeAfmQs9C+0tc8DLN26DSJf1lfFw 2J/kdJppCP4G2hl9y7to0N1gxxg3VvQXAPzsi/apeHsa42MQVNqfGh9bG/ZG0sWB SUa4XD5o2nZvdK/JFHpmrnOQSjfK1tyax6e8rT/fj9Iksxk8XkQGGTJhO2dRO0f6 50q1XvTss7q8qFL6LalhOJ3k3cMOKvwiTgzKinzRgvhMm+yxC8wle2gDFjRatLeL nTlpuQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43cfn8rgvg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 07 Dec 2024 12:24:50 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6d8824c96cdso8670756d6.2 for ; Sat, 07 Dec 2024 04:24:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733574289; x=1734179089; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pQ1BefPPZjsefk+Q7pM32V79KkOTPD7KhjkHUZEtT/k=; b=d7rKtW1pMToVBBR5TmuNRjouFVPV55vyvRjECVVY85o2jyOe5le99HmeIhlbNRZ8Ss qup0DGVtYhSX4KXUSEd/O8gSm0xAgAV6+OQ4nra6EcIK+xMdlNcqGLsPlzSKK5mlR4HG t2GptIrm8zOo+QoU0SXbeS9gw/t0/hvGdeAq9QQskXzq4ix8l1zhbPXAzsjj6W8QvcKK CokiHAIFgC/WAS4f8S+wkH9Le6wEZPdimuOIcvpn4bFvn+agD2dIEEoNQpzpXwKYf1lv 6+CifVwD2dXIGMNicP1pkxyzAh7iy3O3WPs8QbWJwztmR/2Jj80F5F48S1faMBc7CYl+ n8zA== X-Forwarded-Encrypted: i=1; AJvYcCXbvvtiMD7qADBd6CmpkEmjDi4g6ewrgSy7QbzkteuCC8dPTrp0he2FkFAK9OHyFosrm28gtUcNeLGs@vger.kernel.org X-Gm-Message-State: AOJu0YwURX2/hWYHXpanKDgEZ+yBMq6GFmNBK+13/57k4dzp5mI5b2Vz ZiE8Y5Xavx65iweIW73K5xf7LfR7wbZdPKa5pHousHKv/Au4NUVjEsRK6RCaMudzzxq5NTBaRcO j277xC90O0Ep5HSPftcKx/vfw2rExYzKuBXuf2Ug1iA2xxbybd9rTnamkCPk2 X-Gm-Gg: ASbGncuDmuI2obTYhFfoqZFCvhJK+Osk3HjTVChM4anNITZSPS7NeaT1Su3YMYjE/fS M5nMoimEYSOBgTeXddk9hTpb20xcgnt/iUVyLInNaa6vDf/WBTBFsvmgvw33b9VuZPW1DZiYhRH R7epwuMg8O2lhbmtdeonhaV8PYpQFZgnu2JGx1EPww7SlQ1AUeIGIS7PZ9i78ITmjJeOmbanDXH ANXPJgcpcofkmfUjLl1CdZhFQ9oEJxJxqF+3GEmd1ucnF/y8jFhxLvuHPbeOiGHrwLVgt7qzL1T J0AJRaJwKUqV01/k8MLpoxGUzW75TZ8= X-Received: by 2002:a05:620a:2681:b0:7b1:4579:80fd with SMTP id af79cd13be357-7b6bcaf410dmr314489685a.7.1733574289379; Sat, 07 Dec 2024 04:24:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFq8U8Ty2ix6xok3zzJyL1MAVWdr2aIcau1ywhGnswjMwOh+jLaNEvEH5AowyHkAWxYwSII3Q== X-Received: by 2002:a05:620a:2681:b0:7b1:4579:80fd with SMTP id af79cd13be357-7b6bcaf410dmr314486985a.7.1733574288928; Sat, 07 Dec 2024 04:24:48 -0800 (PST) Received: from [192.168.212.163] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa625e92a79sm380101066b.43.2024.12.07.04.24.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Dec 2024 04:24:48 -0800 (PST) Message-ID: <3c34afac-478d-47a6-97df-cc45415f6411@oss.qualcomm.com> Date: Sat, 7 Dec 2024 13:24:45 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] arm64: dts: qcom: x1e80100: Add CAMSS block definition To: Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vladimir Zapolskiy , Jagadeesh Kona , Konrad Dybcio Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org References: <20241119-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v1-0-54075d75f654@linaro.org> <20241119-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v1-6-54075d75f654@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241119-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v1-6-54075d75f654@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kYEr-4WBAUWxQTHQBQ62xdFdVlelXsjJ X-Proofpoint-ORIG-GUID: kYEr-4WBAUWxQTHQBQ62xdFdVlelXsjJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412070103 On 19.11.2024 2:10 PM, Bryan O'Donoghue wrote: > Add dtsi to describe the xe180100 CAMSS block > > 4 x CSIPHY > 2 x CSID > 2 x CSID Lite > 2 x IFE > 2 x IFE Lite > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 180 +++++++++++++++++++++++++++++++++ > 1 file changed, 180 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index c19754fdc7e0fa4f674ce19f813db77fe2615cf3..f23352493cb270c0fdc3c42add032286601db1e9 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -4730,6 +4730,186 @@ cci1_i2c1: i2c-bus@1 { > }; > }; > > + camss: camss@ac62000 { > + compatible = "qcom,x1e80100-camss"; > + > + reg = <0 0x0acb7000 0 0x2000>, > + <0 0x0acb9000 0 0x2000>, > + <0 0x0acbb000 0 0x2000>, > + <0 0x0acb6000 0 0x1000>, > + <0 0x0ace4000 0 0x1000>, > + <0 0x0ace6000 0 0x1000>, > + <0 0x0ace8000 0 0x1000>, > + <0 0x0acec000 0 0x4000>, > + <0 0x0acc7000 0 0x2000>, > + <0 0x0accb000 0 0x2000>, > + <0 0x0ac62000 0 0x2a00>, > + <0 0x0ac71000 0 0x2a00>; > + > + reg-names = "csid0", Please remove the blank lines between x and x-names > + "csid1", > + "csid2", > + "csid_wrapper", This doesn't seem to match what the commit msg promises [...] > + > + iommus = <&apps_smmu 0x800 0x60>, > + <&apps_smmu 0x820 0x60>, > + <&apps_smmu 0x840 0x60>, > + <&apps_smmu 0x860 0x60>, > + <&apps_smmu 0x1800 0x60>, > + <&apps_smmu 0x1820 0x60>, > + <&apps_smmu 0x1840 0x60>, > + <&apps_smmu 0x1860 0x60>, > + <&apps_smmu 0x18a0 0x00>, > + <&apps_smmu 0x18e0 0x00>, > + <&apps_smmu 0x1900 0x00>, > + <&apps_smmu 0x1980 0x20>, > + <&apps_smmu 0x19a0 0x20>; >>> for pair in a: ... print(hex(pair[0] & ~pair[1])) ... 0x800 0x800 0x800 0x800 0x1800 0x1800 0x1800 0x1800 0x18a0 0x18e0 0x1900 0x1980 0x1980 Please remove the duplicates > + > + interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_CAMERA_CFG 0>, QCOM_ICC_TAG_ACTIVE_ONLY > + <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_CAMNOC_ICP 0 &mc_virt SLAVE_EBI1 0>; QCOM_ICC_TAG_ALWAYS Konrad