public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Finley Xiao" <finley.xiao@rock-chips.com>,
	"kernel test robot" <lkp@intel.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: oe-kbuild-all@lists.linux.dev, Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"
Date: Sun, 18 May 2025 12:36:50 +0200	[thread overview]
Message-ID: <3c3d0020-1dce-4364-a0a1-7c35b21e93de@kernel.org> (raw)
In-Reply-To: <3983362.fW5hKsROvD@diego>

On 16/05/2025 22:10, Heiko Stübner wrote:
> Am Donnerstag, 15. Mai 2025, 16:04:20 Mitteleuropäische Sommerzeit schrieb kernel test robot:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   bdd609656ff5573db9ba1d26496a528bdd297cf2
>> commit: ceb6ef1ea9002669afc0e1ef258e530d3c05d91a [9473/11093] arm64: dts: rockchip: Add RK3562 evb2 devicetree
>> config: arm64-randconfig-2052-20250513 (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/config)
>> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
>> dtschema version: 2025.3.dev27+g32749b3
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505150745.PQT9TLYX-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202505150745.PQT9TLYX-lkp@intel.com/
>>
>> dtcheck warnings: (new ones prefixed by >>)
>>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000"
>>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi:1115.20-1181.5: Warning (simple_bus_reg): /soc/pinctrl: missing or empty reg/ranges property
> 
> hmm, I don't really understand this error message.
> 
> From a practical point, the dtschema-version I have installed is
> 2025.3.dev27+g32749b3, which is the topmost commit from
> may-13th.
> 
> Running the dtbscheck on the rk3562-evb-v10.dtb on the full
> linux-next from today, yields no errors.

These are standard dtc warnings.

> 
> Checking out the specific commit ceb6ef1ea90026 brings up the
> errors from below [1], because they come from different trees.
> 
> 
> But in no cases does dtbscheck complain about the PCI memory regions.
> 
> 
> The PCIe controller in question of course has 3 memory regions
> 	reg = <0x0 0xfe000000 0x0 0x400000>,
> 	      <0x0 0xff500000 0x0 0x10000>,
> 	      <0x0 0xfc000000 0x0 0x100000>;
> 	reg-names = "dbi", "apb", "config";
> 
> and currently the node-name mimics the "apb" memory region.
> Should it always use the first one?

I don't understand where is the problem. The warning tells you: unit
address is not correct. Fix the unit address to match reg.


About second warning: that's also kind of already existing issue and
fixed in multiple places. Don't put non-MMIO nodes in simple-bus, like
soc, because it is not correct. simple-bus is for MMIO nodes.

Best regards,
Krzysztof

  reply	other threads:[~2025-05-18 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202505150745.PQT9TLYX-lkp@intel.com>
2025-05-16 20:10 ` [linux-next:master 9473/11093] arch/arm64/boot/dts/rockchip/rk3562.dtsi:624.26-675.5: Warning (simple_bus_reg): /soc/pcie@ff500000: simple-bus unit address format error, expected "fe000000" Heiko Stübner
2025-05-18 10:36   ` Krzysztof Kozlowski [this message]
2025-05-18 13:57     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c3d0020-1dce-4364-a0a1-7c35b21e93de@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox