From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71025C4332F for ; Thu, 22 Dec 2022 14:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235300AbiLVOBu (ORCPT ); Thu, 22 Dec 2022 09:01:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235294AbiLVOBs (ORCPT ); Thu, 22 Dec 2022 09:01:48 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABB226AF2; Thu, 22 Dec 2022 06:01:47 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C109480654; Thu, 22 Dec 2022 15:01:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671717705; bh=YqaNO9kDy3nFfNc/a2RaV0OvzPrs8XfvxLhPTZxI0VQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aILuV8G0LVnhl9CsZCqq8FNrYyCr2x7Hs0Vs5ioyLmaR0iEyIBZ1h38scHWidtDDa x21BQnj9MfV0C8q4GCz7y9/rprMLjKtb0q28MJry4Y57y0Xc8yYk636EmayAb3UlV2 HDegMUTAFoVpoiPy7/XKYY9etcJH1FvS2EnK2NdMrJUeWoboJBiUxZ1YeszoTrf1y6 Ov79iM1dljOWzniDTE+DZHQiSdWVe2RUfI3zUl8vc5q3cVf1C2cXqeuL0oPDR2kYgj GqLhd6Iz/v59Ty777DgVMJJ2+slSkqAAvalF9IJcVBNm4phtpWOtJ+yTr8wh0dio5P f5jbfRB4sOcBg== Message-ID: <3c555cae-999f-ccd2-d114-00b92abd19ba@denx.de> Date: Thu, 22 Dec 2022 15:01:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] dt-bindings: leds: Mark label property as deprecated Content-Language: en-US To: Pavel Machek , Christoph Niedermaier Cc: Jacek Anaszewski , Rob Herring , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , kernel , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20221122111124.6828-1-cniedermaier@dh-electronics.com> <3f4c89a3-8955-ce41-ac2a-cee9b0ed5210@denx.de> <20221130191905.GA2631320-robh@kernel.org> <4043d693-7739-4709-8551-9f476031db70@denx.de> <38c9aae4-0cae-a5a6-7c76-f23edf259dab@gmail.com> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/22/22 14:50, Pavel Machek wrote: > Hi! > >>>> This part I understand. What is not clear to me is, why is 'label' being >>>> un-deprecated. >>> >>> It shouldn't be. It seems to be Pavel's ad-hoc decision. >> >> Is there a majority agreement that the "label" property remains >> deprecated? > > >> If so, I would say we can mark the label as deprecated. >> >> On the other hand, the new generated standardized sysfs name does not seem >> to provide a full replacement for the "label" property. >> What is still missing? > > Having reasonable naming of the LEDs is pre-requisite for deprecating > label property. As far as I can tell, function and function-enumerator is the reasonable naming. Jacek seem to confirm that. I would say, label can be deprecated . What is the counter-argument for why it should NOT be deprecated ?