From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: William Qiu <william.qiu@starfivetech.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-mmc@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] riscv: dts: starfive: Add mmc node
Date: Fri, 3 Feb 2023 10:02:33 +0100 [thread overview]
Message-ID: <3c5bda9f-08b9-f2ba-6951-9fc614d4debc@linaro.org> (raw)
In-Reply-To: <20230203081913.81968-4-william.qiu@starfivetech.com>
On 03/02/2023 09:19, William Qiu wrote:
> This adds the mmc node for the StarFive JH7110 SoC.
Do not use "This xxx". Use imperative mode.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> Set mmco node to emmc and set mmc1 node to sd.
>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> +
> &gmac0_rmii_refin {
> clock-frequency = <50000000>;
> };
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index 64d260ea1f29..ae1a664e7af5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -370,6 +370,11 @@ syscrg: clock-controller@13020000 {
> #reset-cells = <1>;
> };
>
> + sysreg: syscon@13030000 {
> + compatible = "starfive,sysreg", "syscon";
No:
1. Undocumented.
2. A bit too generic. You should have here SoC specific compatible as
well (either as second or third compatible, if all your SoCs share
register layout).
> + reg = <0x0 0x13030000 0x0 0x1000>;
> + };
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-03 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 8:19 [PATCH v3 0/3] StarFive's SDIO/eMMC driver support William Qiu
2023-02-03 8:19 ` [PATCH v3 1/3] dt-bindings: mmc: Add StarFive MMC module William Qiu
2023-02-03 9:00 ` Krzysztof Kozlowski
2023-02-03 8:19 ` [PATCH v3 2/3] mmc: starfive: Add sdio/emmc driver support William Qiu
2023-02-03 8:19 ` [PATCH v3 3/3] riscv: dts: starfive: Add mmc node William Qiu
2023-02-03 9:02 ` Krzysztof Kozlowski [this message]
2023-02-03 9:23 ` William Qiu
2023-02-03 9:30 ` Krzysztof Kozlowski
2023-02-03 9:35 ` William Qiu
2023-02-15 10:31 ` Emil Renner Berthing
2023-02-15 10:32 ` William Qiu
2023-02-14 12:18 ` [PATCH v3 0/3] StarFive's SDIO/eMMC driver support Ulf Hansson
2023-02-15 1:56 ` William Qiu
2023-02-15 10:00 ` Emil Renner Berthing
2023-02-15 10:16 ` William Qiu
2023-02-15 10:22 ` Conor Dooley
2023-02-15 10:36 ` William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c5bda9f-08b9-f2ba-6951-9fc614d4debc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).