From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2591DC9BD; Wed, 11 Dec 2024 09:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733910739; cv=none; b=aU+iPw9z7uJKIKFKKVlqZkEEGYdY+NP6olcfhht5nB7hYwYsIYjVU1P2IaiIoCUo65VyNDdIVnCYMcyJfWWrvybjRmJ0pKS+ks5Wc8boYmgXDxUUhvrPz7IAUS6EOGlYjaFMsHwmycGepnp0WQr5jHSWBcL8RXi99trA0MMLLWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733910739; c=relaxed/simple; bh=1MvPVOm2KT4I3D3hDmh8qUenmdswE/c+r2gVB3m84Fk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aKcf06DP6pL6omoG+U/g8Dbfiq8uAnrN7brpgEC1g0EfCwEpqzHGMPThqRnetdAcrM520V9/p5pDUb4QKlBCq9MWbtV/x/7DNbJQj+uo7rpPwhDXkE5O+NxW+ybCJ5kPVqn3NufDvunl6GOX5r5+L5fZTnNda+PsMfm5CDFCYG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BZCNOb9F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BZCNOb9F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2E1CC4CEDE; Wed, 11 Dec 2024 09:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733910739; bh=1MvPVOm2KT4I3D3hDmh8qUenmdswE/c+r2gVB3m84Fk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BZCNOb9F091Lge08SDZcjO25UI/Ji+Hkv0ozwWHtSXP/7LtzkHkpCUVpxB3+JuWG8 cBw41kTpv9gpt99Iy4Rq/4rurBdoeAdifDKR+N39lQBudF6QMu43DndXVIj7184C7i i84xVfDLYCc2jjjxnAQ9478drcrZl5ciES4jDCXk+kC190/WUygReGVB67YL4EyGAZ kfDb/uo/pbXmwgKVXXUH1MRLpSf24mp5BY1lTmnpvwsexZRZhd1LaR4krT9l5lOnqk IiZKKYSPChXvKAABvVqKb+/ChHWLoH63DCwpCE1S7cA62X1mjTaIv3wrdaBXKkX0wc PuDnMGpPriC/g== Message-ID: <3c7ddb08-38db-44b3-a7a7-ec7b270a408f@kernel.org> Date: Wed, 11 Dec 2024 10:52:11 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties To: Manivannan Sadhasivam Cc: Ziyue Zhang , vkoul@kernel.org, kishon@kernel.org, dmitry.baryshkov@linaro.org, abel.vesa@linaro.org, neil.armstrong@linaro.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20241204105249.3544114-1-quic_ziyuzhan@quicinc.com> <20241204105249.3544114-2-quic_ziyuzhan@quicinc.com> <20241211062053.vxdpovlmetvyx3za@thinkpad> <33697bd9-02f4-4a9a-b8c0-4930d7fdaee2@kernel.org> <20241211082404.p7fbmhooikmipxvm@thinkpad> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20241211082404.p7fbmhooikmipxvm@thinkpad> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/12/2024 09:24, Manivannan Sadhasivam wrote: > On Wed, Dec 11, 2024 at 09:09:18AM +0100, Krzysztof Kozlowski wrote: >> On 11/12/2024 07:20, Manivannan Sadhasivam wrote: >>> On Thu, Dec 05, 2024 at 11:23:11AM +0100, Krzysztof Kozlowski wrote: >>>> On Wed, Dec 04, 2024 at 06:52:47PM +0800, Ziyue Zhang wrote: >>>>> On some platforms, the power supply for PCIe PHY is not able to provide >>>>> enough current when it works in LPM mode. Hence, PCIe PHY driver needs to >>>>> set current load to vote the regulator to HPM mode. >>>>> >>>>> Document the current load as properties for each power supply PCIe PHY >>>>> required, namely vdda-phy-max-microamp, vdda-pll-max-microamp and >>>>> vdda-qref-max-microamp, respectively.PCIe PHY driver should parse them to >>>>> set appropriate current load during PHY power on. >>>>> >>>>> This three properties are optional and not mandatory for those platforms >>>>> that PCIe PHY can still work with power supply. >>>> >>>> >>>> Uh uh, so the downstream comes finally! >>>> >>>> No sorry guys, use existing regulator bindings for this. >>>> >>> >>> Maybe they got inspired by upstream UFS bindings? >>> Documentation/devicetree/bindings/ufs/ufs-common.yaml: >>> >>> vcc-max-microamp >>> vccq-max-microamp >>> vccq2-max-microamp >> >> And it is already an ABI, so we cannot do anything about it. >> >>> >>> Regulator binding only describes the min/max load for the regulators and not >> >> No, it exactly describes min/max consumers can use. Let's quote: >> "largest current consumers may set" >> It is all about consumers. >> >>> consumers. What if the consumers need to set variable load per platform? Should >> >> Then each platform uses regulator API or regulator bindings to set it? I >> don't see the problem here. >> >>> they hardcode the load in driver? (even so, the load should not vary for each >>> board). >> >> The load must vary per board, because regulators vary per board. Of >> course in practice most designs could be the same, but regulators and >> their limits are always properties of the board, not the SoC. >> > > How the consumer drivers are supposed to know the optimum load? > > I don't see how the consumer drivers can set the load without hardcoding the > values. And I could see from UFS properties that each board has different > values. Drivers do not need to know, it's not the driver's responsibility. If these are constraints per board, then regulator properties apply and there is no difference between this "vdd-max-microamp = 10" and "regulator-max-microamp". If this varies runtime, then your property is already not suitable and very limited and you should use OPP table. Best regards, Krzysztof