From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F23C433F5 for ; Fri, 18 Mar 2022 09:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234149AbiCRJCW (ORCPT ); Fri, 18 Mar 2022 05:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232588AbiCRJCV (ORCPT ); Fri, 18 Mar 2022 05:02:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 512B61F83FD for ; Fri, 18 Mar 2022 02:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647594062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R9vj4kn+OCOdsFlfKFDqgJw0bLwF2E8LWLm3AjC+7KU=; b=fCGrP4nuDKCMVvVNKKDnM5p7H4F4MOmTR5r8A7cUf7LeOWtlLl3Wjp2aNbl/H3ST/J4Rb1 QYqANhID1E+qIgTG3pC9D1MnuwQwDU3OlVEmSwH32kim1CZLnpVJ6fw/XyyTazVF/g9hH/ jN99HJoYaD6Vr3JyeA6vQSnpBcGlAi8= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-qi4-CDWjOiKF6zsx-QkBsw-1; Fri, 18 Mar 2022 05:01:01 -0400 X-MC-Unique: qi4-CDWjOiKF6zsx-QkBsw-1 Received: by mail-ej1-f72.google.com with SMTP id zd21-20020a17090698d500b006df778721f7so4207736ejb.3 for ; Fri, 18 Mar 2022 02:01:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=R9vj4kn+OCOdsFlfKFDqgJw0bLwF2E8LWLm3AjC+7KU=; b=RRihk9SZUhuDnUEImJ4nE1MRoMsyo6+92ryRyb9+WZSTUw3ZqI7l2fThdS1I67JcDm 7LR0hsXe+epj1ZLSeeEF5YJg8k42PhvmbA6OerW7mOIr1HwfQX0ZjJWuLsqFwh8lfIas rhjKWRrK7Txo86fqv0JtcEiADzUVrXzdxwE6xwvCelqRSL6WCHsSB4q8QYRlLqzIhj5J wZvoW/FFQKPVF1/5Yd8rrNV7EO40bcGKqYDtQlBiEemiE60Uuh2yInmsmfmrMiLLrwHt BITNCfxbVCV85MfsJNBkB6vDiiMCsn1kM4htW1/Z/IoWF7pmgR79hhGSnAGvwyxFGLhW xigg== X-Gm-Message-State: AOAM5312Qx7Kq8ZZYgf+HXKni/eUKaDQlh/OPlk7sgU4fSIHDkcF26ML FGDhashCtYrCrU5Z86D7btk165+j/E3QivBPoWPFqcjGv9My0x85jg7HiNeNfKSAUWPWVbAzYny jbMjB9smPQuaW1nh4PtBCqg== X-Received: by 2002:a05:6402:2711:b0:416:6442:76dc with SMTP id y17-20020a056402271100b00416644276dcmr8666820edd.314.1647594060061; Fri, 18 Mar 2022 02:01:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQV3U1yHxHRJKifRnvpPhtZiu6ruvQHw0HDBh7W+OqqVtC+9x8xj7Yqu8km6BslQKfEAx9Ag== X-Received: by 2002:a05:6402:2711:b0:416:6442:76dc with SMTP id y17-20020a056402271100b00416644276dcmr8666809edd.314.1647594059891; Fri, 18 Mar 2022 02:00:59 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:cdb2:2781:c55:5db0? (2001-1c00-0c1e-bf00-cdb2-2781-0c55-5db0.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:cdb2:2781:c55:5db0]) by smtp.gmail.com with ESMTPSA id f2-20020a170906738200b006df69629a3dsm3485121ejl.28.2022.03.18.02.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 02:00:59 -0700 (PDT) Message-ID: <3c890d11-75c6-8370-5659-a78b1a9baea2@redhat.com> Date: Fri, 18 Mar 2022 10:00:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 1/4] power: supply: max17042_battery: Add unit conversion macros Content-Language: en-US To: Krzysztof Kozlowski , Sebastian Krzyszkowiak , Marek Szyprowski , Sebastian Reichel , linux-pm@vger.kernel.org Cc: Purism Kernel Team , Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220318001048.20922-1-sebastian.krzyszkowiak@puri.sm> <20220318001048.20922-2-sebastian.krzyszkowiak@puri.sm> <97d88728-4e73-0820-07e7-199377ebff2a@kernel.org> From: Hans de Goede In-Reply-To: <97d88728-4e73-0820-07e7-199377ebff2a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 3/18/22 09:16, Krzysztof Kozlowski wrote: > On 18/03/2022 01:10, Sebastian Krzyszkowiak wrote: >> Instead of sprinkling the code with magic numbers, put the unit >> definitions used by the gauge into a set of macros. Macros are >> used instead of simple defines in order to not require floating >> point operations for divisions. >> >> Signed-off-by: Sebastian Krzyszkowiak >> --- >> drivers/power/supply/max17042_battery.c | 40 +++++++++++++++---------- >> 1 file changed, 24 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c >> index ab031bbfbe78..c019d6c52363 100644 >> --- a/drivers/power/supply/max17042_battery.c >> +++ b/drivers/power/supply/max17042_battery.c >> @@ -51,6 +51,15 @@ >> >> #define MAX17042_VMAX_TOLERANCE 50 /* 50 mV */ >> >> +#define MAX17042_CURRENT_LSB 1562500ll /* µV */ > > Is this really long long? The usage in max17042_get_status() is with int > operand and result. The "ll" is part of the original code which these macros replace, dropping the "ll" is IMHO out of scope for this patch, it would clearly break the only change 1 thing per patch/commit rule. >> +#define MAX17042_CURRENT_RSENSE(x) (x * MAX17042_CURRENT_LSB) /* µV */ >> +#define MAX17042_CAPACITY_LSB 5000000ll /* µVh */ >> +#define MAX17042_CAPACITY_RSENSE(x) (x * MAX17042_CAPACITY_LSB) /* µVh */ >> +#define MAX17042_TIME(x) (x * 5625 / 1000) /* s */ >> +#define MAX17042_VOLTAGE(x) (x * 625 / 8) /* µV */ >> +#define MAX17042_RESISTANCE(x) (x / 4096) /* Ω */ >> +#define MAX17042_TEMPERATURE(x) (x / 256) /* °C */ > > Please enclose the "x" in (), in each macro Ack, right I should have spotted that in my own review. Regards, Hans