From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, bhupesh.linux@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski@linaro.org, djakov@kernel.org,
a39.skl@gmail.com, andersson@kernel.org
Subject: Re: [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver
Date: Wed, 30 Nov 2022 12:07:30 +0100 [thread overview]
Message-ID: <3c8c3cc8-60b9-13e2-a80f-dc397d84adf0@linaro.org> (raw)
In-Reply-To: <20221130103841.2266464-2-bhupesh.sharma@linaro.org>
On 30.11.2022 11:38, Bhupesh Sharma wrote:
> Add driver for the Qualcomm interconnect buses found in SM6115 based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
[...]
> +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match);
> +
> +static struct platform_driver sm6115_qnoc_driver = {
> + .probe = qnoc_probe,
> + .remove = qnoc_remove,
> + .driver = {
> + .name = "qnoc-sm6115",
> + .of_match_table = sm6115_qnoc_of_match,
No .sync_state?
> + },
> +};
> +module_platform_driver(sm6115_qnoc_driver);
> +
> +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver");
> +MODULE_LICENSE("GPL v2");
"GPL", checkpatch should have pointed that out.
Otherwise lgtm
Konrad
next prev parent reply other threads:[~2022-11-30 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 10:38 [PATCH 0/2] Add SM6115 interconnect support Bhupesh Sharma
2022-11-30 10:38 ` [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver Bhupesh Sharma
2022-11-30 11:07 ` Konrad Dybcio [this message]
2022-11-30 11:40 ` Bhupesh Sharma
2022-11-30 10:38 ` [PATCH 2/2] dt-bindings: interconnect: Add SM6115 DT bindings Bhupesh Sharma
2022-11-30 11:41 ` Krzysztof Kozlowski
2022-11-30 11:43 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8c3cc8-60b9-13e2-a80f-dc397d84adf0@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).