From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00BFC433FE for ; Wed, 30 Nov 2022 11:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbiK3LHl (ORCPT ); Wed, 30 Nov 2022 06:07:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiK3LHj (ORCPT ); Wed, 30 Nov 2022 06:07:39 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5D9BDB for ; Wed, 30 Nov 2022 03:07:34 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id j4so26409129lfk.0 for ; Wed, 30 Nov 2022 03:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vbRunTbMP4tz0r9sw9HIT0LUH03qyOKbAKjkg7v1cT8=; b=MLosrlgsByRac1dlTwWOnfeRRemoVklCtoSeOOcLwXvcg23SUzydv3J3NGpzIUK9Qe aavmkMLU8y7BCbC9vXIm+MFmP3TAc2WwVudJ//0p5UiVFkGwCof1hFd8SBFFI8abEBiq hPfWo7uDkyXQ61aNSYjLUbHk06KfsjIYWWSGomWMtFH/1DyG0lPqfaGr+QmZmnbNpmKZ cwa6qRDR/p+NANzfy+Ua3k/io/vNJ6umBV8GsDcDvfLzN3XXqc+vwxjEja8kZDILRtw+ KnbUTeq+FiV4lyYLji9oSnDRtphxZ8KKJMv7fayDEDseBmtP1X2Omfyr8trASgbdkSNz jJfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vbRunTbMP4tz0r9sw9HIT0LUH03qyOKbAKjkg7v1cT8=; b=e8si/QxBCuc3IDnNIQiwQIGVenOVCesraE1uHUEE3S4Dz8p0Fe/AhC3rxKf2cNSnjv /8uBkDLlfq+4qusvnxoFrdPj2Xl/41FTIQ0IvFuhGglI7R5uJTSklFb4DboBM++DxdsF FHw9+NvB2fPiAWcYt+RQIqOA/v7dBR6BJn1XS8L1xMwKXsweicHdcElKqK+xFv5I7Fhb uoieLk1X6/jl/Q9IkqA0lVrRBzWZcE8jaoLqly3SNqJI2fWh45znQYQJWnEcNlAzcomi q5+sBR9t75T9zckPZqoxydsgr99j+EmFTlKw5ctTRBu4Gul/mXT/yS8wrWZyOrsIZKF1 rqQQ== X-Gm-Message-State: ANoB5pnToGJ/4191SlW0ELN1p8iKfSUZvUZIfIkDqd7ezBuZrBJRFYnA GWiPEWBKNNgnyvLRvtT6IyjEqQ== X-Google-Smtp-Source: AA0mqf7EbE0WvcfiBzwsneMSJd4JZFH92F15w8hlSMZkGyD5l7c2YIJYmmeqlOnCi84qMx0fxOd5mQ== X-Received: by 2002:a05:6512:2523:b0:4a6:fac4:596c with SMTP id be35-20020a056512252300b004a6fac4596cmr14219018lfb.220.1669806453251; Wed, 30 Nov 2022 03:07:33 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id l22-20020a194956000000b0049476667228sm219911lfj.65.2022.11.30.03.07.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 03:07:32 -0800 (PST) Message-ID: <3c8c3cc8-60b9-13e2-a80f-dc397d84adf0@linaro.org> Date: Wed, 30 Nov 2022 12:07:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, djakov@kernel.org, a39.skl@gmail.com, andersson@kernel.org References: <20221130103841.2266464-1-bhupesh.sharma@linaro.org> <20221130103841.2266464-2-bhupesh.sharma@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20221130103841.2266464-2-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30.11.2022 11:38, Bhupesh Sharma wrote: > Add driver for the Qualcomm interconnect buses found in SM6115 based > platforms. The topology consists of several NoCs that are controlled by > a remote processor that collects the aggregated bandwidth for each > master-slave pairs. > > Cc: Bjorn Andersson > Signed-off-by: Bhupesh Sharma > --- [...] > +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match); > + > +static struct platform_driver sm6115_qnoc_driver = { > + .probe = qnoc_probe, > + .remove = qnoc_remove, > + .driver = { > + .name = "qnoc-sm6115", > + .of_match_table = sm6115_qnoc_of_match, No .sync_state? > + }, > +}; > +module_platform_driver(sm6115_qnoc_driver); > + > +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver"); > +MODULE_LICENSE("GPL v2"); "GPL", checkpatch should have pointed that out. Otherwise lgtm Konrad