From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E995EC4321E for ; Mon, 21 Nov 2022 11:22:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbiKULWN (ORCPT ); Mon, 21 Nov 2022 06:22:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230507AbiKULVw (ORCPT ); Mon, 21 Nov 2022 06:21:52 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F301D2AE4 for ; Mon, 21 Nov 2022 03:17:11 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id b9so14134529ljr.5 for ; Mon, 21 Nov 2022 03:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jkv4qNVxax2NflVe/+WbohgxJpSGX87kcALkGVRl4ws=; b=j2S/DFK4TTAG0g3MhrEdwxxWHUWHVNorPABSYUZpmXL2Xiv6BGi22igUiWwswBUkVS O0EE53twcrrRgGFpasfTSMYk97uFAuClYrIydw3GU1Vl+YO0Mvif1sK8YER5FZ6lLEzI qsSzquN/DDuTq6HT8s3IndfN9xsZ99tzb+o1uQnXDf0Boa4SDkMillwaYZyTwoU1ooqQ qU5NaNbdt+grhGurHz4tzUyqmZepEKb0AELnmW11guyAoRuv3p1z+nvTyZVCWw+67FWu kezedLvSbzKfcVS4rCtJYAru2ykpHUBSieK2H9gTVYUzXCMA7AGp5sX7llyp9V262IWE H6FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jkv4qNVxax2NflVe/+WbohgxJpSGX87kcALkGVRl4ws=; b=IDSvIgist5L5L1vbLSYj9EqCtYZ4UryXTJssdD0ZSL6BI16KKJbu1NwUzvFnR/YoQk dPW3ADRFZTbGk9W+dPEBycYvQ2rytoZmpsCsky5HtqBpjzp+MeYWAeoYmF8vMYDoV40n rQNBz3Cuvw+62r+YbX1Ok3WTuobXuKYjEBcd6p42Zd2xXIvqHxDjLrZLiEOP/SUgeIk0 i1vF+GrnJzNK9QykzBzG52qvgpy+qSI+ksqrk4r2P4Wba8qzDik8nNVBoywII2QpxAHE dJAwCu/7+De/c4VyWuk4oNG2AseBEEEq+nWAZ3qSq3i9nklPMX3wKOxDb3KThY2CN1Yy 8BRA== X-Gm-Message-State: ANoB5pnw6xyhNEFYq4YUq7F4oPe6HglOMWitDEbvbzJTIpiX4FTAHCy+ Pa7jlp9RwZhQl6vtUPLbgO2Z3w== X-Google-Smtp-Source: AA0mqf7IE/u7DWro+kUBrVuapOEsLp1/+SfZORDlLGXzCazt9zqv1iJwbRLhnfTozjNsxjmaNpvHTw== X-Received: by 2002:a2e:a4b0:0:b0:277:fcb:f6ad with SMTP id g16-20020a2ea4b0000000b002770fcbf6admr6079436ljm.484.1669029430272; Mon, 21 Nov 2022 03:17:10 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id 68-20020a2e0947000000b0026fb09d6a27sm1423551ljj.58.2022.11.21.03.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 03:17:09 -0800 (PST) Message-ID: <3c8dc34f-c0db-82df-1fed-b80098be6c87@linaro.org> Date: Mon, 21 Nov 2022 12:17:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 4/9] arm64: dts: qcom: msm8953: Add device tree for Motorola G5 Plus Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Sireesh Kodali , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20221119203758.888207-1-luca@z3ntu.xyz> <20221119203758.888207-5-luca@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20221119203758.888207-5-luca@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19.11.2022 21:37, Luca Weiss wrote: > From: Sireesh Kodali > > Add device tree for the Motorola G5 Plus (potter) smartphone. This > device is based on Snapdragon 625 (msm8953) SoC. > > Signed-off-by: Sireesh Kodali > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad > Changes in v2: > * address review comments from v1 > > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8953-motorola-potter.dts | 305 ++++++++++++++++++ > 2 files changed, 306 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 6bc1be0d525a..eb3cfbac6b82 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -21,6 +21,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > new file mode 100644 > index 000000000000..e890fd53c454 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > @@ -0,0 +1,305 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022, Sireesh Kodali > + */ > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > + > +/delete-node/ &cont_splash_mem; > +/delete-node/ &qseecom_mem; > + > +/ { > + model = "Motorola G5 Plus"; > + compatible = "motorola,potter", "qcom,msm8953"; > + chassis-type = "handset"; > + qcom,msm-id = <293 0>; > + qcom,board-id = <0x46 0x83a0>; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer@90001000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x90001000 0 (2220 * 1920 * 3)>; > + > + width = <1080>; > + height = <1920>; > + stride = <(1080 * 3)>; > + format = "r8g8b8"; > + > + power-domains = <&gcc MDSS_GDSC>; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_key_default>; > + > + key-volume-up { > + label = "Volume Up"; > + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > + > + reserved-memory { > + qseecom_mem: qseecom@84300000 { > + reg = <0x0 0x84300000 0x0 0x2000000>; > + no-map; > + }; > + > + cont_splash_mem: cont-splash@90001000 { > + reg = <0x0 0x90001000 0x0 (1080 * 1920 * 3)>; > + no-map; > + }; > + > + reserved@aefd2000 { > + reg = <0x0 0xaefd2000 0x0 0x2e000>; > + no-map; > + }; > + > + reserved@eefe4000 { > + reg = <0x0 0xeefe4000 0x0 0x1c000>; > + no-map; > + }; > + > + ramoops@ef000000 { > + compatible = "ramoops"; > + reg = <0x0 0xef000000 0x0 0x80000>; > + console-size = <0x40000>; > + ftrace-size = <0>; > + record-size = <0x3f800>; > + pmsg-size = <0x800>; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&hsusb_phy { > + vdd-supply = <&pm8953_l3>; > + vdda-pll-supply = <&pm8953_l7>; > + vdda-phy-dpdm-supply = <&pm8953_l13>; > + > + status = "okay"; > +}; > + > +&i2c_3 { > + status = "okay"; > + > + touchscreen@20 { > + reg = <0x20>; > + compatible = "syna,rmi4-i2c"; > + > + interrupt-parent = <&tlmm>; > + interrupts = <65 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ts_reset>; > + > + vdd-supply = <&pm8953_l22>; > + vio-supply = <&pm8953_l6>; > + > + syna,reset-delay-ms = <200>; > + syna,startup-delay-ms = <500>; > + }; > +}; > + > +&pm8953_resin { > + linux,code = ; > + status = "okay"; > +}; > + > +&pmi8950_wled { > + qcom,current-limit-microamp = <25000>; > + qcom,num-strings = <3>; > + qcom,external-pfet; > + qcom,cabc; > + > + status = "okay"; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; > + vdd_s1-supply = <&vph_pwr>; > + vdd_s2-supply = <&vph_pwr>; > + vdd_s3-supply = <&vph_pwr>; > + vdd_s4-supply = <&vph_pwr>; > + vdd_s5-supply = <&vph_pwr>; > + vdd_s6-supply = <&vph_pwr>; > + vdd_s7-supply = <&vph_pwr>; > + vdd_l1-supply = <&pm8953_s3>; > + vdd_l2_l3-supply = <&pm8953_s3>; > + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; > + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; > + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; > + > + pm8953_s1: s1 { > + regulator-min-microvolt = <863000>; > + regulator-max-microvolt = <1152000>; > + }; > + > + pm8953_s3: s3 { > + regulator-min-microvolt = <1224000>; > + regulator-max-microvolt = <1224000>; > + }; > + > + pm8953_s4: s4 { > + regulator-min-microvolt = <1896000>; > + regulator-max-microvolt = <2048000>; > + }; > + > + pm8953_l1: l1 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1100000>; > + }; > + > + pm8953_l2: l2 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + }; > + > + pm8953_l3: l3 { > + regulator-min-microvolt = <925000>; > + regulator-max-microvolt = <925000>; > + regulator-allow-set-load; > + }; > + > + pm8953_l5: l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l6: l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + pm8953_l7: l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + }; > + > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + pm8953_l9: l9 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8953_l10: l10 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l11: l11 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l13: l13 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3125000>; > + }; > + > + pm8953_l15: l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l16: l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l17: l17 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l19: l19 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1350000>; > + }; > + > + pm8953_l22: l22 { > + regulator-always-on; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l23: l23 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1225000>; > + }; > + }; > +}; > + > +&sdhc_1 { > + vmmc-supply = <&pm8953_l8>; > + vqmmc-supply = <&pm8953_l5>; > + > + status = "okay"; > +}; > + > +&sdhc_2 { > + cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + vmmc-supply = <&pm8953_l11>; > + vqmmc-supply = <&pm8953_l12>; > + > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <1 2>, <96 4>, <111 1>, <126 1>; > + > + ts_reset: ts-reset-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > +}; > + > +&usb3 { > + status = "okay"; > +}; > + > +&usb3_dwc3 { > + dr_mode = "peripheral"; > +};