From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-watchdog@vger.kernel.org
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
tsbogend@alpha.franken.de, p.zabel@pengutronix.de,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 2/4] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog
Date: Fri, 10 Feb 2023 20:46:38 +0300 [thread overview]
Message-ID: <3ca26ba2-80f5-32a2-0357-d91c87efd1c0@arinc9.com> (raw)
In-Reply-To: <20230210173841.705783-3-sergio.paracuellos@gmail.com>
Could you also change the node name to watchdog@100? make dtbs_check
points it out:
wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
Thanks.
Arınç
On 10.02.2023 20:38, Sergio Paracuellos wrote:
> To allow to access system controller registers from watchdog driver code
> add a phandle in the watchdog 'wdt' node. This avoid using arch dependent
> operations in driver code.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 5ca40fd21..764916eaf 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -73,6 +73,7 @@ sysc: syscon@0 {
> wdt: wdt@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> + mediatek,sysctl = <&sysc>;
> };
>
> gpio: gpio@600 {
next prev parent reply other threads:[~2023-02-10 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 17:38 [PATCH v3 0/4] watchdog: mt7621-wdt: avoid globals and arch dependencies Sergio Paracuellos
2023-02-10 17:38 ` [PATCH v3 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers Sergio Paracuellos
2023-02-10 17:38 ` [PATCH v3 2/4] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog Sergio Paracuellos
2023-02-10 17:46 ` Arınç ÜNAL [this message]
2023-02-11 7:16 ` Sergio Paracuellos
2023-02-10 17:38 ` [PATCH v3 3/4] watchdog: mt7621-wdt: avoid static global declarations Sergio Paracuellos
2023-02-10 18:46 ` Guenter Roeck
2023-02-10 17:38 ` [PATCH v3 4/4] watchdog: mt7621-wdt: avoid ralink architecture dependent code Sergio Paracuellos
2023-02-10 18:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ca26ba2-80f5-32a2-0357-d91c87efd1c0@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox