From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types
Date: Mon, 26 Sep 2022 10:51:45 +0200 [thread overview]
Message-ID: <3cabc45a-526b-0177-e29a-bbe048e97a7f@linaro.org> (raw)
In-Reply-To: <20220925211744.133947-2-luca@z3ntu.xyz>
On 25/09/2022 23:17, Luca Weiss wrote:
Thank you for your patch. There is something to discuss/improve.
> additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>
> + "charger@[0-9a-f]+$":
> + type: object
> + oneOf:
> + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
> + "^dcdc@[0-9a-f]+$":
> + type: object
How about renaming this one to usb-vbus-regulator?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-26 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 21:17 [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Luca Weiss
2022-09-25 21:17 ` [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types Luca Weiss
2022-09-26 8:51 ` Krzysztof Kozlowski [this message]
2022-09-26 15:00 ` Luca Weiss
2022-09-26 8:49 ` [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Krzysztof Kozlowski
2022-09-26 14:59 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cabc45a-526b-0177-e29a-bbe048e97a7f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox