From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF5982C030E for ; Fri, 17 Oct 2025 16:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760718043; cv=none; b=SaBfkElI1to21gncCos/RBkM+sqLX0khe5T1+w1COmhQ7VMjBR/Xi7sDUV0VXwebWUa257orHh67eBi8m/rKd0o2VgOZefFRcfcn5JN1Vz59pkIKKGzqySJ9Z+oIRyRz4scLg5cGs9/zSvogyffOYJCGG1G6XXFrpfEJ6B4erzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760718043; c=relaxed/simple; bh=gxKOH8Xdwc40yMCcxjDPNybQvl0viUGO00L2ILr5yMg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=For5skFiDnKhbKGWQhQnmJ0ukOhVryGC2NEdn3HD5YVlwv91vRBO6I4wDW5su3qrsJ9mcis3lI2GCh+Vb5gmej3ZAd82U13f3cbiT7D4UMS1Zrr5jyobNM4lGbDx0Fy0cX1VYmiVqOmt+lzE0C12A6W/DvP/h1vH6IeDt/aHt+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=t0ucrUBL; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="t0ucrUBL" Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-430ccd45f19so4191245ab.1 for ; Fri, 17 Oct 2025 09:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1760718040; x=1761322840; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CVQ6phuTO84kFBkRt8EnO28DbxtrTEoiT+THIp/h4p4=; b=t0ucrUBLoRssJrKtvP3DBh+uDh0k5SGtZBapjoXMoaMf7wd9frsENoYcYCQpU8V71Z VAbienV/ZTHNxuCs+GrjYtTpm5ODskSEp5yN3CbbjUvbiwFq4YjKkSZbVz26OJ+x3sLL 1Y4D8a583G+VJe0QCabnO4va87db47AcNmDrHkSv88DP1ca+FJlPbR5AXuTWj42voQCr oxLnLapdNY3Q1OkCs+WmbG9fQXs2Gft53TNQX3xwnPWZBXg02vz5uL/HPVTn6TtAS7tf Hw6aHBUJWM+DFqyDyvnU5gUle0/7XcAwmuzhmrRNNLhMw4DQhvTYK2QXIjmkmeS/83Bc A2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760718040; x=1761322840; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CVQ6phuTO84kFBkRt8EnO28DbxtrTEoiT+THIp/h4p4=; b=Z6tHqL0loxgTmoA3nyT1bslSXfdOKy5XDmWLTWjUjCSmtv1elrM/+I4504kdbT/BOl Ye2vF+QLCrvI8OhYMV+c0In5dNckXyuE9TOSyYVIM3dtHoEH1ri3de03sfNkOWl9hoZI 1omCkW1jOn2lvbf3TwttH2dhbkqsq6wQDzn5psCgblBlF7zQZBH+m0Bj1KgGLJ3hgvls 905QufC43aqNpppSGSF+iWtzvXt0gdRBFx4g7kGF7iC7WKtmcmrssUGEMD7Z/KzukW/C eAq/W8B0XuWbtgw4RE9MDQjGVSRlpeTxtkxm601U6LimwZRhbdbFj6tN5loexzMOJd+T VhkQ== X-Forwarded-Encrypted: i=1; AJvYcCXQQzwaSxV0akv68zbuJaEJaw6QmEIFPUBqiWeA3jaRqYgjgo6kd340XCDnIT/RiTUeNABAaSLBCzH7@vger.kernel.org X-Gm-Message-State: AOJu0YwdS3656jMHTL0gToA1QhjEwAgs3vzanD7cuHa4GeKeHPLRhxl5 iZBMrZFzJ9pFzBaE/4+TJBWf6klUdzSBtDMop9ccZwANN/cyJniMBTYjSlOwTikMlmQ= X-Gm-Gg: ASbGncuZRo3Wun2R9y4c3uijKAg9iOZZVUGtMjZ86YnKjpFGMwNlzBvMZGFSP+XTe0G ASJ27tbgexvHHk+Ni32TmtFuuni3/vbbD7cA5lWnop6jMP7PnuumKOLkj2jo8OFj/Wfsyg+pDyN FdyYyjK4Dd64zUCz41hOb8977RQuS2aHsGZa26ab8PfQQn52ymI8bFMrjdyACPIeOFbH55s++ly Rn8vOocMnYfXliMi9rbR+MTGPVPO8bEFPRgA3pRNl4ZGEUt4Yb3Bln4NuubVG514F0D+8qK7mqM hfYbnNPmHaq6kmM04ngWDClh++a/Mx4mInBYRpGAWuo5JkRRJ0ZNAAaHf3tjwQKmqveJ/S3VCUK iAUR9W5NQD6WyqoKM8FgtE75FswT0lZ/F1L/2/wRvKeTJzRyJwVuqmJnLHIV9T1ScRITFbR+4Ru +atQsiYtK3Hq+0JcIn4TyAkm85YW1q/hPWDrtkvCE= X-Google-Smtp-Source: AGHT+IHkLguz0srIwb9Y0kZ8Jj/SerEa4TnF03jUDSOPF34f5dBqn26UDMGx8TBiPYMDv2ZC0jD7cw== X-Received: by 2002:a05:6e02:1d9d:b0:430:a65c:a833 with SMTP id e9e14a558f8ab-430c52ccf5fmr57021215ab.31.1760718039725; Fri, 17 Oct 2025 09:20:39 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5a8a97689basm12877173.49.2025.10.17.09.20.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 09:20:39 -0700 (PDT) Message-ID: <3ccf196c-aa57-4977-9dea-a54172e427fa@riscstar.com> Date: Fri, 17 Oct 2025 11:20:37 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY To: Rob Herring Cc: krzk+dt@kernel.org, conor+dt@kernel.org, bhelgaas@google.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, vkoul@kernel.org, kishon@kernel.org, dlan@gentoo.org, guodong@riscstar.com, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, christian.bruel@foss.st.com, shradha.t@samsung.com, krishna.chundru@oss.qualcomm.com, qiang.yu@oss.qualcomm.com, namcao@linutronix.de, thippeswamy.havalige@amd.com, inochiama@gmail.com, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251013153526.2276556-1-elder@riscstar.com> <20251013153526.2276556-2-elder@riscstar.com> <20251015145217.GA3554740-robh@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20251015145217.GA3554740-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/15/25 9:52 AM, Rob Herring wrote: >> + resets: >> + items: >> + - description: DWC PCIe Data Bus Interface (DBI) reset >> + - description: DWC PCIe application AXI-bus Master interface reset >> + - description: DWC PCIe application AXI-bus slave interface reset >> + - description: PHY reset; must be deasserted for PHY to function >> + >> + reset-names: >> + items: >> + - const: dbi >> + - const: mstr >> + - const: slv >> + - const: phy > I think phy should be first as that's the main one to the phy and the > others are somewhat questionable. Otherwise, > > Reviewed-by: Rob Herring (Arm) OK I'll arrange them that way in v3. Thank you. -Alex