Re: [PATCH 3/4] arm64: dts: qcom: monaco-evk-camera: Add DT overlay

[Nihal Kumar Gupta <quic_nihalkum@quicinc.com>]

On 10-09-2025 12:33, Vikram Sharma wrote:
> On 9/9/2025 7:31 PM, Dmitry Baryshkov wrote:
>> On Tue, Sep 09, 2025 at 05:12:40PM +0530, Vikram Sharma wrote:
>>> From: Nihal Kumar Gupta<quic_nihalkum@quicinc.com>
>>>
>>> Enable IMX577 sensor using the CCI1 interface on Monaco EVK.
>>> Camera reset is controlled through an I2C expander,
>>> and power supply is managed via tlmm GPIO74.
>> Why is done as an overlay? Is it a seprate mezzanine?
> It’s not a separate mezzanine; monaco-evk does not come with an attached camera 
> sensor by default.
> The overlay simply reflects an optional camera sensor attachment (e.g., IMX577 
> on CSIPHY1)
> That is why camera sensor is configured in monaco-evk-camera.dtso instead of 
> modifying the base monaco-evk.dts.
> Please suggest and alternative approach if you feel this is not correct

Dmitry, Do you agree with this justification or you have a follow-up comment?
Can we post v2 with the same change addressing other comments.

>>> Co-developed-by: Ravi Shankar<quic_rshankar@quicinc.com>
>>> Signed-off-by: Ravi Shankar<quic_rshankar@quicinc.com>
>>> Co-developed-by: Vishal Verma<quic_vishverm@quicinc.com>
>>> Signed-off-by: Vishal Verma<quic_vishverm@quicinc.com>
>>> Signed-off-by: Nihal Kumar Gupta<quic_nihalkum@quicinc.com>
>>> Signed-off-by: Vikram Sharma<quic_vikramsa@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/Makefile             |  4 +
>>>   .../boot/dts/qcom/monaco-evk-camera.dtso      | 98 +++++++++++++++++++
>>>   2 files changed, 102 insertions(+)
>>>   create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso
>>> new file mode 100644
>>> index 000000000000..5831b4de6eca
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso
>>> @@ -0,0 +1,98 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +/* Camera Sensor overlay on top of Monaco EVK Core Kit */
>>> +
>>> +/dts-v1/;
>>> +/plugin/;
>>> +
>>> +#include <dt-bindings/clock/qcom,sa8775p-camcc.h>
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +
>>> +&{/} {
>> Is this a different product than just Monaco EVK?
> No.
>>
>>
>>> +	vreg_cam1_2p8: vreg_cam1_2p8 {
>>> +		compatible = "regulator-fixed";
>>> +		regulator-name = "vreg_cam1_2p8";
>>> +		startup-delay-us = <10000>;
>>> +		enable-active-high;
>>> +		gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
>>> +	};
>>> +};
>>> +
> 
> Best Regards,
> 
> Vikram
> 
Regards,
Nihal Kumar Gupta