From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB4BEC4363A for ; Mon, 5 Oct 2020 09:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DA8B20774 for ; Mon, 5 Oct 2020 09:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725901AbgJEJ1s (ORCPT ); Mon, 5 Oct 2020 05:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbgJEJ1s (ORCPT ); Mon, 5 Oct 2020 05:27:48 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F76AC0613CE for ; Mon, 5 Oct 2020 02:27:48 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id D84E0292819 Subject: Re: [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema To: =?UTF-8?Q?Ricardo_Ca=c3=b1uelo?= Cc: robh@kernel.org, kernel@collabora.com, bleung@chromium.org, groeck@chromium.org, sjg@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org References: <20201005071403.17450-1-ricardo.canuelo@collabora.com> <20201005071403.17450-2-ricardo.canuelo@collabora.com> <19e0e78e-f490-8bcb-cfdb-338a577b2205@collabora.com> <20201005091804.2xjwer6ppoog5orm@rcn-XPS-13-9360> From: Enric Balletbo i Serra Message-ID: <3d2b79f8-1a1f-ae70-0bd6-617724eec349@collabora.com> Date: Mon, 5 Oct 2020 11:27:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201005091804.2xjwer6ppoog5orm@rcn-XPS-13-9360> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ricardo, On 5/10/20 11:18, Ricardo Cañuelo wrote: > Hi Enric, thanks for reviewing the patch. > > On lun 05-10-2020 10:52:26, Enric Balletbo i Serra wrote: >>> +examples: >>> + - | >>> + cros-ec { >> >> We try to use always a complete example, and I think that, Rob also prefers >> complete examples, so here you are missing the spi node. > > Ok, I'll prepare a new patch with an extended example. > >>> + compatible = "google,cros-ec-spi"; >> >> And, at least, should have a reg. Did not give you an error? > > AFAIK, the reg property is only enforced if the node name includes the > unit-address. > Exactly, and because this is a spi driver it should have both, the node name include the unit-address and the reg property. I.e: spi0 { #address-cells = <1>; #size-cells = <0>; cros-ec@0 { compatible = "google,cros-ec-spi"; reg = <0x0>; spi-max-frequency = <5000000>; }; }; Thanks, Enric > Cheers, > Ricardo >