From: Robin Murphy <robin.murphy@arm.com>
To: Matt Ranostay <mranostay@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Marc Zyngier <maz@kernel.org>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region
Date: Fri, 17 Jun 2022 15:13:00 +0100 [thread overview]
Message-ID: <3d35c330-acfe-c6d1-8963-4b9b6d44dbb5@arm.com> (raw)
In-Reply-To: <20220617140207.444298-1-mranostay@ti.com>
On 2022-06-17 15:02, Matt Ranostay wrote:
> GICD region was overlapping with GICR causing the latter to not map
> successfully, and in turn the gic-v3 driver would fail to initialize.
>
> This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> replaced of_iomap() calls with of_io_request_and_map() that internally
> called request_mem_region().
>
> Respective console output before this patchset:
>
> [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0
>
> Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
I think that should be b8545f9d3a54 ("arm64: dts: ti: Add initial
support for J721S2 SoC") - the GIC change is the point at which Linux
started *noticing* that the DT was wrong, but it's not what made the DT
wrong.
Thanks,
Robin.
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes from v1:
> * Add missing Fixes: in commit messages
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index be7f39299894..19966f72c5b3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -33,7 +33,7 @@ gic500: interrupt-controller@1800000 {
> ranges;
> #interrupt-cells = <3>;
> interrupt-controller;
> - reg = <0x00 0x01800000 0x00 0x200000>, /* GICD */
> + reg = <0x00 0x01800000 0x00 0x100000>, /* GICD */
> <0x00 0x01900000 0x00 0x100000>, /* GICR */
> <0x00 0x6f000000 0x00 0x2000>, /* GICC */
> <0x00 0x6f010000 0x00 0x1000>, /* GICH */
next prev parent reply other threads:[~2022-06-17 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 14:02 [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region Matt Ranostay
2022-06-17 14:13 ` Robin Murphy [this message]
2022-06-17 14:13 ` Marc Zyngier
2022-06-17 15:02 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d35c330-acfe-c6d1-8963-4b9b6d44dbb5@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mranostay@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox