From: Florian Fainelli <f.fainelli@gmail.com>
To: Raviteja Garimella <raviteja.garimella@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org
Subject: Re: [RFC 1/1] Changes to support the driver for platform device registration
Date: Thu, 5 Jan 2017 09:43:56 -0800 [thread overview]
Message-ID: <3d3e9fce-faae-3ff0-c42c-20f4bced663a@gmail.com> (raw)
In-Reply-To: <1483604597-26160-2-git-send-email-raviteja.garimella@broadcom.com>
On 01/05/2017 12:23 AM, Raviteja Garimella wrote:
> -- Add OF based platform device registration
> -- Modify debug prints to be compatible with both pci and platform devices
> -- Add members to 'struct udc' for extcon and phy support
> -- Add checks to not process repeated calls to udc connect and
> disconnect routines
> -- Kconfig changes
What you are doing in this patch is all well and good, but since you are
listing these changes, that means we should see 4/5 patches submitted to
this driver each one doing what you have as a bullet point.
Since you are adding Device Tree probing support to the driver, you also
need to create a proper binding document which describes the properties
and nodes.
Thank you
--
Florian
next prev parent reply other threads:[~2017-01-05 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 8:23 [RFC 0/1] Platform driver support for 'amd5536udc' driver Raviteja Garimella
2017-01-05 8:23 ` [RFC 1/1] Changes to support the driver for platform device registration Raviteja Garimella
2017-01-05 17:43 ` Florian Fainelli [this message]
[not found] ` <3d3e9fce-faae-3ff0-c42c-20f4bced663a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-06 7:09 ` Raviteja Garimella
[not found] ` <1483604597-26160-1-git-send-email-raviteja.garimella-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-01-05 22:03 ` [RFC 0/1] Platform driver support for 'amd5536udc' driver Arnd Bergmann
2017-01-06 6:59 ` Raviteja Garimella
[not found] ` <CAEHZuqNK07Xku9SmFhV0DJ4apV0m8yWznuFDwjr33CDP_OcXew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-06 11:20 ` Arnd Bergmann
2017-01-16 13:51 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3e9fce-faae-3ff0-c42c-20f4bced663a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=raviteja.garimella@broadcom.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).