Re: [RFC PATCH] arm64: dts: qcom: Use labels with generic node names for ADC channels

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/12/2022 22:53, Marijn Suijten wrote:
> As discussed in [1] the DT should use labels to describe ADC channels,
> with generic node names, since the IIO drivers now moved to the fwnode
> API where node names include the `@xx` address suffix.
> 
> Especially for the ADC5 driver that uses extend_name - which cannot be
> removed for compatibility reasons - this results in sysfs files with the
> @xx name that wasn't previously present, and leads to an unpleasant
> file-browsing experience.
> 
> Also remove all the unused channel labels in pm660.dtsi.
> 
> [1]: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@somainline.org/T/#u
> 
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>

The talk was in context of bindings, not about changing all existing
users thus affecting DTS. What's more, to me "skin-temp-thermistor" is
quite generic name, maybe "thermistor" would be more and reflects the
purpose of the node, so it was more or less fine.

Anyway I am against such changes without expressing it in the bindings.

Best regards,
Krzysztof