From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D64691428E7; Thu, 28 Nov 2024 10:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732789945; cv=none; b=enEClOgRnLE6/YosM0zwf0r8Zv9yd90bbrwxsE+2pTuFbELY76OKMO/rN3U6sXVPDsl0wLF3mOjc6V6dgYYngg+ZlH5PKMHulyUjxeV/ppvvA+Uc+GO9/Z3wqHCkr9IEz4DvzvOrQdWls7jqarSXdZcw9crVYwkHIZQvDKuQ190= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732789945; c=relaxed/simple; bh=HrAXTZSCIcuftLL0ul3rClI7fugMpktKhWmYw6wLDok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=igdcKSfiIljqNtvpgfZH5WUC1ZRUwF9tF47JZWWk2rl0fClNjy6Yr+x1mpf/wHrleNT6QFGDViCPkAFTknolPDPnEpTq07z7t6Zd+pd9G33JMK3jtwcWiCS8TvRxIc6hLGpKDCR4cJt9ywTJTF5T90zDKjPVH96QA0CY4wqKky4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Pvs5GMYL; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Pvs5GMYL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1732789935; bh=HrAXTZSCIcuftLL0ul3rClI7fugMpktKhWmYw6wLDok=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Pvs5GMYLUfrPah0+EMJAeFXycEFxuIzy7qwIM5MEbgQGhXci8eG6uDooADcTA50zk UX7Mn+7kRhRPozOi72Nph0RHwurnhil01+QK4vRE9nW6EDG759tjQa2nxZXmyvKKz4 sknbaqSiwV9/WYZaUoUKFFkOiblORDXlNj0RqkJnaWhjNeTOXbQhTkaDsw+YlmYTGh oO3k0cEcrvCrqxF95kO/Gw9ogDboWN/aXLoYxZJzp2nXoFqkAV5F1kKJe+ygxPKA7t eOHkr8JvwFJhQ+g2LEltlRi6uAoV0wK7MaN1ywVKNsCZn214O1UPxeZ7i0YxyhEwwI k1n2UX3wlueJQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 00A9617E35F0; Thu, 28 Nov 2024 11:32:14 +0100 (CET) Message-ID: <3d5f7106-6425-420c-abac-39feed11c95c@collabora.com> Date: Thu, 28 Nov 2024 11:32:13 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/7] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2 To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "tzimmermann@suse.de" , "simona@ffwll.ch" , "mripard@kernel.org" , "kernel@collabora.com" , "p.zabel@pengutronix.de" , "maarten.lankhorst@linux.intel.com" , "conor+dt@kernel.org" , "robh@kernel.org" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" References: <20241120124512.134278-1-angelogioacchino.delregno@collabora.com> <20241120124512.134278-3-angelogioacchino.delregno@collabora.com> <721896498fe9a5ba5a942fe837deb90d461b5090.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <721896498fe9a5ba5a942fe837deb90d461b5090.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 28/11/24 07:02, CK Hu (胡俊光) ha scritto: > Hi, Angelo: > > On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until you have verified the sender or the content. >> >> >> Add a binding for the HDMI TX v2 Encoder found in MediaTek MT8195 >> and MT8188 SoCs. >> >> This fully supports the HDMI Specification 2.0b, hence it provides >> support for 3D-HDMI, Polarity inversion, up to 16 bits Deep Color, >> color spaces including RGB444, YCBCR420/422/444 (ITU601/ITU709) and >> xvYCC, with output resolutions up to 3840x2160p@60Hz. >> >> Moreover, it also supports HDCP 1.4 and 2.3, Variable Refresh Rate >> (VRR) and Consumer Electronics Control (CEC). >> >> This IP also includes support for HDMI Audio, including IEC60958 >> and IEC61937 SPDIF, 8-channel PCM, DSD, and other lossless audio >> according to HDMI 2.0. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../mediatek/mediatek,mt8195-hdmi.yaml | 150 ++++++++++++++++++ >> 1 file changed, 150 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml >> new file mode 100644 >> index 000000000000..273a8871461e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml >> @@ -0,0 +1,150 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu0D_C3TwQ2-02jWYABnMIQ8vEoUwP0O4gbQndJnPUMpdi6wXdAHra9ivCfB7zoelDI7qsS20YdRlmP4bEKAABletXFX$ >> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu0D_C3TwQ2-02jWYABnMIQ8vEoUwP0O4gbQndJnPUMpdi6wXdAHra9ivCfB7zoelDI7qsS20YdRlmP4bEKAAFlnY-KY$ >> + >> +title: MediaTek HDMI-TX v2 Encoder >> + >> +maintainers: >> + - AngeloGioacchino Del Regno >> + - CK Hu >> + >> +description: | >> + The MediaTek HDMI-TX v2 encoder can generate HDMI format data based on >> + the HDMI Specification 2.0b. >> + >> +properties: >> + compatible: >> + enum: >> + - mediatek,mt8188-hdmi-tx >> + - mediatek,mt8195-hdmi-tx >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: HDMI APB clock >> + - description: HDCP top clock >> + - description: HDCP reference clock >> + - description: VPP HDMI Split clock > > I would like to know more about HDMI v2. > Would you map each v2 clock to v1 clock? > If one clock has no mapping, is it a new feature that v1 does not has? > The HDMIv2 HW block seems to be almost completely different from the v1, and it is also interconnected in a different way compared to MT8173 (the path goes through VPP1, while the v1 is just direct to DPI/MMSYS). The v1 block had specific clocks for the audio (i2s, I believe) and for the SPDIF, and I have no idea how v1 does HDCP, but I don't see any specific clock for that. The v2 block is clocked from the HDCP clock, the (apb) bus has its own clock, and the video out needs the vpp split clock. It's just different, and we can't shove the v2 binding inside of the v1 one, but even if we could, since the v2 block is *that much* different from v1, it'd be a mistake to do so. Since the binding describes hardware, and since this v2 HW is *very* different from v1, it needs a new binding document, that is true even if you find a way to get the clocks to match (which is not possible, anyway). Cheers, Angelo > Regards, > CK > >> + >> + clock-names: >> + items: >> + - const: bus >> + - const: hdcp >> + - const: hdcp24m >> + - const: hdmi-split >> + >> >> -- >> 2.47.0 >>